github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Snapshot and restore] Set file system repo compression to true by default (#221500)

Browse source 
Closes https://github.com/elastic/kibana/issues/210481

So far, file system was the only type of repository that had compression
set to false by default. But according with the [ES docs
](https://www.elastic.co/docs/deploy-manage/tools/snapshot-and-restore/shared-file-system-repository)
that default is true:

```
compress
(Optional, Boolean) If true, metadata files, such as index mappings and settings, are compressed in snapshots. Data files are not compressed. Defaults to true.
```
So this PR sets the default to true for FS.



https://github.com/user-attachments/assets/b14e24a9-0330-4cbf-863b-102030d70f92
This commit is contained in:
Sonia Sanz Vivas 2025-05-30 09:52:52 +02:00 • committed by GitHub
parent 12784c2ca5
commit 43328848f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/platform/plugins/private/snapshot_restore/__jest__/client_integration/repository_add.test.ts
View file

@ -236,7 +236,7 @@ describe('<RepositoryAdd />', () => {
type: fsRepository.type,
settings: {
location: fsRepository.settings.location,
compress: true,
compress: false,
chunkSize: fsRepository.settings.chunkSize,
maxSnapshotBytesPerSec: fsRepository.settings.maxSnapshotBytesPerSec,
maxRestoreBytesPerSec: fsRepository.settings.maxRestoreBytesPerSec,

2
x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/fs_settings.tsx
View file

@ -133,7 +133,7 @@ export const FSSettings: React.FunctionComponent<Props> = ({
defaultMessage="Compress snapshots"
/>
}
checked={!!compress}
checked={!(compress === false)}
onChange={(e) => {
updateRepositorySettings({
compress: e.target.checked,

1
x-pack/test/functional/page_objects/snapshot_restore_page.ts
View file

@ -249,7 +249,6 @@ export function SnapshotRestorePageProvider({ getService }: FtrProviderContext)
},
async createSourceOnlyRepositoryStepTwo(location: string) {
await testSubjects.setValue('locationInput', location);
await testSubjects.click('compressToggle');
await testSubjects.click('submitButton');
await retry.waitFor('repository list to be visible', async () => {
return await testSubjects.isDisplayed('repositoryList');