github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security solution] [Endpoint] Updates translations in policy details tab for blocklist and trusted applications (#128466)

Browse source 
* Updates translations in policy details tab for blocklist and trusted apps

* Fix wrong search placeholder on blocklist list page

* Fix wrong blocklist translation key

* Fixes more multilangs

* Adds 'entry' word next to 'blocklist' for singular reference

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
David Sánchez 2022-03-29 11:42:32 +02:00 • committed by GitHub
parent 23586d2e4f
commit 43ad6e2597
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 52 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

3
x-pack/plugins/security_solution/public/management/pages/blocklist/view/blocklist.tsx
View file

@ -95,6 +95,9 @@ const BLOCKLIST_PAGE_LABELS: ArtifactListPageProps['labels'] = {
'xpack.securitySolution.blocklist.emptyStatePrimaryButtonLabel',
{ defaultMessage: 'Add blocklist' }
),
searchPlaceholderInfo: i18n.translate('xpack.securitySolution.blocklist.searchPlaceholderInfo', {
defaultMessage: 'Search on the fields below: name, description, value',
}),
};
export const Blocklist = memo(() => {

47
x-pack/plugins/security_solution/public/management/pages/policy/view/tabs/blocklists_translations.ts
View file

@ -12,20 +12,20 @@ export const POLICY_ARTIFACT_BLOCKLISTS_LABELS = Object.freeze({
deleteModalTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.list.removeDialog.title',
{
defaultMessage: 'Remove blocklist from policy',
defaultMessage: 'Remove blocklist entry from policy',
}
),
deleteModalImpactInfo: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.list.removeDialog.messageCallout',
{
defaultMessage:
'This blocklist will be removed only from this policy and can still be found and managed from the artifact page.',
'This blocklist entry will be removed only from this policy and can still be found and managed from the artifact page.',
}
),
deleteModalErrorMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.list.removeDialog.errorToastTitle',
{
defaultMessage: 'Error while attempting to remove blocklist',
defaultMessage: 'Error while attempting to remove blocklist entry',
}
),
flyoutWarningCalloutMessage: (maxNumber: number) =>
@ -33,37 +33,37 @@ export const POLICY_ARTIFACT_BLOCKLISTS_LABELS = Object.freeze({
'xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.searchWarning.text',
{
defaultMessage:
'Only the first {maxNumber} blocklists are displayed. Please use the search bar to refine the results.',
'Only the first {maxNumber} blocklist entries are displayed. Please use the search bar to refine the results.',
values: { maxNumber },
}
),
flyoutNoArtifactsToBeAssignedMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.noAssignable',
{
defaultMessage: 'There are no blocklists that can be assigned to this policy.',
defaultMessage: 'There are no blocklist entries that can be assigned to this policy.',
}
),
flyoutTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.title',
{
defaultMessage: 'Assign blocklists',
defaultMessage: 'Assign blocklist entries',
}
),
flyoutSubtitle: (policyName: string): string =>
i18n.translate('xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.subtitle', {
defaultMessage: 'Select blocklists to add to {policyName}',
defaultMessage: 'Select blocklist entries to add to {policyName}',
values: { policyName },
}),
flyoutSearchPlaceholder: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.search.label',
{
defaultMessage: 'Search blocklists',
defaultMessage: 'Search blocklist entries',
}
),
flyoutErrorMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.toastError.text',
{
defaultMessage: `An error occurred updating blocklists`,
defaultMessage: `An error occurred updating blocklist entry`,
}
),
flyoutSuccessMessageText: (updatedExceptions: ExceptionListItemSchema[]): string =>
@ -71,56 +71,57 @@ export const POLICY_ARTIFACT_BLOCKLISTS_LABELS = Object.freeze({
? i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.toastSuccess.textMultiples',
{
defaultMessage: '{count} blocklists have been added to your list.',
defaultMessage: '{count} blocklist entries have been added to your list.',
values: { count: updatedExceptions.length },
}
)
: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.flyout.toastSuccess.textSingle',
{
defaultMessage: '"{name}" has been added to your blocklist list.',
defaultMessage: '"{name}" blocklist has been added to your list.',
values: { name: updatedExceptions[0].name },
}
),
emptyUnassignedTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.empty.unassigned.title',
{ defaultMessage: 'No assigned blocklists' }
{ defaultMessage: 'No assigned blocklist entries' }
),
emptyUnassignedMessage: (policyName: string): string =>
i18n.translate('xpack.securitySolution.endpoint.policy.blocklists.empty.unassigned.content', {
defaultMessage:
'There are currently no blocklists assigned to {policyName}. Assign blocklists now or add and manage them on the blocklists page.',
'There are currently no blocklist entries assigned to {policyName}. Assign blocklist entries now or add and manage them on the blocklist page.',
values: { policyName },
}),
emptyUnassignedPrimaryActionButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.empty.unassigned.primaryAction',
{
defaultMessage: 'Assign blocklists',
defaultMessage: 'Assign blocklist entry',
}
),
emptyUnassignedSecondaryActionButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.empty.unassigned.secondaryAction',
{
defaultMessage: 'Manage blocklists',
defaultMessage: 'Manage blocklist entries',
}
),
emptyUnexistingTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.empty.unexisting.title',
{ defaultMessage: 'No blocklists exist' }
{ defaultMessage: 'No blocklist entries exist' }
),
emptyUnexistingMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.empty.unexisting.content',
{
defaultMessage: 'There are currently no blocklists applied to your endpoints.',
defaultMessage: 'There are currently no blocklist entries applied to your endpoints.',
}
),
emptyUnexistingPrimaryActionButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.empty.unexisting.action',
{ defaultMessage: 'Add blocklists' }
{ defaultMessage: 'Add blocklist entry' }
),
listTotalItemCountMessage: (totalItemsCount: number): string =>
i18n.translate('xpack.securitySolution.endpoint.policy.blocklists.list.totalItemCount', {
defaultMessage: 'Showing {totalItemsCount, plural, one {# blocklist} other {# blocklists}}',
defaultMessage:
'Showing {totalItemsCount, plural, one {# blocklist entry} other {# blocklist entries}}',
values: { totalItemsCount },
}),
listRemoveActionNotAllowedMessage: i18n.translate(
@ -132,22 +133,22 @@ export const POLICY_ARTIFACT_BLOCKLISTS_LABELS = Object.freeze({
listSearchPlaceholderMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.list.search.placeholder',
{
defaultMessage: `Search on the fields below: name, description, IP`,
defaultMessage: `Search on the fields below: name, description, value`,
}
),
layoutTitle: i18n.translate('xpack.securitySolution.endpoint.policy.blocklists.layout.title', {
defaultMessage: 'Assigned blocklists',
defaultMessage: 'Assigned blocklist entries',
}),
layoutAssignButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.assignToPolicy',
{
defaultMessage: 'Assign blocklists to policy',
defaultMessage: 'Assign blocklist entry to policy',
}
),
layoutViewAllLinkMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.blocklists.layout.about.viewAllLinkLabel',
{
defaultMessage: 'view all blocklists',
defaultMessage: 'view all blocklist entries',
}
),
});

6
x-pack/plugins/security_solution/public/management/pages/policy/view/tabs/policy_tabs.tsx
View file

@ -123,7 +123,7 @@ export const PolicyTabs = React.memo(() => {
layoutAboutMessage: (count: number, link: React.ReactElement): React.ReactNode => (
<FormattedMessage
id="xpack.securitySolution.endpoint.policy.trustedApps.list.about"
defaultMessage="There {count, plural, one {is} other {are}} {count} trusted {count, plural, =1 {app} other {apps}} associated with this policy. Click here to {link}"
defaultMessage="There {count, plural, one {is} other {are}} {count} trusted {count, plural, =1 {application} other {applications}} associated with this policy. Click here to {link}"
values={{ count, link }}
/>
),
@ -156,7 +156,7 @@ export const PolicyTabs = React.memo(() => {
layoutAboutMessage: (count: number, link: React.ReactElement): React.ReactNode => (
<FormattedMessage
id="xpack.securitySolution.endpoint.policy.blocklists.list.about"
defaultMessage="There {count, plural, one {is} other {are}} {count} {count, plural, =1 {blocklist} other {blocklists}} associated with this policy. Click here to {link}"
defaultMessage="There {count, plural, one {is} other {are}} {count} {count, plural, =1 {blocklist} other {blocklist entries}} associated with this policy. Click here to {link}"
values={{ count, link }}
/>
),
@ -241,7 +241,7 @@ export const PolicyTabs = React.memo(() => {
[PolicyTabKeys.BLOCKLISTS]: {
id: PolicyTabKeys.BLOCKLISTS,
name: i18n.translate('xpack.securitySolution.endpoint.policy.details.tabs.blocklists', {
defaultMessage: 'Blocklists',
defaultMessage: 'Blocklist',
}),
content: (
<>

44
x-pack/plugins/security_solution/public/management/pages/policy/view/tabs/trusted_apps_translations.ts
View file

@ -12,14 +12,14 @@ export const POLICY_ARTIFACT_TRUSTED_APPS_LABELS = Object.freeze({
deleteModalTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.list.removeDialog.title',
{
defaultMessage: 'Remove trusted app from policy',
defaultMessage: 'Remove trusted application from policy',
}
),
deleteModalImpactInfo: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.list.removeDialog.messageCallout',
{
defaultMessage:
'This trusted app will be removed only from this policy and can still be found and managed from the artifact page.',
'This trusted application will be removed only from this policy and can still be found and managed from the artifact page.',
}
),
deleteModalErrorMessage: i18n.translate(
@ -33,37 +33,37 @@ export const POLICY_ARTIFACT_TRUSTED_APPS_LABELS = Object.freeze({
'xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.searchWarning.text',
{
defaultMessage:
'Only the first {maxNumber} trusted apps are displayed. Please use the search bar to refine the results.',
'Only the first {maxNumber} trusted applications are displayed. Please use the search bar to refine the results.',
values: { maxNumber },
}
),
flyoutNoArtifactsToBeAssignedMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.noAssignable',
{
defaultMessage: 'There are no trusted apps that can be assigned to this policy.',
defaultMessage: 'There are no trusted applications that can be assigned to this policy.',
}
),
flyoutTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.title',
{
defaultMessage: 'Assign trusted apps',
defaultMessage: 'Assign trusted applications',
}
),
flyoutSubtitle: (policyName: string): string =>
i18n.translate('xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.subtitle', {
defaultMessage: 'Select trusted apps to add to {policyName}',
defaultMessage: 'Select trusted applications to add to {policyName}',
values: { policyName },
}),
flyoutSearchPlaceholder: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.search.label',
{
defaultMessage: 'Search trusted apps',
defaultMessage: 'Search trusted applications',
}
),
flyoutErrorMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.toastError.text',
{
defaultMessage: `An error occurred updating trusted apps`,
defaultMessage: `An error occurred updating trusted applications`,
}
),
flyoutSuccessMessageText: (updatedExceptions: ExceptionListItemSchema[]): string =>
@ -71,61 +71,61 @@ export const POLICY_ARTIFACT_TRUSTED_APPS_LABELS = Object.freeze({
? i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.toastSuccess.textMultiples',
{
defaultMessage: '{count} trusted apps have been added to your list.',
defaultMessage: '{count} trusted applications have been added to your list.',
values: { count: updatedExceptions.length },
}
)
: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.flyout.toastSuccess.textSingle',
{
defaultMessage: '"{name}" has been added to your trusted app list.',
defaultMessage: '"{name}" has been added to your trusted application list.',
values: { name: updatedExceptions[0].name },
}
),
emptyUnassignedTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.empty.unassigned.title',
{ defaultMessage: 'No assigned trusted apps' }
{ defaultMessage: 'No assigned trusted applications' }
),
emptyUnassignedMessage: (policyName: string): string =>
i18n.translate('xpack.securitySolution.endpoint.policy.trustedApps.empty.unassigned.content', {
defaultMessage:
'There are currently no trusted apps assigned to {policyName}. Assign trusted apps now or add and manage them on the trusted apps page.',
'There are currently no trusted applications assigned to {policyName}. Assign trusted applications now or add and manage them on the trusted applications page.',
values: { policyName },
}),
emptyUnassignedPrimaryActionButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.empty.unassigned.primaryAction',
{
defaultMessage: 'Assign trusted apps',
defaultMessage: 'Assign trusted applications',
}
),
emptyUnassignedSecondaryActionButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.empty.unassigned.secondaryAction',
{
defaultMessage: 'Manage trusted apps',
defaultMessage: 'Manage trusted applications',
}
),
emptyUnexistingTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.empty.unexisting.title',
{ defaultMessage: 'No trusted apps exist' }
{ defaultMessage: 'No trusted applications exist' }
),
emptyUnexistingMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.empty.unexisting.content',
{ defaultMessage: 'There are currently no trusted apps applied to your endpoints.' }
{ defaultMessage: 'There are currently no trusted applications applied to your endpoints.' }
),
emptyUnexistingPrimaryActionButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.empty.unexisting.action',
{ defaultMessage: 'Add trusted apps' }
{ defaultMessage: 'Add trusted applications' }
),
listTotalItemCountMessage: (totalItemsCount: number): string =>
i18n.translate('xpack.securitySolution.endpoint.policy.trustedApps.list.totalItemCount', {
defaultMessage:
'Showing {totalItemsCount, plural, one {# trusted app} other {# trusted apps}}',
'Showing {totalItemsCount, plural, one {# trusted app} other {# trusted applications}}',
values: { totalItemsCount },
}),
listRemoveActionNotAllowedMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.list.removeActionNotAllowed',
{
defaultMessage: 'Globally applied trusted app cannot be removed from policy.',
defaultMessage: 'Globally applied trusted application cannot be removed from policy.',
}
),
listSearchPlaceholderMessage: i18n.translate(
@ -135,18 +135,18 @@ export const POLICY_ARTIFACT_TRUSTED_APPS_LABELS = Object.freeze({
}
),
layoutTitle: i18n.translate('xpack.securitySolution.endpoint.policy.trustedApps.layout.title', {
defaultMessage: 'Assigned trusted apps',
defaultMessage: 'Assigned trusted applications',
}),
layoutAssignButtonTitle: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.assignToPolicy',
{
defaultMessage: 'Assign trusted apps to policy',
defaultMessage: 'Assign trusted applications to policy',
}
),
layoutViewAllLinkMessage: i18n.translate(
'xpack.securitySolution.endpoint.policy.trustedApps.layout.about.viewAllLinkLabel',
{
defaultMessage: 'view all trusted apps',
defaultMessage: 'view all trusted applications',
}
),
});