github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.17] [dashboard] fix Chrome no longer hidden for reports (#206988) (#207265)

Browse source 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[dashboard] fix Chrome no longer hidden for reports
(#206988)](https://github.com/elastic/kibana/pull/206988)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-01-20T21:01:13Z","message":"[dashboard]
fix Chrome no longer hidden for reports (#206988)\n\nFixes
https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275
removed `setIsVisible`\r\nbecause
https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI
could not reproduce the top nav disappearing and reappearing
issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"583b8522510102c15b175f4aff772484b689869f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.18.0","v8.16.4","v8.17.2"],"title":"[dashboard]
fix Chrome no longer hidden for
reports","number":206988,"url":"https://github.com/elastic/kibana/pull/206988","mergeCommit":{"message":"[dashboard]
fix Chrome no longer hidden for reports (#206988)\n\nFixes
https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275
removed `setIsVisible`\r\nbecause
https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI
could not reproduce the top nav disappearing and reappearing
issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"583b8522510102c15b175f4aff772484b689869f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206988","number":206988,"mergeCommit":{"message":"[dashboard]
fix Chrome no longer hidden for reports (#206988)\n\nFixes
https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275
removed `setIsVisible`\r\nbecause
https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI
could not reproduce the top nav disappearing and reappearing
issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"583b8522510102c15b175f4aff772484b689869f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
This commit is contained in:
Kibana Machine 2025-01-21 09:45:53 +11:00 • committed by GitHub
parent 8fc349649f
commit 43bc17041e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/plugins/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
View file

@ -121,6 +121,13 @@ export function InternalDashboardTopNav({
dashboardTitleRef.current?.focus();
}, [title, viewMode]);
/*
* Manage chrome visibility when dashboard is in print mode.
*/
useEffect(() => {
if (!embedSettings && viewMode === 'print') coreServices.chrome.setIsVisible(false);
}, [embedSettings, viewMode]);
/**
* populate recently accessed, and set is chrome visible.
*/