github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Reset dirty saved query on reload (#43927)

Browse source 
* Clears changes a loaded saved query before loading another one

* Adds general functional test to ensure changes to a saved query are discarded on reloading it

* Moves resetting a dirty saved query to the app controllers in Discover, Visualize and Dashboard
This commit is contained in:
Christiane (Tina) Heiligers 2019-08-27 12:00:47 -07:00 • committed by GitHub
parent eeff5ef683
commit 43df3a78ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/legacy/core_plugins/kibana/public/dashboard/dashboard_app_controller.tsx
View file

@ -432,7 +432,7 @@ export class DashboardAppController {
};
$scope.onSavedQueryUpdated = savedQuery => {
$scope.savedQuery = savedQuery;
$scope.savedQuery = { ...savedQuery };
};
$scope.onClearSavedQuery = () => {

2
src/legacy/core_plugins/kibana/public/discover/controllers/discover.js
View file

@ -932,7 +932,7 @@ function discoverController(
};
$scope.onSavedQueryUpdated = savedQuery => {
$scope.savedQuery = savedQuery;
$scope.savedQuery = { ...savedQuery };
};
$scope.onClearSavedQuery = () => {

2
src/legacy/core_plugins/kibana/public/visualize/editor/editor.js
View file

@ -481,7 +481,7 @@ function VisEditor(
};
$scope.onSavedQueryUpdated = savedQuery => {
$scope.savedQuery = savedQuery;
$scope.savedQuery = { ...savedQuery };
};
$scope.onClearSavedQuery = () => {

7
test/functional/apps/discover/_saved_queries.js
View file

@ -123,6 +123,13 @@ export default function ({ getService, getPageObjects }) {
await savedQueryManagementComponent.clearCurrentlyLoadedQuery();
expect(await queryBar.getQueryString()).to.eql('');
});
it('resets any changes to a loaded query on reloading the same saved query', async () => {
await savedQueryManagementComponent.loadSavedQuery('OkResponse');
await queryBar.setQuery('response:503');
await savedQueryManagementComponent.loadSavedQuery('OkResponse');
expect(await queryBar.getQueryString()).to.eql('response:404');
});
});
});
}