github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Cases] Get connector's information from actionsTypeRegistry (#101279)

Browse source 
Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
This commit is contained in:
Christos Nasikas 2021-06-08 13:35:54 +03:00 • committed by GitHub
parent 2d3340b543
commit 451f64bde0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 234 additions and 183 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/cases/public/common/lib/kibana/kibana_react.mock.ts
View file

@ -12,9 +12,15 @@ import { coreMock } from '../../../../../../../src/core/public/mocks';
import { KibanaContextProvider } from '../../../../../../../src/plugins/kibana_react/public';
import { StartServices } from '../../../types';
import { EuiTheme } from '../../../../../../../src/plugins/kibana_react/common';
import { securityMock } from '../../../../../security/public/mocks';
import { triggersActionsUiMock } from '../../../../../triggers_actions_ui/public/mocks';
export const createStartServicesMock = (): StartServices =>
(coreMock.createStart() as unknown) as StartServices;
(({
...coreMock.createStart(),
security: securityMock.createStart(),
triggersActionsUi: triggersActionsUiMock.createStart(),
} as unknown) as StartServices);
export const createWithKibanaMock = () => {
const services = createStartServicesMock();

7
x-pack/plugins/cases/public/components/case_view/index.test.tsx
View file

@ -28,6 +28,7 @@ import { useConnectors } from '../../containers/configure/use_connectors';
import { connectorsMock } from '../../containers/configure/mock';
import { usePostPushToService } from '../../containers/use_post_push_to_service';
import { CaseType, ConnectorTypes } from '../../../common';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../containers/use_update_case');
jest.mock('../../containers/use_get_case_user_actions');
@ -35,11 +36,13 @@ jest.mock('../../containers/use_get_case');
jest.mock('../../containers/configure/use_connectors');
jest.mock('../../containers/use_post_push_to_service');
jest.mock('../user_action_tree/user_action_timestamp');
jest.mock('../../common/lib/kibana');
const useUpdateCaseMock = useUpdateCase as jest.Mock;
const useGetCaseUserActionsMock = useGetCaseUserActions as jest.Mock;
const useConnectorsMock = useConnectors as jest.Mock;
const usePostPushToServiceMock = usePostPushToService as jest.Mock;
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
const alertsHit = [
{
@ -160,6 +163,10 @@ describe('CaseView ', () => {
pushCaseToExternalService,
}));
useConnectorsMock.mockImplementation(() => ({ connectors: connectorsMock, loading: false }));
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
});
it('should render CaseComponent', async () => {

8
x-pack/plugins/cases/public/components/configure_cases/connectors.test.tsx
View file

@ -13,6 +13,10 @@ import { TestProviders } from '../../common/mock';
import { ConnectorsDropdown } from './connectors_dropdown';
import { connectors } from './__mock__';
import { ConnectorTypes } from '../../../common';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../common/lib/kibana');
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('Connectors', () => {
let wrapper: ReactWrapper;
@ -31,6 +35,10 @@ describe('Connectors', () => {
};
beforeAll(() => {
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: 'test',
iconClass: 'logoSecurity',
});
wrapper = mount(<Connectors {...props} />, { wrappingComponent: TestProviders });
});

54
x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.test.tsx
View file

@ -12,6 +12,10 @@ import { EuiSuperSelect } from '@elastic/eui';
import { ConnectorsDropdown, Props } from './connectors_dropdown';
import { TestProviders } from '../../common/mock';
import { connectors } from './__mock__';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../common/lib/kibana');
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('ConnectorsDropdown', () => {
let wrapper: ReactWrapper;
@ -24,6 +28,10 @@ describe('ConnectorsDropdown', () => {
};
beforeAll(() => {
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
wrapper = mount(<ConnectorsDropdown {...props} />, { wrappingComponent: TestProviders });
});
@ -73,14 +81,7 @@ describe('ConnectorsDropdown', () => {
>
<Styled(EuiIcon)
size="m"
type={
Object {
"$$typeof": Symbol(react.lazy),
"_ctor": [Function],
"_result": null,
"_status": -1,
}
}
type="logoSecurity"
/>
</EuiFlexItem>
<EuiFlexItem>
@ -103,14 +104,7 @@ describe('ConnectorsDropdown', () => {
>
<Styled(EuiIcon)
size="m"
type={
Object {
"$$typeof": Symbol(react.lazy),
"_ctor": [Function],
"_result": null,
"_status": -1,
}
}
type="logoSecurity"
/>
</EuiFlexItem>
<EuiFlexItem>
@ -133,14 +127,7 @@ describe('ConnectorsDropdown', () => {
>
<Styled(EuiIcon)
size="m"
type={
Object {
"$$typeof": Symbol(react.lazy),
"_ctor": [Function],
"_result": null,
"_status": -1,
}
}
type="logoSecurity"
/>
</EuiFlexItem>
<EuiFlexItem>
@ -163,14 +150,7 @@ describe('ConnectorsDropdown', () => {
>
<Styled(EuiIcon)
size="m"
type={
Object {
"$$typeof": Symbol(react.lazy),
"_ctor": [Function],
"_result": null,
"_status": -1,
}
}
type="logoSecurity"
/>
</EuiFlexItem>
<EuiFlexItem>
@ -210,9 +190,13 @@ describe('ConnectorsDropdown', () => {
wrappingComponent: TestProviders,
});
expect(newWrapper.find('button span:not([data-euiicon-type])').at(1).text()).toBe(
'My Connector'
);
expect(
newWrapper
.find('[data-test-subj="dropdown-connectors"]')
.first()
.text()
.includes('My Connector, is selected')
).toBeTruthy();
});
test('if the props hideConnectorServiceNowSir is true, the connector should not be part of the list of options ', () => {

8
x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.tsx
View file

@ -11,8 +11,8 @@ import styled from 'styled-components';
import { ConnectorTypes } from '../../../common';
import { ActionConnector } from '../../containers/configure/types';
import { connectorsConfiguration } from '../connectors';
import * as i18n from './translations';
import { useKibana } from '../../common/lib/kibana';
export interface Props {
connectors: ActionConnector[];
@ -65,6 +65,7 @@ const ConnectorsDropdownComponent: React.FC<Props> = ({
appendAddConnectorButton = false,
hideConnectorServiceNowSir = false,
}) => {
const { triggersActionsUi } = useKibana().services;
const connectorsAsOptions = useMemo(() => {
const connectorsFormatted = connectors.reduce(
(acc, connector) => {
@ -80,7 +81,10 @@ const ConnectorsDropdownComponent: React.FC<Props> = ({
<EuiFlexGroup gutterSize="none" alignItems="center" responsive={false}>
<EuiFlexItem grow={false}>
<EuiIconExtended
type={connectorsConfiguration[connector.actionTypeId]?.logo ?? ''}
type={
triggersActionsUi.actionTypeRegistry.get(connector.actionTypeId)?.iconClass ??
''
}
size={ICON_SIZE}
/>
</EuiFlexItem>

9
x-pack/plugins/cases/public/components/configure_cases/field_mapping.test.tsx
View file

@ -12,6 +12,10 @@ import { FieldMapping, FieldMappingProps } from './field_mapping';
import { mappings } from './__mock__';
import { TestProviders } from '../../common/mock';
import { FieldMappingRowStatic } from './field_mapping_row_static';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../common/lib/kibana');
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('FieldMappingRow', () => {
let wrapper: ReactWrapper;
@ -22,8 +26,13 @@ describe('FieldMappingRow', () => {
};
beforeAll(() => {
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
wrapper = mount(<FieldMapping {...props} />, { wrappingComponent: TestProviders });
});
test('it renders', () => {
expect(
wrapper.find('[data-test-subj="case-configure-field-mappings-row-wrapper"]').first().exists()

8
x-pack/plugins/cases/public/components/configure_cases/field_mapping.tsx
View file

@ -13,7 +13,7 @@ import { FieldMappingRowStatic } from './field_mapping_row_static';
import * as i18n from './translations';
import { CaseConnectorMapping } from '../../containers/configure/types';
import { connectorsConfiguration } from '../connectors';
import { useKibana } from '../../common/lib/kibana';
const FieldRowWrapper = styled.div`
margin: 10px 0;
@ -31,8 +31,10 @@ const FieldMappingComponent: React.FC<FieldMappingProps> = ({
isLoading,
mappings,
}) => {
const { triggersActionsUi } = useKibana().services;
const selectedConnector = useMemo(
() => connectorsConfiguration[connectorActionTypeId] ?? { fields: {} },
() => triggersActionsUi.actionTypeRegistry.get(connectorActionTypeId) ?? { fields: {} },
// eslint-disable-next-line react-hooks/exhaustive-deps
[connectorActionTypeId]
);
return mappings.length ? (
@ -45,7 +47,7 @@ const FieldMappingComponent: React.FC<FieldMappingProps> = ({
</EuiFlexItem>
<EuiFlexItem>
<span className="euiFormLabel">
{i18n.FIELD_MAPPING_SECOND_COL(selectedConnector.name)}
{i18n.FIELD_MAPPING_SECOND_COL(selectedConnector.actionTypeTitle ?? '')}
</span>
</EuiFlexItem>
<EuiFlexItem>

139
x-pack/plugins/cases/public/components/configure_cases/index.test.tsx
View file

@ -7,18 +7,12 @@
import React from 'react';
import { ReactWrapper, mount } from 'enzyme';
import { waitFor } from '@testing-library/react';
import { ConfigureCases } from '.';
import { TestProviders } from '../../common/mock';
import { Connectors } from './connectors';
import { ClosureOptions } from './closure_options';
import {
ActionConnector,
ConnectorAddFlyout,
ConnectorEditFlyout,
TriggersAndActionsUIPublicPluginStart,
} from '../../../../triggers_actions_ui/public';
import { actionTypeRegistryMock } from '../../../../triggers_actions_ui/public/application/action_type_registry.mock';
import { useKibana } from '../../common/lib/kibana';
import { useConnectors } from '../../containers/configure/use_connectors';
@ -33,6 +27,7 @@ import {
useActionTypesResponse,
} from './__mock__';
import { ConnectorTypes, SECURITY_SOLUTION_OWNER } from '../../../common';
import { actionTypeRegistryMock } from '../../../../triggers_actions_ui/public/application/action_type_registry.mock';
jest.mock('../../common/lib/kibana');
jest.mock('../../containers/configure/use_connectors');
@ -46,52 +41,13 @@ const useGetUrlSearchMock = jest.fn();
const useActionTypesMock = useActionTypes as jest.Mock;
describe('ConfigureCases', () => {
beforeAll(() => {
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
});
beforeEach(() => {
useKibanaMock().services.triggersActionsUi = ({
actionTypeRegistry: actionTypeRegistryMock.create(),
getAddConnectorFlyout: jest.fn().mockImplementation(() => (
<ConnectorAddFlyout
onClose={() => {}}
actionTypeRegistry={actionTypeRegistryMock.create()}
actionTypes={[
{
id: '.servicenow',
name: 'servicenow',
enabled: true,
enabledInConfig: true,
enabledInLicense: true,
minimumLicenseRequired: 'gold',
},
{
id: '.jira',
name: 'jira',
enabled: true,
enabledInConfig: true,
enabledInLicense: true,
minimumLicenseRequired: 'gold',
},
{
id: '.resilient',
name: 'resilient',
enabled: true,
enabledInConfig: true,
enabledInLicense: true,
minimumLicenseRequired: 'gold',
},
]}
/>
)),
getEditConnectorFlyout: jest
.fn()
.mockImplementation(() => (
<ConnectorEditFlyout
onClose={() => {}}
actionTypeRegistry={actionTypeRegistryMock.create()}
initialConnector={connectors[1] as ActionConnector}
/>
)),
} as unknown) as TriggersAndActionsUIPublicPluginStart;
useActionTypesMock.mockImplementation(() => useActionTypesResponse);
});
@ -116,13 +72,11 @@ describe('ConfigureCases', () => {
});
test('it does NOT render the ConnectorAddFlyout', () => {
// Components from triggersActionsUi do not have a data-test-subj
expect(wrapper.find(ConnectorAddFlyout).exists()).toBeFalsy();
expect(wrapper.find('ConnectorAddFlyout').exists()).toBeFalsy();
});
test('it does NOT render the ConnectorEditFlyout', () => {
// Components from triggersActionsUi do not have a data-test-subj
expect(wrapper.find(ConnectorEditFlyout).exists()).toBeFalsy();
expect(wrapper.find('ConnectorEditFlyout').exists()).toBeFalsy();
});
test('it does NOT render the EuiCallOut', () => {
@ -221,8 +175,8 @@ describe('ConfigureCases', () => {
expect(wrapper.find(ClosureOptions).prop('closureTypeSelected')).toBe('close-by-user');
// Flyouts
expect(wrapper.find(ConnectorAddFlyout).exists()).toBe(false);
expect(wrapper.find(ConnectorEditFlyout).exists()).toBe(false);
expect(wrapper.find('ConnectorAddFlyout').exists()).toBe(false);
expect(wrapper.find('ConnectorEditFlyout').exists()).toBe(false);
});
test('it disables correctly when the user cannot crud', () => {
@ -577,40 +531,67 @@ describe('user interactions', () => {
useGetUrlSearchMock.mockImplementation(() => searchURL);
});
test('it show the add flyout when pressing the add connector button', () => {
test('it show the add flyout when pressing the add connector button', async () => {
const wrapper = mount(<ConfigureCases userCanCrud owner={[SECURITY_SOLUTION_OWNER]} />, {
wrappingComponent: TestProviders,
});
wrapper.find('button[data-test-subj="dropdown-connectors"]').simulate('click');
wrapper.update();
wrapper.find('button[data-test-subj="dropdown-connector-add-connector"]').simulate('click');
wrapper.update();
expect(wrapper.find(ConnectorAddFlyout).exists()).toBe(true);
expect(wrapper.find(ConnectorAddFlyout).prop('actionTypes')).toEqual([
expect.objectContaining({
id: '.servicenow',
}),
expect.objectContaining({
id: '.jira',
}),
expect.objectContaining({
id: '.resilient',
}),
]);
wrapper.find('button[data-test-subj="dropdown-connectors"]').simulate('click');
wrapper.find('button[data-test-subj="dropdown-connector-add-connector"]').simulate('click');
await waitFor(() => {
wrapper.update();
expect(wrapper.find('ConnectorAddFlyout').exists()).toBe(true);
expect(wrapper.find('ConnectorAddFlyout').prop('actionTypes')).toEqual([
expect.objectContaining({
id: '.servicenow',
}),
expect.objectContaining({
id: '.jira',
}),
expect.objectContaining({
id: '.resilient',
}),
expect.objectContaining({
id: '.servicenow-sir',
}),
]);
});
});
test('it show the edit flyout when pressing the update connector button', () => {
test('it show the edit flyout when pressing the update connector button', async () => {
const actionType = actionTypeRegistryMock.createMockActionTypeModel({
id: '.resilient',
validateConnector: () => {
return Promise.resolve({});
},
validateParams: () => {
const validationResult = { errors: {} };
return Promise.resolve(validationResult);
},
actionConnectorFields: null,
});
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest
.fn()
.mockReturnValue(actionType);
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.has = jest
.fn()
.mockReturnValue(true);
const wrapper = mount(<ConfigureCases userCanCrud owner={[SECURITY_SOLUTION_OWNER]} />, {
wrappingComponent: TestProviders,
});
wrapper
.find('button[data-test-subj="case-configure-update-selected-connector-button"]')
.simulate('click');
wrapper.update();
expect(wrapper.find(ConnectorEditFlyout).exists()).toBe(true);
expect(wrapper.find(ConnectorEditFlyout).prop('initialConnector')).toEqual(connectors[1]);
await waitFor(() => {
wrapper.update();
expect(wrapper.find('ConnectorEditFlyout').exists()).toBe(true);
expect(wrapper.find('ConnectorEditFlyout').prop('initialConnector')).toEqual(connectors[1]);
});
expect(
wrapper.find('[data-test-subj="case-configure-action-bottom-bar"]').exists()
).toBeFalsy();

9
x-pack/plugins/cases/public/components/configure_cases/mapping.test.tsx
View file

@ -11,6 +11,10 @@ import { mount } from 'enzyme';
import { TestProviders } from '../../common/mock';
import { Mapping, MappingProps } from './mapping';
import { mappings } from './__mock__';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../common/lib/kibana');
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('Mapping', () => {
const props: MappingProps = {
@ -21,7 +25,12 @@ describe('Mapping', () => {
beforeEach(() => {
jest.clearAllMocks();
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: 'ServiceNow ITSM',
iconClass: 'logoSecurity',
});
});
test('it shows mapping form group', () => {
const wrapper = mount(<Mapping {...props} />, { wrappingComponent: TestProviders });
expect(wrapper.find('[data-test-subj="static-mappings"]').first().exists()).toBe(true);

24
x-pack/plugins/cases/public/components/configure_cases/mapping.tsx
View file

@ -14,7 +14,7 @@ import * as i18n from './translations';
import { FieldMapping } from './field_mapping';
import { CaseConnectorMapping } from '../../containers/configure/types';
import { connectorsConfiguration } from '../connectors';
import { useKibana } from '../../common/lib/kibana';
export interface MappingProps {
connectorActionTypeId: string;
@ -27,21 +27,29 @@ const MappingComponent: React.FC<MappingProps> = ({
isLoading,
mappings,
}) => {
const selectedConnector = useMemo(() => connectorsConfiguration[connectorActionTypeId], [
connectorActionTypeId,
]);
const { triggersActionsUi } = useKibana().services;
const selectedConnector = useMemo(
() => triggersActionsUi.actionTypeRegistry.get(connectorActionTypeId),
[connectorActionTypeId, triggersActionsUi]
);
const fieldMappingDesc: { desc: string; color: TextColor } = useMemo(
() =>
mappings.length > 0 || isLoading
? { desc: i18n.FIELD_MAPPING_DESC(selectedConnector.name), color: 'subdued' }
: { desc: i18n.FIELD_MAPPING_DESC_ERR(selectedConnector.name), color: 'danger' },
[isLoading, mappings.length, selectedConnector.name]
? {
desc: i18n.FIELD_MAPPING_DESC(selectedConnector.actionTypeTitle ?? ''),
color: 'subdued',
}
: {
desc: i18n.FIELD_MAPPING_DESC_ERR(selectedConnector.actionTypeTitle ?? ''),
color: 'danger',
},
[isLoading, mappings.length, selectedConnector.actionTypeTitle]
);
return (
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem grow={false}>
<EuiText size="xs">
<h4>{i18n.FIELD_MAPPING_TITLE(selectedConnector.name)}</h4>
<h4>{i18n.FIELD_MAPPING_TITLE(selectedConnector.actionTypeTitle ?? '')}</h4>
<EuiTextColor data-test-subj="field-mapping-desc" color={fieldMappingDesc.color}>
{fieldMappingDesc.desc}
</EuiTextColor>

8
x-pack/plugins/cases/public/components/connector_selector/form.test.tsx
View file

@ -11,17 +11,23 @@ import { UseField, Form, useForm, FormHook } from '../../common/shared_imports';
import { ConnectorSelector } from './form';
import { connectorsMock } from '../../containers/mock';
import { getFormMock } from '../__mock__/form';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../../../../../src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form');
jest.mock('../../common/lib/kibana');
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
const useFormMock = useForm as jest.Mock;
describe('ConnectorSelector', () => {
const formHookMock = getFormMock({ connectorId: connectorsMock[0].id });
beforeEach(() => {
jest.resetAllMocks();
useFormMock.mockImplementation(() => ({ form: formHookMock }));
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: 'test',
iconClass: 'logoSecurity',
});
});
it('it should render', async () => {

12
x-pack/plugins/cases/public/components/connectors/card.tsx
View file

@ -9,8 +9,8 @@ import React, { memo, useMemo } from 'react';
import { EuiCard, EuiIcon, EuiLoadingSpinner } from '@elastic/eui';
import styled from 'styled-components';
import { connectorsConfiguration } from '.';
import { ConnectorTypes } from '../../../common';
import { useKibana } from '../../common/lib/kibana';
interface ConnectorCardProps {
connectorType: ConnectorTypes;
@ -31,6 +31,8 @@ const ConnectorCardDisplay: React.FC<ConnectorCardProps> = ({
listItems,
isLoading,
}) => {
const { triggersActionsUi } = useKibana().services;
const description = useMemo(
() => (
<StyledText>
@ -46,7 +48,13 @@ const ConnectorCardDisplay: React.FC<ConnectorCardProps> = ({
[listItems]
);
const icon = useMemo(
() => <EuiIcon size="xl" type={connectorsConfiguration[`${connectorType}`]?.logo ?? ''} />,
() => (
<EuiIcon
size="xl"
type={triggersActionsUi.actionTypeRegistry.get(`${connectorType}`)?.iconClass ?? ''}
/>
),
// eslint-disable-next-line react-hooks/exhaustive-deps
[connectorType]
);
return (

39
x-pack/plugins/cases/public/components/connectors/config.ts
View file

@ -1,39 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import {
getResilientActionType,
getServiceNowITSMActionType,
getServiceNowSIRActionType,
getJiraActionType,
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
} from '../../../../triggers_actions_ui/public/common';
import { ConnectorConfiguration } from './types';
const resilient = getResilientActionType();
const serviceNowITSM = getServiceNowITSMActionType();
const serviceNowSIR = getServiceNowSIRActionType();
const jira = getJiraActionType();
export const connectorsConfiguration: Record<string, ConnectorConfiguration> = {
'.servicenow': {
name: serviceNowITSM.actionTypeTitle ?? '',
logo: serviceNowITSM.iconClass,
},
'.servicenow-sir': {
name: serviceNowSIR.actionTypeTitle ?? '',
logo: serviceNowSIR.iconClass,
},
'.jira': {
name: jira.actionTypeTitle ?? '',
logo: jira.iconClass,
},
'.resilient': {
name: resilient.actionTypeTitle ?? '',
logo: resilient.iconClass,
},
};

1
x-pack/plugins/cases/public/components/connectors/index.ts
View file

@ -19,7 +19,6 @@ import {
export { getActionType as getCaseConnectorUi } from './case';
export * from './config';
export * from './types';
interface GetCaseConnectorsReturn {

7
x-pack/plugins/cases/public/components/connectors/jira/case_fields.test.tsx
View file

@ -9,6 +9,7 @@ import React from 'react';
import { mount } from 'enzyme';
import { omit } from 'lodash/fp';
import { useKibana } from '../../../common/lib/kibana';
import { connector, issues } from '../mock';
import { useGetIssueTypes } from './use_get_issue_types';
import { useGetFieldsByIssueType } from './use_get_fields_by_issue_type';
@ -27,6 +28,7 @@ const useGetIssueTypesMock = useGetIssueTypes as jest.Mock;
const useGetFieldsByIssueTypeMock = useGetFieldsByIssueType as jest.Mock;
const useGetSingleIssueMock = useGetSingleIssue as jest.Mock;
const useGetIssuesMock = useGetIssues as jest.Mock;
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('Jira Fields', () => {
const useGetIssueTypesResponse = {
@ -87,6 +89,10 @@ describe('Jira Fields', () => {
useGetIssueTypesMock.mockReturnValue(useGetIssueTypesResponse);
useGetFieldsByIssueTypeMock.mockReturnValue(useGetFieldsByIssueTypeResponse);
useGetSingleIssueMock.mockReturnValue(useGetSingleIssueResponse);
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.jira',
iconClass: 'logoSecurity',
});
jest.clearAllMocks();
});
@ -144,6 +150,7 @@ describe('Jira Fields', () => {
priority: 'High',
});
});
test('it searches parent correctly', async () => {
useGetFieldsByIssueTypeMock.mockReturnValue({
...useGetFieldsByIssueTypeResponse,

7
x-pack/plugins/cases/public/components/connectors/servicenow/servicenow_itsm_case_fields.test.tsx
View file

@ -10,6 +10,7 @@ import { waitFor, act } from '@testing-library/react';
import { EuiSelect } from '@elastic/eui';
import { mount } from 'enzyme';
import { useKibana } from '../../../common/lib/kibana';
import { connector, choices as mockChoices } from '../mock';
import { Choice } from './types';
import Fields from './servicenow_itsm_case_fields';
@ -24,6 +25,8 @@ jest.mock('./use_get_choices', () => ({
},
}));
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('ServiceNowITSM Fields', () => {
const fields = {
severity: '1',
@ -36,6 +39,10 @@ describe('ServiceNowITSM Fields', () => {
beforeEach(() => {
jest.clearAllMocks();
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
});
it('all params fields are rendered - isEdit: true', () => {

7
x-pack/plugins/cases/public/components/connectors/servicenow/servicenow_sir_case_fields.test.tsx
View file

@ -10,6 +10,7 @@ import { mount } from 'enzyme';
import { waitFor, act } from '@testing-library/react';
import { EuiSelect } from '@elastic/eui';
import { useKibana } from '../../../common/lib/kibana';
import { connector, choices as mockChoices } from '../mock';
import { Choice } from './types';
import Fields from './servicenow_sir_case_fields';
@ -24,6 +25,8 @@ jest.mock('./use_get_choices', () => ({
},
}));
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
describe('ServiceNowSIR Fields', () => {
const fields = {
destIp: true,
@ -38,6 +41,10 @@ describe('ServiceNowSIR Fields', () => {
beforeEach(() => {
jest.clearAllMocks();
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow-sir',
iconClass: 'logoSecurity',
});
});
it('all params fields are rendered - isEdit: true', () => {

2
x-pack/plugins/cases/public/components/connectors/types.ts
View file

@ -5,7 +5,7 @@
* 2.0.
*/
import { IconType } from '@elastic/eui/src/components/icon/icon';
import { IconType } from '@elastic/eui';
import React from 'react';
import {

8
x-pack/plugins/cases/public/components/create/connector.test.tsx
View file

@ -25,6 +25,14 @@ jest.mock('../../common/lib/kibana', () => {
services: {
notifications: {},
http: {},
triggersActionsUi: {
actionTypeRegistry: {
get: jest.fn().mockReturnValue({
actionTypeTitle: 'test',
iconClass: 'logoSecurity',
}),
},
},
},
}),
};

8
x-pack/plugins/cases/public/components/create/form_context.test.tsx
View file

@ -11,6 +11,7 @@ import { act, waitFor } from '@testing-library/react';
import { EuiComboBox, EuiComboBoxOptionOption } from '@elastic/eui';
import { ConnectorTypes, SECURITY_SOLUTION_OWNER } from '../../../common';
import { useKibana } from '../../common/lib/kibana';
import { TestProviders } from '../../common/mock';
import { usePostCase } from '../../containers/use_post_case';
import { usePostComment } from '../../containers/use_post_comment';
@ -54,6 +55,7 @@ jest.mock('../connectors/jira/use_get_fields_by_issue_type');
jest.mock('../connectors/jira/use_get_single_issue');
jest.mock('../connectors/jira/use_get_issues');
jest.mock('../connectors/servicenow/use_get_choices');
jest.mock('../../common/lib/kibana');
const useConnectorsMock = useConnectors as jest.Mock;
const useCaseConfigureMock = useCaseConfigure as jest.Mock;
@ -67,6 +69,7 @@ const useGetFieldsByIssueTypeMock = useGetFieldsByIssueType as jest.Mock;
const useGetChoicesMock = useGetChoices as jest.Mock;
const postCase = jest.fn();
const pushCaseToExternalService = jest.fn();
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
const defaultPostCase = {
isLoading: false,
@ -130,7 +133,12 @@ describe('Create case', () => {
tags: sampleTags,
fetchTags,
}));
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
});
beforeEach(() => {
jest.clearAllMocks();
});

10
x-pack/plugins/cases/public/components/edit_connector/index.test.tsx
View file

@ -7,15 +7,18 @@
import React from 'react';
import { mount } from 'enzyme';
import { waitFor } from '@testing-library/react';
import { EditConnector } from './index';
import { getFormMock, useFormMock } from '../__mock__/form';
import { TestProviders } from '../../common/mock';
import { connectorsMock } from '../../containers/configure/mock';
import { waitFor } from '@testing-library/react';
import { caseUserActions } from '../../containers/mock';
import { useKibana } from '../../common/lib/kibana';
jest.mock('../../../../../../src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form');
jest.mock('../../common/lib/kibana');
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
const onSubmit = jest.fn();
const defaultProps = {
@ -33,8 +36,11 @@ describe('EditConnector ', () => {
const formHookMock = getFormMock({ connectorId: sampleConnector });
beforeEach(() => {
jest.clearAllMocks();
jest.resetAllMocks();
useFormMock.mockImplementation(() => ({ form: formHookMock }));
useKibanaMock().services.triggersActionsUi.actionTypeRegistry.get = jest.fn().mockReturnValue({
actionTypeTitle: '.servicenow',
iconClass: 'logoSecurity',
});
});
it('Renders no connector, and then edit', async () => {

1
x-pack/plugins/cases/public/components/edit_connector/index.tsx
View file

@ -202,6 +202,7 @@ export const EditConnector = React.memo(
payload: true,
});
}, [dispatch]);
return (
<EuiText>
<MyFlexGroup alignItems="center" gutterSize="xs" justifyContent="spaceBetween">

17
x-pack/plugins/cases/public/components/recent_cases/index.test.tsx
View file

@ -13,8 +13,11 @@ import { TestProviders } from '../../common/mock';
import { useGetCases } from '../../containers/use_get_cases';
import { useGetCasesMockState } from '../../containers/mock';
import { SECURITY_SOLUTION_OWNER } from '../../../common';
import { useCurrentUser } from '../../common/lib/kibana/hooks';
jest.mock('../../containers/use_get_cases');
jest.mock('../../common/lib/kibana/hooks');
configure({ testIdAttribute: 'data-test-subj' });
const defaultProps = {
allCasesNavigation: {
@ -32,16 +35,25 @@ const defaultProps = {
maxCasesToShow: 10,
owner: [SECURITY_SOLUTION_OWNER],
};
const setFilters = jest.fn();
const mockData = {
...useGetCasesMockState,
setFilters,
};
const useGetCasesMock = useGetCases as jest.Mock;
const useCurrentUserMock = useCurrentUser as jest.Mock;
describe('RecentCases', () => {
beforeEach(() => {
jest.clearAllMocks();
useGetCasesMock.mockImplementation(() => mockData);
useCurrentUserMock.mockResolvedValue({
email: 'elastic@elastic.co',
fullName: 'Elastic',
username: 'elastic',
});
});
it('is good at loading', () => {
@ -83,8 +95,9 @@ describe('RecentCases', () => {
<RecentCases {...defaultProps} />
</TestProviders>
);
const yo = getByTestId('myRecentlyReported');
userEvent.click(yo);
const element = getByTestId('myRecentlyReported');
userEvent.click(element);
expect(setFilters).toHaveBeenCalled();
});
});

1
x-pack/plugins/cases/public/components/recent_cases/index.tsx
View file

@ -50,6 +50,7 @@ const RecentCasesComponent = ({
: {},
[currentUser, recentCasesFilterBy]
);
return (
<>
<>

8
x-pack/plugins/cases/public/containers/configure/mock.ts
View file

@ -114,6 +114,14 @@ export const actionTypesMock: ActionTypeConnector[] = [
enabledInConfig: true,
enabledInLicense: true,
},
{
id: '.servicenow-sir',
name: 'ServiceNow SIR',
minimumLicenseRequired: 'platinum',
enabled: false,
enabledInConfig: true,
enabledInLicense: true,
},
];
export const caseConfigurationResposeMock: CasesConfigureResponse = {

7
x-pack/plugins/triggers_actions_ui/public/common/index.ts
View file

@ -10,10 +10,3 @@ export * from './constants';
export * from './index_controls';
export * from './lib';
export * from './types';
export {
getServiceNowITSMActionType,
getServiceNowSIRActionType,
} from '../application/components/builtin_action_types/servicenow';
export { getJiraActionType } from '../application/components/builtin_action_types/jira';
export { getResilientActionType } from '../application/components/builtin_action_types/resilient';