github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Use textContent and jQuery to set label and title (#16178) (#16199)

Browse source 
* Use textContent to set tagcloud label

* Use jquery to set disabled vis title
This commit is contained in:
Tim Roes 2018-01-22 17:23:20 +01:00 • committed by GitHub
parent 311bf2a7d8
commit 46ee1c3414
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_factory.js
View file

@ -1,3 +1,4 @@
import $ from 'jquery';
import { getVisualizeLoader } from 'ui/visualize/loader';
import { UtilsBrushEventProvider as utilsBrushEventProvider } from 'ui/utils/brush_event';
@ -33,7 +34,9 @@ export class VisualizeEmbeddableFactory extends EmbeddableFactory {
const isLabsEnabled = this._config.get('visualize:enableLabs');
if (!isLabsEnabled && savedObject.vis.type.stage === 'lab') {
domNode.innerHTML = labDisabledTemplate.replace('{{title}}', savedObject.title);
const template = $(labDisabledTemplate);
template.find('.disabledLabVisualization__title').text(savedObject.title);
$(domNode).html(template);
return new Embeddable({
title: savedObject.title

2
src/core_plugins/kibana/public/visualize/embeddable/visualize_lab_disabled.html
View file

@ -1,5 +1,5 @@
<div class="disabledLabVisualization">
<div class="kuiVerticalRhythm disabledLabVisualization__icon kuiIcon fa-flask" aria-hidden="true"></div>
<div class="kuiVerticalRhythm"><em>{{title}}</em> is a lab visualization.</div>
<div class="kuiVerticalRhythm"><em class="disabledLabVisualization__title"></em> is a lab visualization.</div>
<div class="kuiVerticalRhythm">Please turn on lab-mode in the advanced settings to see lab visualizations.</div>
</div>

2
src/core_plugins/tagcloud/public/tag_cloud_controller.js
View file

@ -28,7 +28,7 @@ module.controller('KbnTagCloudController', function ($scope, $element) {
}
const bucketName = containerNode.querySelector('.tagcloud-custom-label');
bucketName.innerHTML = `${$scope.vis.aggs[0].makeLabel()} - ${$scope.vis.aggs[1].makeLabel()}`;
bucketName.textContent = `${$scope.vis.aggs[0].makeLabel()} - ${$scope.vis.aggs[1].makeLabel()}`;
truncatedMessage.style.display = truncated ? 'block' : 'none';
const status = tagCloud.getStatus();