Added sass lint to Canvas (#43410) (#43497)

Added sass lint to Canvas
This commit is contained in:
Andrea Del Rio 2019-08-16 16:44:31 -07:00 committed by GitHub
parent 732df551cf
commit 471bae84b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
27 changed files with 60 additions and 57 deletions

View file

@ -6,6 +6,7 @@ files:
- 'src/legacy/ui/public/vislib/**/*.s+(a|c)ss'
- 'x-pack/legacy/plugins/rollup/**/*.s+(a|c)ss'
- 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
- 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
rules:
quotes:
- 2

View file

@ -9,8 +9,6 @@
padding: $euiSizeXS $euiSize;
border: $euiBorderThin;
border-radius: $euiBorderRadius;
-webkit-appearance: none;
-moz-appearance: none;
appearance: none;
font-size: inherit;

View file

@ -4,12 +4,12 @@
align-items: center;
.canvasRenderError__icon {
opacity: 0.4;
stroke: white;
stroke-width: 0.2px;
opacity: .4;
stroke: $euiColorEmptyShade;
stroke-width: .2px;
&:hover {
opacity: 0.6;
opacity: .6;
cursor: pointer;
}
}

View file

@ -13,10 +13,6 @@
// disables selection and dragging
.revealImage__image {
-khtml-user-select: none;
-o-user-select: none;
-moz-user-select: none;
-webkit-user-select: none;
user-select: none;
}
}

View file

@ -30,7 +30,7 @@ $canvasLayoutFontSize: $euiFontSizeS;
.canvasLayout__stageHeader {
flex-grow: 0;
flex-basis: auto;
padding: ($euiSizeXS +1px) $euiSize $euiSizeXS $euiSize;
padding: ($euiSizeXS + 1px) $euiSize $euiSizeXS;
font-size: $canvasLayoutFontSize;
border-bottom: $euiBorderThin;
background: $euiColorLightestShade;

View file

@ -32,7 +32,8 @@
}
.canvasArg__form, .canvasArg__accordion {
.canvasArg__form,
.canvasArg__accordion {
&:hover {
.canvasArg__remove {
opacity: 1;
@ -78,8 +79,9 @@
background: transparent;
}
&:before, &:after {
content: "";
&:before,
&:after {
content: '';
height: 1px;
position: absolute;
left: 0;

View file

@ -11,13 +11,12 @@
}
.canvasAssetManager__meterWrapper {
flex-grow: 0;
min-width: 40%;
align-items: center;
@include euiBreakpoint('xs', 's') {
flex-grow: 1;
}
flex-grow: 0;
min-width: 40%;
align-items: center;
}
.canvasAssetManager__meterLabel {

View file

@ -11,7 +11,7 @@
text-align: center;
&:hover {
outline: solid 3px rgba(0, 121, 165, 0.1);
outline: solid $euiSizeXS transparentize($euiColorPrimary, .9);
}
}

View file

@ -13,10 +13,11 @@
border-right: $euiBorderThin;
}
.autocompleteItems, .autocompleteReference {
.autocompleteItems,
.autocompleteReference {
@include euiScrollBar;
height: 258px;
overflow: auto;
@include euiScrollBar;
}
.autocompleteReference {

View file

@ -1,4 +1,5 @@
.canvasBorderResizeHandle {
@include euiSlightShadow;
transform-origin: center center; /* the default, only for clarity */
transform-style: preserve-3d;
display: block;
@ -7,7 +8,6 @@
width: 8px;
margin-left: -4px;
margin-top: -4px;
background-color: #fff;
border: 1px solid #666;
box-shadow: 0 2px 2px -1px rgba(153, 153, 153, 0.3), 0 1px 5px -2px rgba(153, 153, 153, 0.3);
background-color: $euiColorEmptyShade;
border: 1px solid $euiColorDarkShade;
}

View file

@ -1,6 +1,6 @@
.canvasColorPalette {
.canvasColorPalette__dot {
display: inline-block;
margin: 0px $euiSizeXS $euiSizeXS 0px;
margin: 0 $euiSizeXS $euiSizeXS 0;
}
}

View file

@ -12,7 +12,7 @@
overflow: auto;
// removes white square in the scrollbar corner
&::-webkit-scrollbar-corner {
&::-webkit-scrollbar-corner { // sass-lint:disable-line no-vendor-prefixes
background: transparent;
}
}

View file

@ -17,7 +17,7 @@
opacity: 0;
transition: opacity $euiAnimSpeedFast $euiAnimSlightResistance;
transition-delay: $euiAnimSpeedNormal;
background: transparentize($euiColorGhost, 0.5);
background: transparentize($euiColorGhost, .5);
border-radius: $euiBorderRadius;
}
}

View file

@ -1,8 +1,9 @@
body.canvas-isFullscreen {
body.canvas-isFullscreen { // sass-lint:disable-line no-qualifying-elements
// hide global loading indicator
.kbnLoadingIndicator {
display: none;
}
// remove space for global nav elements
.header-global-wrapper + .app-wrapper {
left: 0;
@ -11,7 +12,7 @@ body.canvas-isFullscreen {
// set the background color
.canvasLayout {
background: #000; // This hex is OK, we always want it black
background: $euiColorInk;
}
// hide all the interface parts

View file

@ -15,7 +15,7 @@
}
@for $i from 1 through 20 {
.canvasPageManager--trayPop > div:nth-child(#{$i}n) {
animation-delay: #{$i * 0.05}s;
animation-delay: #{$i * .05}s;
}
}
@ -50,7 +50,7 @@
&:focus,
&-isActive {
background-color: transparentize(darken($euiColorLightestShade, 30%), 0.5);
background-color: transparentize(darken($euiColorLightestShade, 30%), .5);
outline: none;
text-decoration: none;
}
@ -66,7 +66,7 @@
text-decoration: none;
.canvasPageManager__pagePreview {
@include euiBottomShadowMedium($opacity: 0.3);
@include euiBottomShadowMedium($opacity: .3);
}
.canvasPageManager__controls {
@ -85,7 +85,7 @@
}
.canvasPageManager__pageNumber {
color: $euiColorDarkShade !important;
color: $euiColorDarkShade;
}
.canvasPageManager__pagePreview {
@ -107,7 +107,7 @@
opacity: 0;
transition: opacity $euiAnimSpeedFast $euiAnimSlightResistance;
transition-delay: $euiAnimSpeedNormal;
background: transparentize($euiColorGhost, 0.5);
background: transparentize($euiColorGhost, .5);
border-radius: $euiBorderRadius;
}
}
@ -117,10 +117,12 @@
opacity: 0;
transform: translateX(100%);
}
1% {
opacity: 0;
transform: translateX(100%);
}
100% {
opacity: 1;
transform: translateY(0);
@ -132,10 +134,12 @@
opacity: 0;
transform: translateY(100%);
}
1% {
opacity: 0;
transform: translateY(100%);
}
100% {
opacity: 1;
transform: translateY(0);

View file

@ -12,7 +12,7 @@
}
.canvasPalettePicker__swatchesPanel {
padding: $euiSizeS 0 !important;
padding: $euiSizeS 0 !important; // sass-lint:disable-line no-important
}
.canvasPalettePicker__swatch {
@ -27,6 +27,7 @@
.canvasPaletteSwatch__background {
transform: scaleY(2);
}
.canvasPalettePicker__label {
color: $euiTextColor;
}

View file

@ -1,8 +1,8 @@
.canvasRemove {
$clearSize: $euiSize;
@include size($clearSize); // sass-lint:disable-line mixins-before-declarations
position: absolute;
pointer-events: all;
@include size($clearSize);
background-color: $euiColorLightShade;
border-radius: $clearSize;
line-height: $clearSize;

View file

@ -33,9 +33,11 @@
0% {
opacity: 0;
}
1% {
opacity: 0;
}
100% {
opacity: 1;
}

View file

@ -1,3 +1,3 @@
.canvasLayout__sidebarHeader {
padding: ($euiSizeXS * 0.5) 0;
padding: ($euiSizeXS * .5) 0;
}

View file

@ -16,7 +16,7 @@
button {
padding: $euiSizeXS $euiSizeM;
box-shadow: 0 -2px 1px rgba($euiColorFullShade, .10)
box-shadow: 0 -2px 1px transparentize($euiColorFullShade, .9);
}
}

View file

@ -1,6 +1,6 @@
.canvasTray {
flex-direction: column;
@include euiBottomShadowFlat;
flex-direction: column;
}
.canvasTray__panel {

View file

@ -11,8 +11,8 @@
position: absolute;
user-select: none;
pointer-events: none;
background-image: linear-gradient(to right, grey 1px, transparent 1px),
linear-gradient(to bottom, grey 1px, transparent 1px);
background-image: linear-gradient(to right, $euiColorMediumShade 1px, transparent 1px),
linear-gradient(to bottom, $euiColorMediumShade 1px, transparent 1px);
background-size: 50px 50px;
top: 0;
}

View file

@ -12,11 +12,10 @@
}
.canvasWorkpad__dropzoneTable--tags {
.euiTableCellContent {
flex-wrap: wrap;
}
.euiHealth {
width: 100%;
}

View file

@ -1,12 +1,12 @@
.canvasWorkpad__upload--compressed {
&.euiFilePicker--compressed.euiFilePicker {
.euiFilePicker__prompt {
height: $euiSizeXXL;
padding: $euiSizeM;
padding-left: $euiSizeXXL;
}
.euiFilePicker__icon {
top: $euiSizeM;
}

View file

@ -1,8 +1,8 @@
.canvasPage {
@include euiBottomShadowFlat($opacity: .4);
z-index: initial;
@include euiBottomShadowFlat($opacity: 0.4);
position: absolute;
top: 0;
transform-style: preserve-3d !important;
transform-style: preserve-3d !important; // sass-lint:disable-line no-important
background-color: $euiColorEmptyShade;
}

View file

@ -3,7 +3,7 @@
when the UI framework implements everything we need
*/
#canvas-app {
#canvas-app { // sass-lint:disable-line no-ids
// Give buttons some room to the right
.euiAccordion__childWrapper {
overflow-x: hidden;

View file

@ -14,17 +14,16 @@ $canvasElementCardWidth: 210px;
top: 50%;
left: 50%;
transform: translateY(-50%);
transform: translateX(-50%);
text-align: center;
}
.canvasCheckered {
background-color: $euiColorGhost;
background-image: linear-gradient(45deg, #ddd 25%, transparent 25%),
linear-gradient(-45deg, #ddd 25%, transparent 25%),
linear-gradient(45deg, transparent 75%, #ddd 75%),
linear-gradient(-45deg, transparent 75%, #ddd 75%);
background-size: 8px 8px;
background-image: linear-gradient(45deg, $euiColorLightShade 25%, transparent 25%),
linear-gradient(-45deg, $euiColorLightShade 25%, transparent 25%),
linear-gradient(45deg, transparent 75%, $euiColorLightShade 75%),
linear-gradient(-45deg, transparent 75%, $euiColorLightShade 75%);
background-size: $euiSizeS $euiSizeS;
position: relative;
}
@ -40,22 +39,22 @@ $canvasElementCardWidth: 210px;
border-top: $euiBorderThin;
}
#canvas-app {
#canvas-app { // sass-lint:disable-line no-ids
overflow-y: hidden;
.window-error {
position: absolute;
bottom: 10px;
right: 10px;
background-color: red;
color: white;
background-color: $euiColorDanger;
color: $euiColorGhost;
display: block;
z-index: 2000;
padding: 10px;
max-width: 500px;
a {
color: white;
color: $euiColorGhost;
font-weight: bold;
}
}