github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix and turn back on legacy embeddable tests (#52945)

Browse source
This commit is contained in:
Stacey Gammon 2019-12-12 22:32:21 -05:00 • committed by GitHub
parent ee2bb82a12
commit 4801647da5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
test/plugin_functional/config.js
View file

@ -33,18 +33,7 @@ export default async function ({ readConfigFile }) {
require.resolve('./test_suites/app_plugins'), require.resolve('./test_suites/app_plugins'),
require.resolve('./test_suites/custom_visualizations'), require.resolve('./test_suites/custom_visualizations'),
require.resolve('./test_suites/panel_actions'), require.resolve('./test_suites/panel_actions'),
require.resolve('./test_suites/embeddable_explorer'),
/**
* @todo Work on re-enabling this test suite after this is merged. These tests pass
* locally but on CI they fail. The error on CI says "TypeError: Cannot read
* property 'overlays' of null". Possibly those are `overlays` from
* `npStart.core.overlays`, possibly `npStart.core` is `null` on CI, but
* available when this test suite is executed locally.
*
* See issue: https://github.com/elastic/kibana/issues/43087
*/
// require.resolve('./test_suites/embeddable_explorer'),
require.resolve('./test_suites/core_plugins'), require.resolve('./test_suites/core_plugins'),
], ],
services: { services: {

2
test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/legacy.ts
View file

@ -18,6 +18,8 @@
*/ */
/* eslint-disable @kbn/eslint/no-restricted-paths */ /* eslint-disable @kbn/eslint/no-restricted-paths */
import 'ui/autoload/all'; import 'ui/autoload/all';
import 'uiExports/interpreter';
import 'uiExports/embeddableFactories'; import 'uiExports/embeddableFactories';
import 'uiExports/embeddableActions'; import 'uiExports/embeddableActions';