github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.12] [RAM] Fix rule edit flyout alerts search bar autocomplete scroll (#172899) (#173789)

Browse source 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[RAM] Fix rule edit flyout alerts search bar autocomplete scroll
(#172899)](https://github.com/elastic/kibana/pull/172899)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jiawei
Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-20T20:21:51Z","message":"[RAM]
Fix rule edit flyout alerts search bar autocomplete scroll
(#172899)\n\n## Summary\r\nResolves:
https://github.com/elastic/kibana/issues/172594\r\n\r\nFixes the rule
edit alerts search bar autocomplete causing background to\r\nalso scroll
infinitely\r\n\r\n\r\n\r\nf55db528-b933-400a-80b5-8a3063f0f29c\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Xavier Mouligneau
<xavier.mouligneau@elastic.co>","sha":"4465c1e090ab1179f12000d52b1dc0eefd14217f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.11.0","v8.12.0","v8.13.0"],"number":172899,"url":"https://github.com/elastic/kibana/pull/172899","mergeCommit":{"message":"[RAM]
Fix rule edit flyout alerts search bar autocomplete scroll
(#172899)\n\n## Summary\r\nResolves:
https://github.com/elastic/kibana/issues/172594\r\n\r\nFixes the rule
edit alerts search bar autocomplete causing background to\r\nalso scroll
infinitely\r\n\r\n\r\n\r\nf55db528-b933-400a-80b5-8a3063f0f29c\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Xavier Mouligneau
<xavier.mouligneau@elastic.co>","sha":"4465c1e090ab1179f12000d52b1dc0eefd14217f"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.12"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172899","number":172899,"mergeCommit":{"message":"[RAM]
Fix rule edit flyout alerts search bar autocomplete scroll
(#172899)\n\n## Summary\r\nResolves:
https://github.com/elastic/kibana/issues/172594\r\n\r\nFixes the rule
edit alerts search bar autocomplete causing background to\r\nalso scroll
infinitely\r\n\r\n\r\n\r\nf55db528-b933-400a-80b5-8a3063f0f29c\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Xavier Mouligneau
<xavier.mouligneau@elastic.co>","sha":"4465c1e090ab1179f12000d52b1dc0eefd14217f"}}]}]
BACKPORT-->

Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2023-12-20 16:34:03 -05:00 • committed by GitHub
parent 898eaf4da6
commit 487baa7cd4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_edit.tsx
View file

@ -213,7 +213,7 @@ export const RuleEdit = ({
aria-labelledby="flyoutRuleEditTitle"
size="m"
maxWidth={620}
ownFocus={false}
ownFocus
>
<EuiFlyoutHeader hasBorder>
<EuiTitle size="s" data-test-subj="editRuleFlyoutTitle">

9
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts
View file

@ -82,18 +82,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
}
describe('create alert', function () {
before(async () => {
beforeEach(async () => {
await pageObjects.common.navigateToApp('triggersActions');
await testSubjects.click('rulesTab');
});
afterEach(async () => {
// Reset the Rules tab without reloading the entire page
// This is safer than trying to close the alert flyout, which may or may not be open at the end of a test
await testSubjects.click('logsTab');
await testSubjects.click('rulesTab');
});
it('should delete the right action when the same action has been added twice', async () => {
// create a new rule
const ruleName = generateUniqueKey();