github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[functional tests] add some missing awaits (#65566)

Browse source
This commit is contained in:
Spencer 2020-05-06 16:45:15 -07:00 • committed by GitHub
parent bb9eaf78a6
commit 4a440427a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 21 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/functional/apps/timelion/index.js
View file

@ -28,7 +28,7 @@ export default function({ getService, loadTestFile }) {
before(async function() {
log.debug('Starting timelion before method');
browser.setWindowSize(1280, 800);
await browser.setWindowSize(1280, 800);
await esArchiver.loadIfNeeded('logstash_functional');
await kibanaServer.uiSettings.replace({ defaultIndex: 'logstash-*' });
});

4
test/functional/page_objects/settings_page.ts
View file

@ -33,7 +33,7 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
class SettingsPage {
async clickNavigation() {
find.clickDisplayedByCssSelector('.app-link:nth-child(5) a');
await find.clickDisplayedByCssSelector('.app-link:nth-child(5) a');
}
async clickLinkText(text: string) {
@ -110,7 +110,7 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
}
async toggleAdvancedSettingCheckbox(propertyName: string) {
testSubjects.click(`advancedSetting-editField-${propertyName}`);
await testSubjects.click(`advancedSetting-editField-${propertyName}`);
await PageObjects.header.waitUntilLoadingHasFinished();
await testSubjects.click(`advancedSetting-saveButton`);
await PageObjects.header.waitUntilLoadingHasFinished();

2
test/functional/services/find.ts
View file

@ -476,7 +476,7 @@ export async function FindProvider({ getService }: FtrProviderContext) {
value: string
): Promise<void> {
log.debug(`Find.waitForAttributeToChange('${selector}', '${attribute}', '${value}')`);
retry.waitFor(`${attribute} to equal "${value}"`, async () => {
await retry.waitFor(`${attribute} to equal "${value}"`, async () => {
const el = await this.byCssSelector(selector);
return value === (await el.getAttribute(attribute));
});

4
test/plugin_functional/test_suites/core_plugins/rendering.ts
View file

@ -40,8 +40,8 @@ export default function({ getService, getPageObjects }: PluginFunctionalProvider
const find = getService('find');
const testSubjects = getService('testSubjects');
const navigateTo = (path: string) =>
browser.navigateTo(`${PageObjects.common.getHostPort()}${path}`);
const navigateTo = async (path: string) =>
await browser.navigateTo(`${PageObjects.common.getHostPort()}${path}`);
const navigateToApp = async (title: string) => {
await appsMenu.clickLink(title);
return browser.execute(() => {

2
x-pack/test/functional/apps/index_management/home_page.ts
View file

@ -34,7 +34,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Index templates', () => {
it('renders the index templates tab', async () => {
// Navigate to the index templates tab
pageObjects.indexManagement.changeTabs('templatesTab');
await pageObjects.indexManagement.changeTabs('templatesTab');
await pageObjects.header.waitUntilLoadingHasFinished();

2
x-pack/test/functional/apps/lens/index.ts
View file

@ -15,7 +15,7 @@ export default function({ getService, loadTestFile }: FtrProviderContext) {
describe('lens app', () => {
before(async () => {
log.debug('Starting lens before method');
browser.setWindowSize(1280, 800);
await browser.setWindowSize(1280, 800);
await esArchiver.loadIfNeeded('logstash_functional');
await esArchiver.loadIfNeeded('lens/basic');
});

2
x-pack/test/functional/page_objects/index_management_page.ts
View file

@ -57,7 +57,7 @@ export function IndexManagementPageProvider({ getService }: FtrProviderContext)
});
},
async changeTabs(tab: 'indicesTab' | 'templatesTab') {
return await testSubjects.click(tab);
await testSubjects.click(tab);
},
};
}

2
x-pack/test/functional/page_objects/lens_page.ts
View file

@ -150,7 +150,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
}
await testSubjects.click('confirmSaveSavedObjectButton');
retry.waitForWithTimeout('Save modal to disappear', 1000, () =>
await retry.waitForWithTimeout('Save modal to disappear', 1000, () =>
testSubjects
.missingOrFail('confirmSaveSavedObjectButton')
.then(() => true)

4
x-pack/test/functional/page_objects/security_page.js
View file

@ -394,9 +394,9 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
});
}
}) //clicking save button
.then(function() {
.then(async () => {
log.debug('click save button');
testSubjects.click('roleFormSaveButton');
await testSubjects.click('roleFormSaveButton');
})
.then(function() {
return PageObjects.common.sleep(5000);

2
x-pack/test/functional/services/logs_ui/log_entry_categories.ts
View file

@ -13,7 +13,7 @@ export function LogEntryCategoriesPageProvider({ getPageObjects, getService }: F
return {
async navigateTo() {
pageObjects.infraLogs.navigateToTab('log-categories');
await pageObjects.infraLogs.navigateToTab('log-categories');
},
async getSetupScreen(): Promise<WebElementWrapper> {

2
x-pack/test/functional/services/logs_ui/log_entry_rate.ts
View file

@ -13,7 +13,7 @@ export function LogEntryRatePageProvider({ getPageObjects, getService }: FtrProv
return {
async navigateTo() {
pageObjects.infraLogs.navigateToTab('log-rate');
await pageObjects.infraLogs.navigateToTab('log-rate');
},
async getSetupScreen(): Promise<WebElementWrapper> {

2
x-pack/test/functional/services/logs_ui/log_stream.ts
View file

@ -15,7 +15,7 @@ export function LogStreamPageProvider({ getPageObjects, getService }: FtrProvide
return {
async navigateTo(params?: TabsParams['stream']) {
pageObjects.infraLogs.navigateToTab('stream', params);
await pageObjects.infraLogs.navigateToTab('stream', params);
},
async getColumnHeaderLabels(): Promise<string[]> {

5
x-pack/test/functional/services/uptime/monitor.ts
View file

@ -38,8 +38,9 @@ export function UptimeMonitorProvider({ getService }: FtrProviderContext) {
async checkForPingListTimestamps(timestamps: string[]): Promise<void> {
return retry.tryForTime(10000, async () => {
await Promise.all(
timestamps.map(timestamp =>
testSubjects.existOrFail(`xpack.uptime.pingList.ping-${timestamp}`)
timestamps.map(
async timestamp =>
await testSubjects.existOrFail(`xpack.uptime.pingList.ping-${timestamp}`)
)
);
});

4
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts
View file

@ -29,7 +29,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Connectors tab', () => {
it('renders the connectors tab', async () => {
// Navigate to the connectors tab
pageObjects.triggersActionsUI.changeTabs('connectorsTab');
await pageObjects.triggersActionsUI.changeTabs('connectorsTab');
await pageObjects.header.waitUntilLoadingHasFinished();
@ -45,7 +45,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Alerts tab', () => {
it('renders the alerts tab', async () => {
// Navigate to the alerts tab
pageObjects.triggersActionsUI.changeTabs('alertsTab');
await pageObjects.triggersActionsUI.changeTabs('alertsTab');
await pageObjects.header.waitUntilLoadingHasFinished();

2
x-pack/test/functional_with_es_ssl/page_objects/triggers_actions_ui_page.ts
View file

@ -120,7 +120,7 @@ export function TriggersActionsPageProvider({ getService }: FtrProviderContext)
await find.clickDisplayedByCssSelector(`[data-test-subj="alertsList"] [title="${name}"]`);
},
async changeTabs(tab: 'alertsTab' | 'connectorsTab') {
return await testSubjects.click(tab);
await testSubjects.click(tab);
},
async toggleSwitch(testSubject: string) {
const switchBtn = await testSubjects.find(testSubject);