[functional tests] Remove default screenshots (#14122)

* [functional tests] Remove default screenshots

* Remove baseline screenshots

test/functional/apps/console/_console.js

@@ -14,7 +14,6 @@ GET _search
 export default function ({ getService, getPageObjects }) {
   const retry = getService('retry');
   const log = getService('log');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'console']);
 
   describe('console app', function describeIndexTests() {
@@ -24,11 +23,9 @@ export default function ({ getService, getPageObjects }) {
     });
 
     it('should show the default request', function () {
-      screenshots.take('Console-help-expanded');
       // collapse the help pane because we only get the VISIBLE TEXT, not the part that is scrolled
       return PageObjects.console.collapseHelp()
       .then(function () {
-        screenshots.take('Console-help-collapsed');
         return retry.try(function () {
           return PageObjects.console.getRequest()
           .then(function (actualRequest) {
@@ -43,7 +40,6 @@ export default function ({ getService, getPageObjects }) {
 
       return PageObjects.console.clickPlay()
       .then(function () {
-        screenshots.take('Console-default-request');
         return retry.try(function () {
           return PageObjects.console.getResponse()
           .then(function (actualResponse) {

test/functional/apps/dashboard/_dashboard.js

@@ -13,7 +13,6 @@ export default function ({ getService, getPageObjects }) {
   const retry = getService('retry');
   const log = getService('log');
   const remote = getService('remote');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'visualize']);
 
   describe('dashboard tab', function describeIndexTests() {
@@ -30,8 +29,6 @@ export default function ({ getService, getPageObjects }) {
     });
 
     it('should be able to add visualizations to dashboard', async function addVisualizations() {
-      await screenshots.take('Dashboard-no-visualizations');
-
       // This flip between apps fixes the url so state is preserved when switching apps in test mode.
       // Without this flip the url in test mode looks something like
       // "http://localhost:5620/app/kibana?_t=1486069030837#/dashboard?_g=...."
@@ -43,7 +40,6 @@ export default function ({ getService, getPageObjects }) {
       await PageObjects.dashboard.addVisualizations(PageObjects.dashboard.getTestVisualizationNames());
 
       log.debug('done adding visualizations');
-      await screenshots.take('Dashboard-add-visualizations');
     });
 
     it('set the timepicker time to that which contains our test data', async function setTimepicker() {
@@ -60,7 +56,6 @@ export default function ({ getService, getPageObjects }) {
         log.debug('now re-load previously saved dashboard');
         return PageObjects.dashboard.loadSavedDashboard(dashboardName);
       });
-      await screenshots.take('Dashboard-load-saved');
     });
 
     it('should have all the expected visualizations', function checkVisualizations() {
@@ -72,7 +67,6 @@ export default function ({ getService, getPageObjects }) {
         });
       })
       .then(function () {
-        screenshots.take('Dashboard-has-visualizations');
       });
     });
 
@@ -93,7 +87,6 @@ export default function ({ getService, getPageObjects }) {
         return PageObjects.dashboard.getPanelSizeData()
           .then(function (panelTitles) {
             log.info('visualization titles = ' + panelTitles);
-            screenshots.take('Dashboard-visualization-sizes');
             expect(panelTitles).to.eql(visObjects);
           });
       });
@@ -306,7 +299,6 @@ export default function ({ getService, getPageObjects }) {
         return retry.tryForTime(10000, async function () {
           const panelTitles = await PageObjects.dashboard.getPanelSizeData();
           log.info('visualization titles = ' + panelTitles.map(item => item.title));
-          screenshots.take('Dashboard-visualization-sizes');
           expect(panelTitles.length).to.eql(visualizations.length + 1);
         });
       });

test/functional/apps/discover/_collapse_expand.js

@@ -4,7 +4,6 @@ export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const esArchiver = getService('esArchiver');
   const kibanaServer = getService('kibanaServer');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'discover', 'header']);
 
   describe('discover tab', function describeIndexTests() {
@@ -37,7 +36,6 @@ export default function ({ getService, getPageObjects }) {
 
     describe('field data', function () {
       it('should initially be expanded', function () {
-        screenshots.take('Discover-sidebar-expanded');
         return PageObjects.discover.getSidebarWidth()
           .then(function (width) {
             log.debug('expanded sidebar width = ' + width);
@@ -48,7 +46,6 @@ export default function ({ getService, getPageObjects }) {
       it('should collapse when clicked', function () {
         return PageObjects.discover.toggleSidebarCollapse()
           .then(function () {
-            screenshots.take('Discover-sidebar-collapsed');
             log.debug('PageObjects.discover.getSidebarWidth()');
             return PageObjects.discover.getSidebarWidth();
           })

test/functional/apps/discover/_discover.js

@@ -6,7 +6,6 @@ export default function ({ getService, getPageObjects }) {
   const esArchiver = getService('esArchiver');
   const remote = getService('remote');
   const kibanaServer = getService('kibanaServer');
-  const screenshots = getService('screenshots');
   const queryBar = getService('queryBar');
   const filterBar = getService('filterBar');
   const PageObjects = getPageObjects(['common', 'discover', 'header']);
@@ -52,7 +51,6 @@ export default function ({ getService, getPageObjects }) {
 
         const expectedToastMessage = `Discover: Saved Data Source "${queryName1}"`;
         expect(toastMessage).to.be(expectedToastMessage);
-        await screenshots.take('Discover-save-query-toast');
 
         await PageObjects.header.waitForToastMessageGone();
         const actualQueryNameString = await PageObjects.discover.getCurrentQueryName();
@@ -66,7 +64,6 @@ export default function ({ getService, getPageObjects }) {
         await retry.try(async function () {
           expect(await PageObjects.discover.getCurrentQueryName()).to.be(queryName1);
         });
-        await screenshots.take('Discover-load-query');
       });
 
       it('should show the correct hit count', async function () {
@@ -212,7 +209,6 @@ export default function ({ getService, getPageObjects }) {
       it('should show "no results"', async () => {
         const isVisible = await PageObjects.discover.hasNoResults();
         expect(isVisible).to.be(true);
-        await screenshots.take('Discover-no-results');
       });
 
       it('should suggest a new time range is picked', async () => {

test/functional/apps/discover/_field_data.js

@@ -4,7 +4,6 @@ export default function ({ getService, getPageObjects }) {
   const retry = getService('retry');
   const esArchiver = getService('esArchiver');
   const kibanaServer = getService('kibanaServer');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'header', 'discover']);
 
   describe('discover app', function describeIndexTests() {
@@ -34,7 +33,6 @@ export default function ({ getService, getPageObjects }) {
           return retry.try(function tryingForTime() {
             return PageObjects.discover.getHitCount()
             .then(function compareData(hitCount) {
-              screenshots.take('Discover-field-data');
               expect(hitCount).to.be(expectedHitCount);
             });
           });
@@ -207,7 +205,6 @@ export default function ({ getService, getPageObjects }) {
           return retry.try(function tryingForTime() {
             return PageObjects.discover.getDocTableIndex(1)
             .then(function (rowData) {
-              screenshots.take('Discover-sort-down');
               expect(rowData).to.be(ExpectedDoc);
             });
           });
@@ -222,7 +219,6 @@ export default function ({ getService, getPageObjects }) {
           return PageObjects.header.getToastMessage();
         })
         .then(function (toastMessage) {
-          screenshots.take('Discover-syntax-error-toast');
           expect(toastMessage).to.contain(expectedError);
         })
         .then(function () {

test/functional/apps/discover/_shared_links.js

@@ -5,7 +5,6 @@ export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const esArchiver = getService('esArchiver');
   const kibanaServer = getService('kibanaServer');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'discover', 'header']);
 
   describe('shared links', function describeIndexTests() {
@@ -61,7 +60,6 @@ export default function ({ getService, getPageObjects }) {
         const expectedCaption = 'Share saved';
         return PageObjects.discover.clickShare()
         .then(function () {
-          screenshots.take('Discover-share-link');
           return PageObjects.discover.getShareCaption();
         })
         .then(function (actualCaption) {
@@ -91,7 +89,6 @@ export default function ({ getService, getPageObjects }) {
           return PageObjects.header.getToastMessage();
         })
         .then(function (toastMessage) {
-          screenshots.take('Discover-copy-to-clipboard-toast');
           expect(toastMessage).to.match(expectedToastMessage);
         })
         .then(function () {
@@ -105,7 +102,6 @@ export default function ({ getService, getPageObjects }) {
         return PageObjects.discover.clickShortenUrl()
         .then(function () {
           return retry.try(function tryingForTime() {
-            screenshots.take('Discover-shorten-url-button');
             return PageObjects.discover.getSharedUrl()
             .then(function (actualUrl) {
               expect(actualUrl).to.match(re);

test/functional/apps/management/_index_pattern_create_delete.js

@@ -5,7 +5,6 @@ export default function ({ getService, getPageObjects }) {
   const remote = getService('remote');
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['settings', 'common']);
 
   describe('creating and deleting default index', function describeIndexTests() {
@@ -31,7 +30,6 @@ export default function ({ getService, getPageObjects }) {
       it('should have index pattern in page header', async function () {
         const indexPageHeading = await PageObjects.settings.getIndexPageHeading();
         const patternName = await indexPageHeading.getVisibleText();
-        screenshots.take('Settings-indices-new-index-pattern');
         expect(patternName).to.be('logstash-*');
       });
 
@@ -77,7 +75,6 @@ export default function ({ getService, getPageObjects }) {
         const expectedAlertText = 'Are you sure you want to remove this index pattern?';
         return PageObjects.settings.removeIndexPattern()
         .then(function (alertText) {
-          screenshots.take('Settings-indices-confirm-remove-index-pattern');
           expect(alertText).to.be(expectedAlertText);
         });
       });

test/functional/apps/management/_index_pattern_popularity.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const kibanaServer = getService('kibanaServer');
   const log = getService('log');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['settings', 'common']);
 
   describe('index result popularity', function describeIndexTests() {
@@ -52,7 +51,6 @@ export default function ({ getService, getPageObjects }) {
         const popularity = await PageObjects.settings.getPopularity();
         log.debug('popularity = ' + popularity);
         expect(popularity).to.be('1');
-        screenshots.take('Settings-indices-result-popularity-updated');
       });
 
       it('should be reset on cancel', async function () {
@@ -74,7 +72,6 @@ export default function ({ getService, getPageObjects }) {
         const popularity = await PageObjects.settings.getPopularity();
         log.debug('popularity = ' + popularity);
         expect(popularity).to.be('1');
-        screenshots.take('Settings-indices-result-popularity-saved');
       });
     }); // end 'change popularity'
   }); // end index result popularity

test/functional/apps/management/_index_pattern_results_sort.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const kibanaServer = getService('kibanaServer');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['settings', 'common']);
 
   describe('index result field sort', function describeIndexTests() {
@@ -51,7 +50,6 @@ export default function ({ getService, getPageObjects }) {
             return col.selector();
           })
           .then(function (rowText) {
-            screenshots.take(`Settings-indices-column-${col.heading}-sort-ascending`);
             expect(rowText).to.be(col.first);
           });
         });
@@ -65,7 +63,6 @@ export default function ({ getService, getPageObjects }) {
             return col.selector();
           })
           .then(function (rowText) {
-            screenshots.take(`Settings-indices-column-${col.heading}-sort-descending`);
             expect(rowText).to.be(col.last);
           });
         });
@@ -109,7 +106,6 @@ export default function ({ getService, getPageObjects }) {
         for (let pageNum = 1; pageNum <= LAST_PAGE_NUMBER; pageNum += 1) {
           await PageObjects.settings.goToPage(pageNum);
           const pageFieldNames = await retry.tryMethod(PageObjects.settings, 'getFieldNames');
-          await screenshots.take(`Settings-indexed-fields-page-${pageNum}`);
 
           if (pageNum === LAST_PAGE_NUMBER) {
             expect(pageFieldNames).to.have.length(EXPECTED_LAST_PAGE_COUNT);

test/functional/apps/management/_scripted_fields.js

@@ -18,7 +18,6 @@ export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const remote = getService('remote');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'header', 'settings', 'visualize', 'discover']);
 
   describe('scripted fields', () => {
@@ -103,7 +102,6 @@ export default function ({ getService, getPageObjects }) {
         await log.debug('getDataTableData = ' + data.split('\n'));
         await log.debug('data=' + data);
         await log.debug('data.length=' + data.length);
-        await screenshots.take('Visualize-vertical-bar-chart');
         expect(data.trim().split('\n')).to.eql(expectedChartValues);
       });
     });
@@ -170,7 +168,6 @@ export default function ({ getService, getPageObjects }) {
         await log.debug('getDataTableData = ' + data.split('\n'));
         await log.debug('data=' + data);
         await log.debug('data.length=' + data.length);
-        await screenshots.take('Visualize-vertical-bar-chart');
         expect(data.trim().split('\n')).to.eql(expectedChartValues);
       });
     });

test/functional/apps/status_page/index.js

@@ -2,7 +2,6 @@ import expect from 'expect.js';
 
 export default function ({ getService, getPageObjects }) {
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const testSubjects = getService('testSubjects');
   const PageObjects = getPageObjects(['common']);
 
@@ -14,7 +13,6 @@ export default function ({ getService, getPageObjects }) {
     it('should show the kibana plugin as ready', async function () {
       await retry.tryForTime(6000, async () => {
         const text = await testSubjects.getVisibleText('statusBreakdown');
-        screenshots.take('Status');
         expect(text.indexOf('plugin:kibana')).to.be.above(-1);
       });
     });

test/functional/apps/visualize/_area_chart.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header', 'settings']);
 
   describe('visualize app', function describeIndexTests() {
@@ -86,7 +85,6 @@ export default function ({ getService, getPageObjects }) {
         return PageObjects.visualize.saveVisualization(vizName1)
         .then(function (message) {
           log.debug('Saved viz message = ' + message);
-          screenshots.take('Visualize-area-chart-save-toast');
           expect(message).to.be('Visualization Editor: Saved Visualization \"' + vizName1 + '\"');
         })
         .then(function testVisualizeWaitForToastMessageGone() {
@@ -135,7 +133,6 @@ export default function ({ getService, getPageObjects }) {
         .then(function (paths) {
           log.debug('expectedAreaChartData = ' + expectedAreaChartData);
           log.debug('actual chart data =     ' + paths);
-          screenshots.take('Visualize-area-chart');
           expect(paths).to.eql(expectedAreaChartData);
         });
       });

test/functional/apps/visualize/_chart_types.js

@@ -2,7 +2,6 @@ import expect from 'expect.js';
 
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize']);
 
   describe('visualize app', function describeIndexTests() {
@@ -40,7 +39,6 @@ export default function ({ getService, getPageObjects }) {
         .then(function testChartTypes(chartTypes) {
           log.debug('returned chart types = ' + chartTypes);
           log.debug('expected chart types = ' + expectedChartTypes);
-          screenshots.take('Visualize-chart-types');
           expect(chartTypes).to.eql(expectedChartTypes);
         });
       });

test/functional/apps/visualize/_data_table.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header']);
 
   describe('visualize app', function describeIndexTests() {
@@ -79,7 +78,6 @@ export default function ({ getService, getPageObjects }) {
           return PageObjects.visualize.getDataTableData()
           .then(function showData(data) {
             log.debug(data.split('\n'));
-            screenshots.take('Visualize-data-table');
             expect(data.split('\n')).to.eql(expectedChartData);
           });
         });

test/functional/apps/visualize/_gauge_chart.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header']);
 
   describe('visualize app', function describeIndexTests() {
@@ -35,7 +34,6 @@ export default function ({ getService, getPageObjects }) {
         return retry.try(function tryingForTime() {
           return PageObjects.visualize.getGaugeValue()
           .then(function (metricValue) {
-            screenshots.take('Visualize-gauge-chart');
             expect(expectedCount).to.eql(metricValue[0].split('\n'));
           });
         });

test/functional/apps/visualize/_heatmap_chart.js

@@ -2,7 +2,6 @@ import expect from 'expect.js';
 
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
-  const screenshots = getService('screenshots');
   const retry = getService('retry');
   const PageObjects = getPageObjects(['common', 'visualize', 'header']);
 
@@ -81,7 +80,6 @@ export default function ({ getService, getPageObjects }) {
           const data = await PageObjects.visualize.getHeatmapData();
           log.debug('data=' + data);
           log.debug('data.length=' + data.length);
-          screenshots.take('Visualize-heatmap-chart');
           expect(data).to.eql(expectedChartValues);
         });
       });

test/functional/apps/visualize/_line_chart.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header']);
 
   describe('visualize app', function describeIndexTests() {
@@ -63,7 +62,6 @@ export default function ({ getService, getPageObjects }) {
           return PageObjects.visualize.getLineChartData('fill="#00a69b"')
           .then(function showData(data) {
             log.debug('data=' + data);
-            screenshots.take('Visualize-line-chart');
             const tolerance = 10; // the y-axis scale is 10000 so 10 is 0.1%
             for (let x = 0; x < data.length; x++) {
               log.debug('x=' + x + ' expectedChartData[x].split(\' \')[1] = ' +
@@ -93,7 +91,6 @@ export default function ({ getService, getPageObjects }) {
             return PageObjects.visualize.getLineChartData('fill="#00a69b"')
             .then(function showData(data) {
               log.debug('data=' + data);
-              screenshots.take('Visualize-line-chart');
               const tolerance = 10; // the y-axis scale is 10000 so 10 is 0.1%
               for (let x = 0; x < data.length; x++) {
                 log.debug('x=' + x + ' expectedChartData[x].split(\' \')[1] = ' +

test/functional/apps/visualize/_pie_chart.js

@@ -2,7 +2,6 @@ import expect from 'expect.js';
 
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header', 'settings']);
 
   describe('visualize app', function describeIndexTests() {
@@ -85,7 +84,6 @@ export default function ({ getService, getPageObjects }) {
         return PageObjects.visualize.getPieChartData()
         .then(function (pieData) {
           log.debug('pieData.length = ' + pieData.length);
-          screenshots.take('Visualize-pie-chart');
           expect(pieData.length).to.be(expectedPieChartSliceCount);
         });
       });

test/functional/apps/visualize/_point_series_options.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header', 'pointSeries']);
   const pointSeriesVis = PageObjects.pointSeries;
 
@@ -97,7 +96,6 @@ export default function ({ getService, getPageObjects }) {
           const data = await PageObjects.visualize.getLineChartData('fill="#00a69b"');
           log.debug('count data=' + data);
           log.debug('data.length=' + data.length);
-          screenshots.take('Visualize-secondary-value-axis');
           expect(data).to.eql(expectedChartValues[0]);
 
           const avgMemoryData = await PageObjects.visualize.getLineChartData('fill="#57c17b"', 'ValueAxis-2');

test/functional/apps/visualize/_tile_map.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header', 'settings']);
 
   describe('tile map visualize app', function describeIndexTests() {
@@ -121,7 +120,6 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.visualize.zoomAllTheWayOut();
         const enabled = await PageObjects.visualize.getMapZoomOutEnabled();
         expect(enabled).to.be(false);
-        screenshots.take('map-at-zoom-0');
       });
 
       // See https://github.com/elastic/kibana/issues/13137 if this test starts failing intermittently
@@ -144,7 +142,6 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.visualize.selectTableInSpyPaneSelect();
         const data = await PageObjects.visualize.getDataTableData();
         await compareTableData(expectedPrecision2DataTable, data.trim().split('\n'));
-        screenshots.take('map-at-zoom-3');
         await PageObjects.visualize.closeSpyPanel();
       });
 
@@ -242,8 +239,6 @@ export default function ({ getService, getPageObjects }) {
         compareTableData(expectedZoom5Data, actualReOpenedZoom5Data.trim().split('\n'));
 
         await PageObjects.visualize.closeSpyPanel();
-
-        await screenshots.take('Visualize-site-map');
       });
 
       it('should zoom in to level 10', function () {

test/functional/apps/visualize/_vertical_bar_chart.js

@@ -3,7 +3,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const screenshots = getService('screenshots');
   const PageObjects = getPageObjects(['common', 'visualize', 'header']);
 
   describe('visualize app', function describeIndexTests() {
@@ -83,7 +82,6 @@ export default function ({ getService, getPageObjects }) {
           const data = await PageObjects.visualize.getBarChartData();
           log.debug('data=' + data);
           log.debug('data.length=' + data.length);
-          screenshots.take('Visualize-vertical-bar-chart');
           expect(data).to.eql(expectedChartValues);
         });
       });