[8.x] Remove Sass `@euiPanel` mixin usage (#194646) (#194728)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove Sass `@euiPanel` mixin usage
(#194646)](https://github.com/elastic/kibana/pull/194646)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-02T15:36:34Z","message":"Remove
Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is
part of EUI's ongoing Emotion migration. We are
actively\r\ndeprecating/removing Sass mixins and variables that
are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel`
**only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch
of modifier classes, none of which were\r\nbeing used in Kibana - hence
various removals (see git commits for more\r\nspecifics).\r\n\r\n###
QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x]
Checked Visualize Library > TSVB for visual regressions\r\n\r\n###
Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","v8.16.0","backport:version"],"title":"Remove
Sass `@euiPanel` mixin
usage","number":194646,"url":"https://github.com/elastic/kibana/pull/194646","mergeCommit":{"message":"Remove
Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is
part of EUI's ongoing Emotion migration. We are
actively\r\ndeprecating/removing Sass mixins and variables that
are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel`
**only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch
of modifier classes, none of which were\r\nbeing used in Kibana - hence
various removals (see git commits for more\r\nspecifics).\r\n\r\n###
QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x]
Checked Visualize Library > TSVB for visual regressions\r\n\r\n###
Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194646","number":194646,"mergeCommit":{"message":"Remove
Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is
part of EUI's ongoing Emotion migration. We are
actively\r\ndeprecating/removing Sass mixins and variables that
are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel`
**only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch
of modifier classes, none of which were\r\nbeing used in Kibana - hence
various removals (see git commits for more\r\nspecifics).\r\n\r\n###
QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x]
Checked Visualize Library > TSVB for visual regressions\r\n\r\n###
Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2024-10-03 03:27:59 +10:00 committed by GitHub
parent 93dd1bf9e8
commit 4dd621c2ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 1 additions and 6 deletions

View file

@ -3,8 +3,6 @@
background-color: $euiColorLightestShade;
}
@include euiPanel('.tvbAnnotationsEditor');
.tvbAnnotationsEditor {
margin-bottom: $euiSize;
padding: $euiSizeS;

View file

@ -2,8 +2,6 @@
padding: $euiSize;
}
@include euiPanel('.tvbSeriesEditor');
.tvbSeriesEditor {
margin-bottom: $euiSize;
padding: $euiSizeS;

View file

@ -37,6 +37,7 @@ $bodyOffset: $euiSize * 3;
.prfDevTool__main {
height: 100%;
flex-grow: 1;
order: 2;
margin-left: $euiSize;
display: flex;
@ -49,8 +50,6 @@ $bodyOffset: $euiSize * 3;
}
}
@include euiPanel('.prfDevTool__main');
@include euiBreakpoint('xs', 's') {
.prfDevTool__container {
flex-direction: column;