github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Rename error rate to failed transactions rate (#120255) (#120374)

Browse source 
* Rename error rate to failed transactions rate

* Fix conflict

Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2021-12-03 12:44:24 -05:00 • committed by GitHub
parent 0699875371
commit 4f7f9dc30f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts → x-pack/plugins/apm/server/lib/transaction_groups/get_failed_transaction_rate.ts
View file

@ -32,7 +32,7 @@ import {
getFailedTransactionRateTimeSeries,
} from '../helpers/transaction_error_rate';
export async function getErrorRate({
export async function getFailedTransactionRate({
environment,
kuery,
serviceName,
@ -122,7 +122,7 @@ export async function getErrorRate({
return { timeseries, average };
}
export async function getErrorRatePeriods({
export async function getFailedTransactionRatePeriods({
environment,
kuery,
serviceName,
@ -157,11 +157,15 @@ export async function getErrorRatePeriods({
searchAggregatedTransactions,
};
const currentPeriodPromise = getErrorRate({ ...commonProps, start, end });
const currentPeriodPromise = getFailedTransactionRate({
...commonProps,
start,
end,
});
const previousPeriodPromise =
comparisonStart && comparisonEnd
? getErrorRate({
? getFailedTransactionRate({
...commonProps,
start: comparisonStart,
end: comparisonEnd,

4
x-pack/plugins/apm/server/routes/service_map/get_service_map_service_node_info.ts
View file

@ -29,7 +29,7 @@ import {
getDurationFieldForTransactions,
getProcessorEventForTransactions,
} from '../../lib/helpers/transactions';
import { getErrorRate } from '../../lib/transaction_groups/get_error_rate';
import { getFailedTransactionRate } from '../../lib/transaction_groups/get_failed_transaction_rate';
import { withApmSpan } from '../../utils/with_apm_span';
import {
percentCgroupMemoryUsedScript,
@ -123,7 +123,7 @@ async function getFailedTransactionsRateStats({
numBuckets,
}: TaskParameters): Promise<NodeStats['failedTransactionsRate']> {
return withApmSpan('get_error_rate_for_service_map_node', async () => {
const { average, timeseries } = await getErrorRate({
const { average, timeseries } = await getFailedTransactionRate({
environment,
setup,
serviceName,

4
x-pack/plugins/apm/server/routes/transactions/route.ts
View file

@ -19,7 +19,7 @@ import { getServiceTransactionGroupDetailedStatisticsPeriods } from '../services
import { getTransactionBreakdown } from './breakdown';
import { getTransactionTraceSamples } from './trace_samples';
import { getLatencyPeriods } from './get_latency_charts';
import { getErrorRatePeriods } from '../../lib/transaction_groups/get_error_rate';
import { getFailedTransactionRatePeriods } from '../../lib/transaction_groups/get_failed_transaction_rate';
import { createApmServerRoute } from '../apm_routes/create_apm_server_route';
import { createApmServerRouteRepository } from '../apm_routes/create_apm_server_route_repository';
import {
@ -349,7 +349,7 @@ const transactionChartsErrorRateRoute = createApmServerRoute({
end,
});
return getErrorRatePeriods({
return getFailedTransactionRatePeriods({
environment,
kuery,
serviceName,