github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.10] fix(slo): number fields safari (#164496) (#164510)

Browse source 
# Backport

This will backport the following commits from `main` to `8.10`:
- [fix(slo): number fields safari
(#164496)](https://github.com/elastic/kibana/pull/164496)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-08-22T20:04:51Z","message":"fix(slo):
number fields safari
(#164496)","sha":"1caac7d28ac82b3f080f838db686e2fde5c9b42e","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:
Actionable
Observability","v8.10.0","v8.11.0"],"number":164496,"url":"https://github.com/elastic/kibana/pull/164496","mergeCommit":{"message":"fix(slo):
number fields safari
(#164496)","sha":"1caac7d28ac82b3f080f838db686e2fde5c9b42e"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164496","number":164496,"mergeCommit":{"message":"fix(slo):
number fields safari
(#164496)","sha":"1caac7d28ac82b3f080f838db686e2fde5c9b42e"}}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
This commit is contained in:
Kibana Machine 2023-08-22 17:20:08 -04:00 • committed by GitHub
parent eae43a3434
commit 5003278a6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/observability/public/pages/slo_edit/components/slo_edit_form_objective_section.tsx
View file

@ -241,17 +241,17 @@ export function SloEditFormObjectiveSection() {
min: 0.001,
max: 99.999,
}}
render={({ field: { ref, ...field }, fieldState }) => (
render={({ field: { ref, onChange, ...field }, fieldState }) => (
<EuiFieldNumber
{...field}
required
isInvalid={fieldState.invalid}
data-test-subj="sloFormObjectiveTargetInput"
value={String(field.value)}
value={field.value}
min={0.001}
max={99.999}
step={0.001}
onChange={(event) => field.onChange(Number(event.target.value))}
onChange={(event) => onChange(event.target.value)}
/>
)}
/>

12
x-pack/plugins/observability/public/pages/slo_edit/components/slo_edit_form_objective_section_timeslices.tsx
View file

@ -43,17 +43,17 @@ export function SloEditFormObjectiveSectionTimeslices() {
min: 0.001,
max: 99.999,
}}
render={({ field: { ref, ...field }, fieldState }) => (
render={({ field: { ref, onChange, ...field }, fieldState }) => (
<EuiFieldNumber
{...field}
required
isInvalid={fieldState.invalid}
value={String(field.value)}
value={field.value}
data-test-subj="sloFormObjectiveTimesliceTargetInput"
min={0.001}
max={99.999}
step={0.001}
onChange={(event) => field.onChange(Number(event.target.value))}
onChange={(event) => onChange(event.target.value)}
/>
)}
/>
@ -82,17 +82,17 @@ export function SloEditFormObjectiveSectionTimeslices() {
defaultValue="1"
control={control}
rules={{ required: true, min: 1, max: 120 }}
render={({ field: { ref, ...field }, fieldState }) => (
render={({ field: { ref, onChange, ...field }, fieldState }) => (
<EuiFieldNumber
{...field}
isInvalid={fieldState.invalid}
required
data-test-subj="sloFormObjectiveTimesliceWindowInput"
value={String(field.value)}
value={field.value}
min={1}
max={120}
step={1}
onChange={(event) => field.onChange(String(Number(event.target.value)))}
onChange={(event) => onChange(String(parseInt(event.target.value, 10)))}
/>
)}
/>