chore(NA): correctly setup dep order on js_library to fix windows build (#100420)

2025-04-23 17:28:26 -04:00 · 2021-05-21 00:03:54 +01:00 · 2021-05-21 00:03:54 +01:00 · 50616aa0f9
commit 50616aa0f9
parent f728b222e6
32 changed files with 37 additions and 34 deletions
--- a/packages/elastic-datemath/BUILD.bazel
+++ b/packages/elastic-datemath/BUILD.bazel
@ -55,7 +55,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-ace/BUILD.bazel
+++ b/packages/kbn-ace/BUILD.bazel
@ -64,7 +64,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
@ -82,4 +82,4 @@ filegroup(
    ":npm_module",
  ],
  visibility = ["//visibility:public"],
-)
+)
--- a/packages/kbn-analytics/BUILD.bazel
+++ b/packages/kbn-analytics/BUILD.bazel
@ -103,7 +103,7 @@ pkg_npm(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":target"] + DEPS,
+  deps = DEPS + [":target"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-apm-config-loader/BUILD.bazel
+++ b/packages/kbn-apm-config-loader/BUILD.bazel
@ -66,7 +66,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-apm-utils/BUILD.bazel
+++ b/packages/kbn-apm-utils/BUILD.bazel
@ -54,7 +54,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-babel-code-parser/BUILD.bazel
+++ b/packages/kbn-babel-code-parser/BUILD.bazel
@ -53,7 +53,7 @@ babel(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":target"] + DEPS,
+  deps = DEPS + [":target"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-config-schema/BUILD.bazel
+++ b/packages/kbn-config-schema/BUILD.bazel
@ -64,7 +64,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-config/BUILD.bazel
+++ b/packages/kbn-config/BUILD.bazel
@ -76,7 +76,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-crypto/BUILD.bazel
+++ b/packages/kbn-crypto/BUILD.bazel
@ -67,7 +67,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
@ -85,4 +85,4 @@ filegroup(
    ":npm_module",
  ],
  visibility = ["//visibility:public"],
-) 
+)
--- a/packages/kbn-dev-utils/BUILD.bazel
+++ b/packages/kbn-dev-utils/BUILD.bazel
@ -107,7 +107,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-docs-utils/BUILD.bazel
+++ b/packages/kbn-docs-utils/BUILD.bazel
@ -67,7 +67,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-es/BUILD.bazel
+++ b/packages/kbn-es/BUILD.bazel
@ -69,7 +69,7 @@ babel(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":target"] + DEPS,
+  deps = DEPS + [":target"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-i18n/BUILD.bazel
+++ b/packages/kbn-i18n/BUILD.bazel
@ -111,7 +111,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc", ":tsc_browser"] + DEPS,
+  deps = DEPS + [":tsc", ":tsc_browser"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-i18n/tsconfig.browser.json
+++ b/packages/kbn-i18n/tsconfig.browser.json
@ -8,7 +8,10 @@
    "isolatedModules": true,
    "sourceMap": true,
    "sourceRoot": "../../../../../packages/kbn-i18n/src",
-    "types": ["node"],
+    "types": [
+      "jest",
+      "node"
+    ],
  },
  "include": [
    "src/**/*.ts",
--- a/packages/kbn-legacy-logging/BUILD.bazel
+++ b/packages/kbn-legacy-logging/BUILD.bazel
@ -71,7 +71,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-logging/BUILD.bazel
+++ b/packages/kbn-logging/BUILD.bazel
@ -61,7 +61,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-plugin-generator/BUILD.bazel
+++ b/packages/kbn-plugin-generator/BUILD.bazel
@ -85,7 +85,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-securitysolution-constants/BUILD.bazel
+++ b/packages/kbn-securitysolution-constants/BUILD.bazel
@ -65,7 +65,7 @@ js_library(
  package_name = PKG_REQUIRE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
  visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )

 pkg_npm(
--- a/packages/kbn-securitysolution-es-utils/BUILD.bazel
+++ b/packages/kbn-securitysolution-es-utils/BUILD.bazel
@ -67,7 +67,7 @@ js_library(
  package_name = PKG_REQUIRE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
  visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )

 pkg_npm(
--- a/packages/kbn-securitysolution-io-ts-alerting-types/BUILD.bazel
+++ b/packages/kbn-securitysolution-io-ts-alerting-types/BUILD.bazel
@ -73,7 +73,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-securitysolution-io-ts-list-types/BUILD.bazel
+++ b/packages/kbn-securitysolution-io-ts-list-types/BUILD.bazel
@ -73,7 +73,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-securitysolution-io-ts-types/BUILD.bazel
+++ b/packages/kbn-securitysolution-io-ts-types/BUILD.bazel
@ -72,7 +72,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-securitysolution-io-ts-utils/BUILD.bazel
+++ b/packages/kbn-securitysolution-io-ts-utils/BUILD.bazel
@ -71,7 +71,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-securitysolution-list-api/BUILD.bazel
+++ b/packages/kbn-securitysolution-list-api/BUILD.bazel
@ -69,7 +69,7 @@ js_library(
  package_name = PKG_REQUIRE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
  visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )

 pkg_npm(
--- a/packages/kbn-securitysolution-list-hooks/BUILD.bazel
+++ b/packages/kbn-securitysolution-list-hooks/BUILD.bazel
@ -74,7 +74,7 @@ js_library(
  package_name = PKG_REQUIRE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
  visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )

 pkg_npm(
--- a/packages/kbn-securitysolution-list-utils/BUILD.bazel
+++ b/packages/kbn-securitysolution-list-utils/BUILD.bazel
@ -70,7 +70,7 @@ js_library(
  package_name = PKG_REQUIRE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
  visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )

 pkg_npm(
--- a/packages/kbn-securitysolution-utils/BUILD.bazel
+++ b/packages/kbn-securitysolution-utils/BUILD.bazel
@ -67,7 +67,7 @@ js_library(
  package_name = PKG_REQUIRE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
  visibility = ["//visibility:public"],
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
 )

 pkg_npm(
--- a/packages/kbn-server-http-tools/BUILD.bazel
+++ b/packages/kbn-server-http-tools/BUILD.bazel
@ -69,7 +69,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-std/BUILD.bazel
+++ b/packages/kbn-std/BUILD.bazel
@ -64,7 +64,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-telemetry-tools/BUILD.bazel
+++ b/packages/kbn-telemetry-tools/BUILD.bazel
@ -76,7 +76,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-utility-types/BUILD.bazel
+++ b/packages/kbn-utility-types/BUILD.bazel
@ -58,7 +58,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = "@kbn/utility-types",
  visibility = ["//visibility:public"],
 )
--- a/packages/kbn-utils/BUILD.bazel
+++ b/packages/kbn-utils/BUILD.bazel
@ -61,7 +61,7 @@ ts_project(
 js_library(
  name = PKG_BASE_NAME,
  srcs = NPM_MODULE_EXTRA_FILES,
-  deps = [":tsc"] + DEPS,
+  deps = DEPS + [":tsc"],
  package_name = PKG_REQUIRE_NAME,
  visibility = ["//visibility:public"],
 )