github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Dashboard] [Control] Remove support for scripted fields for options list (#144643)

Browse source 
* Remove support for scripted fields for all controls

* Remove support only for options list

* Add functional test
This commit is contained in:
Hannah Mudge 2022-11-07 09:51:11 -07:00 • committed by GitHub
parent 2619f0488f
commit 508f0127e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/plugins/controls/public/options_list/embeddable/options_list_embeddable_factory.tsx
View file

@ -56,9 +56,10 @@ export class OptionsListEmbeddableFactory
public isFieldCompatible = (dataControlField: DataControlField) => {
if (
(dataControlField.field.aggregatable && dataControlField.field.type === 'string') ||
dataControlField.field.type === 'boolean' ||
dataControlField.field.type === 'ip'
!dataControlField.field.spec.scripted &&
((dataControlField.field.aggregatable && dataControlField.field.type === 'string') ||
dataControlField.field.type === 'boolean' ||
dataControlField.field.type === 'ip')
) {
dataControlField.compatibleControlTypes.push(this.type);
}

9
test/functional/apps/dashboard_elements/controls/options_list.ts
View file

@ -195,6 +195,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboard.clearUnsavedChanges();
});
it('cannot create options list for scripted field', async () => {
expect(await dashboardControls.optionsListEditorGetCurrentDataView(true)).to.eql(
'animals-*'
);
await dashboardControls.openCreateControlFlyout();
await testSubjects.missingOrFail('field-picker-select-isDog');
await dashboardControls.controlEditorCancel(true);
});
after(async () => {
await dashboardControls.clearAllControls();
});