github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[HTTP] Additional tests for response validation in dev (#160384)

Browse source 
## Summary

Adds a few more test cases to prove that response validation is working
e2e.
This commit is contained in:
Jean-Louis Leysens 2023-07-05 15:53:33 +02:00 • committed by GitHub
parent e379f0a97d
commit 512c81c242
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 44 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/core/server/integration_tests/http/versioned_router.test.ts
View file

@ -199,6 +199,24 @@ describe('Routing versioned requests', () => {
async (ctx, req, res) => {
return res.ok({ body: { v: '1' } });
}
)
.addVersion(
{
validate: { response: { 200: { body: schema.object({}, { unknowns: 'forbid' }) } } },
version: '2',
},
async (ctx, req, res) => {
return res.ok({ body: { v: '2' } });
}
)
.addVersion(
{
validate: { response: { 200: { body: schema.object({}, { unknowns: 'allow' }) } } },
version: '3',
},
async (ctx, req, res) => {
return res.ok({ body: { v: '3' } });
}
);
await server.start();
@ -214,6 +232,32 @@ describe('Routing versioned requests', () => {
message: expect.stringMatching(/Failed output validation/),
})
);
await expect(
supertest
.get('/my-path')
.set('Elastic-Api-Version', '2')
.expect(500)
.then(({ body }) => body)
).resolves.toEqual(
expect.objectContaining({
message: expect.stringMatching(/Failed output validation/),
})
);
// This should pass response validation
await expect(
supertest
.get('/my-path')
.set('Elastic-Api-Version', '3')
.expect(200)
.then(({ body }) => body)
).resolves.toEqual(
expect.objectContaining({
v: '3',
})
);
expect(captureErrorMock).not.toHaveBeenCalled();
});