github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

fixing broken group bar chart (#10372)

Browse source 
Backports PR #10313

**Commit 1:**
fixing broken group bar chart

* Original sha: 37f3abee5b
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-13T16:21:05Z

**Commit 2:**
fixing test

* Original sha: 51aaecdb94
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-13T17:48:07Z

**Commit 3:**
updating based on last review

* Original sha: 5d37d20fb8
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-15T09:15:08Z
This commit is contained in:
jasper 2017-02-15 12:39:10 -05:00 • committed by Peter Pisljar
parent e6614fca79
commit 514d5d12d3
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/ui/public/vislib/__tests__/visualizations/column_chart.js
View file

@ -69,8 +69,16 @@ dataTypesArray.forEach(function (dataType, i) {
});
});
it('should stack values', function () {
expect(isStacked).to.be(true);
it('should stack values when mode is stacked', function () {
if (mode === 'stacked') {
expect(isStacked).to.be(true);
}
});
it('should stack values when mode is percentage', function () {
if (mode === 'percentage') {
expect(isStacked).to.be(true);
}
});
});

1
src/ui/public/vislib/lib/axis/axis_config.js
View file

@ -138,6 +138,7 @@ export default function AxisConfigFactory() {
break;
case SCALE_MODES.GROUPED:
offset = 'group';
stacked = false;
break;
case SCALE_MODES.PERCENTAGE:
offset = 'expand';