github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution][Detections] changes wording of help text for bulk editing index patterns (#136025)

Browse source 
## Summary

Changes text under index select controller for add/delete index patterns bulk edit actions: to make it more similar to helper text on rule create/edit page. Thus removing any misinterpretations from it. [More details](https://github.com/elastic/kibana/issues/126046#issuecomment-1171411706)

### Before
<p float="left">
<img width="382" alt="Screenshot 2022-07-08 at 16 36 42" src="https://user-images.githubusercontent.com/92328789/178025002-10ae6b70-a2c6-4ea8-9ef3-31927c7ed4e5.png">
<img width="381" alt="Screenshot 2022-07-08 at 16 37 02" src="https://user-images.githubusercontent.com/92328789/178025010-861b7b6c-5e54-418e-9a59-4423362d8e47.png">
</p>

### After
<p float="left">
<img width="384" alt="Screenshot 2022-07-08 at 16 37 37" src="https://user-images.githubusercontent.com/92328789/178025015-eec4a9a1-df23-44b5-bea1-3ee508e0d218.png">
<img width="382" alt="Screenshot 2022-07-08 at 16 38 03" src="https://user-images.githubusercontent.com/92328789/178025016-fb23d2d4-b56e-4ed7-afcb-35da92e8d784.png">
</p>
This commit is contained in:
Vitalii Dmyterko 2022-07-12 13:26:43 +01:00 • committed by GitHub
parent 142661cffb
commit 51a3d4a542
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/security_solution/cypress/integration/detection_rules/bulk_edit_rules.spec.ts
View file

@ -166,7 +166,7 @@ describe('Detection rules, bulk edit', () => {
cy.get(SELECT_ALL_RULES_ON_PAGE_CHECKBOX).click();
openBulkEditAddIndexPatternsForm();
cy.get(RULES_BULK_EDIT_OVERWRITE_INDEX_PATTERNS_CHECKBOX)
.should('have.text', 'Overwrite all selected rules index patterns')
.should('have.text', "Overwrite all selected rules' index patterns")
.click();
cy.get(RULES_BULK_EDIT_INDEX_PATTERNS_WARNING).should(
'have.text',
@ -216,7 +216,7 @@ describe('Detection rules, bulk edit', () => {
cy.log('Overwrite all tags');
openBulkEditAddTagsForm();
cy.get(RULES_BULK_EDIT_OVERWRITE_TAGS_CHECKBOX)
.should('have.text', 'Overwrite all selected rules tags')
.should('have.text', "Overwrite all selected rules' tags")
.click();
cy.get(RULES_BULK_EDIT_TAGS_WARNING).should(
'have.text',

8
x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/translations.ts
View file

@ -272,7 +272,7 @@ export const BULK_EDIT_FLYOUT_FORM_ADD_INDEX_PATTERNS_HELP_TEXT = i18n.translate
'xpack.securitySolution.detectionEngine.components.allRules.bulkActions.bulkEditFlyoutForm.addIndexPatternsComboboxHelpText',
{
defaultMessage:
'Select default index patterns of Elasticsearch indices from the dropdown. You can add custom index patterns and hit Enter to begin a new one.',
'Enter the pattern of Elasticsearch indices that you would like to add. By default, the dropdown includes index patterns defined in Security Solution advanced settings.',
}
);
@ -280,7 +280,7 @@ export const BULK_EDIT_FLYOUT_FORM_DELETE_INDEX_PATTERNS_HELP_TEXT = i18n.transl
'xpack.securitySolution.detectionEngine.components.allRules.bulkActions.bulkEditFlyoutForm.deleteIndexPatternsComboboxHelpText',
{
defaultMessage:
'Delete default index patterns of Elasticsearch indices from the dropdown. You can add custom index patterns and hit Enter to begin a new one.',
'Enter the pattern of Elasticsearch indices that you would like to delete. By default, the dropdown includes index patterns defined in Security Solution advanced settings.',
}
);
@ -308,7 +308,7 @@ export const BULK_EDIT_FLYOUT_FORM_ADD_INDEX_PATTERNS_TITLE = i18n.translate(
export const BULK_EDIT_FLYOUT_FORM_ADD_INDEX_PATTERNS_OVERWRITE_LABEL = i18n.translate(
'xpack.securitySolution.detectionEngine.components.allRules.bulkActions.bulkEditFlyoutForm.addIndexPatternsOverwriteCheckboxLabel',
{
defaultMessage: 'Overwrite all selected rules index patterns',
defaultMessage: "Overwrite all selected rules' index patterns",
}
);
@ -373,7 +373,7 @@ export const BULK_EDIT_FLYOUT_FORM_ADD_TAGS_TITLE = i18n.translate(
export const BULK_EDIT_FLYOUT_FORM_ADD_TAGS_OVERWRITE_LABEL = i18n.translate(
'xpack.securitySolution.detectionEngine.components.allRules.bulkActions.bulkEditFlyoutForm.addTagsOverwriteCheckboxLabel',
{
defaultMessage: 'Overwrite all selected rules tags',
defaultMessage: "Overwrite all selected rules' tags",
}
);