github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Set metadata tab as default and display Stack Trace tab only if stackframes exist (#128598)

Browse source
This commit is contained in:
Giorgos Bamparopoulos 2022-03-29 09:16:00 +01:00 • committed by GitHub
parent e628ae5b54
commit 52f0bf0a6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

41
x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx
View file

@ -21,6 +21,7 @@ import {
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React, { Fragment } from 'react';
import { isEmpty } from 'lodash';
import { CompositeSpanDurationSummaryItem } from '../../../../../../shared/summary/composite_span_duration_summary_item';
import { euiStyled } from '../../../../../../../../../../../src/plugins/kibana_react/common';
import { Span } from '../../../../../../../../typings/es_schemas/ui/span';
@ -216,24 +217,6 @@ export function SpanFlyout({
<SpanDatabase spanDb={spanDb} />
<EuiTabbedContent
tabs={[
{
id: 'stack-trace',
name: i18n.translate(
'xpack.apm.transactionDetails.spanFlyout.stackTraceTabLabel',
{
defaultMessage: 'Stack Trace',
}
),
content: (
<Fragment>
<EuiSpacer size="l" />
<Stacktrace
stackframes={stackframes}
codeLanguage={codeLanguage}
/>
</Fragment>
),
},
{
id: 'metadata',
name: i18n.translate(
@ -249,6 +232,28 @@ export function SpanFlyout({
</Fragment>
),
},
...(!isEmpty(stackframes)
? [
{
id: 'stack-trace',
name: i18n.translate(
'xpack.apm.transactionDetails.spanFlyout.stackTraceTabLabel',
{
defaultMessage: 'Stack Trace',
}
),
content: (
<Fragment>
<EuiSpacer size="l" />
<Stacktrace
stackframes={stackframes}
codeLanguage={codeLanguage}
/>
</Fragment>
),
},
]
: []),
]}
/>
</EuiFlyoutBody>