mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
[Discover] Set ownfocus to false when displaying the document flyout (#108646)
This commit is contained in:
parent
c78121ce5a
commit
53ba2c42df
5 changed files with 17 additions and 4 deletions
|
@ -17,6 +17,7 @@ export const gridStyle = {
|
|||
|
||||
export const pageSizeArr = [25, 50, 100, 250];
|
||||
export const defaultPageSize = 100;
|
||||
export const defaultTimeColumnWidth = 190;
|
||||
export const toolbarVisibility = {
|
||||
showColumnSelector: {
|
||||
allowHide: false,
|
||||
|
|
|
@ -119,7 +119,7 @@ describe('Discover grid columns ', function () {
|
|||
],
|
||||
"display": "Time (timestamp)",
|
||||
"id": "timestamp",
|
||||
"initialWidth": 180,
|
||||
"initialWidth": 190,
|
||||
"isSortable": true,
|
||||
"schema": "datetime",
|
||||
},
|
||||
|
|
|
@ -11,10 +11,11 @@ import { i18n } from '@kbn/i18n';
|
|||
import { EuiDataGridColumn, EuiScreenReaderOnly } from '@elastic/eui';
|
||||
import { ExpandButton } from './discover_grid_expand_button';
|
||||
import { DiscoverGridSettings } from './types';
|
||||
import { IndexPattern } from '../../../../../data/common/index_patterns/index_patterns';
|
||||
import type { IndexPattern } from '../../../../../data/common';
|
||||
import { buildCellActions } from './discover_grid_cell_actions';
|
||||
import { getSchemaByKbnType } from './discover_grid_schema';
|
||||
import { SelectButton } from './discover_grid_document_selection';
|
||||
import { defaultTimeColumnWidth } from './constants';
|
||||
|
||||
export function getLeadControlColumns() {
|
||||
return [
|
||||
|
@ -88,7 +89,7 @@ export function buildEuiGridColumn(
|
|||
|
||||
if (column.id === indexPattern.timeFieldName) {
|
||||
column.display = `${timeString} (${indexPattern.timeFieldName})`;
|
||||
column.initialWidth = 180;
|
||||
column.initialWidth = defaultTimeColumnWidth;
|
||||
}
|
||||
if (columnWidth > 0) {
|
||||
column.initialWidth = Number(columnWidth);
|
||||
|
|
|
@ -107,6 +107,7 @@ export function DiscoverGridFlyout({
|
|||
size="m"
|
||||
data-test-subj="docTableDetailsFlyout"
|
||||
onKeyDown={onKeyDown}
|
||||
ownFocus={false}
|
||||
>
|
||||
<EuiFlyoutHeader hasBorder>
|
||||
<EuiTitle
|
||||
|
@ -169,7 +170,7 @@ export function DiscoverGridFlyout({
|
|||
</EuiFlexItem>
|
||||
)}
|
||||
{activePage !== -1 && (
|
||||
<EuiFlexItem>
|
||||
<EuiFlexItem data-test-subj={`dscDocNavigationPage-${activePage}`}>
|
||||
<EuiPagination
|
||||
aria-label={i18n.translate('discover.grid.flyout.documentNavigation', {
|
||||
defaultMessage: 'Document navigation',
|
||||
|
|
|
@ -105,6 +105,16 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
});
|
||||
});
|
||||
|
||||
it('should allow paginating docs in the flyout by clicking in the doc table', async function () {
|
||||
await retry.try(async function () {
|
||||
await dataGrid.clickRowToggle({ rowIndex: rowToInspect - 1 });
|
||||
await testSubjects.exists(`dscDocNavigationPage0`);
|
||||
await dataGrid.clickRowToggle({ rowIndex: rowToInspect });
|
||||
await testSubjects.exists(`dscDocNavigationPage1`);
|
||||
await dataGrid.closeFlyout();
|
||||
});
|
||||
});
|
||||
|
||||
it('should show allow adding columns from the detail panel', async function () {
|
||||
await retry.try(async function () {
|
||||
await dataGrid.clickRowToggle({ isAnchorRow: false, rowIndex: rowToInspect - 1 });
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue