[9.0] [EDR Workflows] Unskip management Jest tests (#215324) (#215485)

# Backport This will backport the following commits from `main` to `9.0`: - [[EDR Workflows] Unskip management Jest tests (#215324)](https://github.com/elastic/kibana/pull/215324)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
2025-04-24 01:38:56 -04:00 · 2025-03-21 15:34:14 +01:00 · 2025-03-21 15:34:14 +01:00 · 53e55c2307
commit 53e55c2307
parent 33f9a660ca
6 changed files with 46 additions and 39 deletions
--- a/x-pack/solutions/security/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx
+++ b/x-pack/solutions/security/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx
@ -120,7 +120,8 @@ export type ReactQueryHookRenderer<
   * query response state value to be true
   */
  waitForHook?: WaitForReactHookState,
-  options?: RenderHookOptions<TProps>
+  options?: RenderHookOptions<TProps>,
+  timeout?: number
 ) => Promise<TResult>;

 export interface UserPrivilegesMockSetter {
@ -346,12 +347,13 @@ export const createAppRootMockRenderer = (): AppContextTestRender => {
     * If defined (default is `isSuccess`), the renderer will wait for the given react query to be truthy
     */
    waitForHook: WaitForReactHookState = 'isSuccess',
-    options: RenderHookOptions<TProps> = {}
+    options: RenderHookOptions<TProps> = {},
+    timeout = 1000
  ) => {
    const { result: hookResult } = renderHook<TResult, TProps>(hookFn, options);

    if (waitForHook) {
-      await waitFor(() => expect(hookResult.current[waitForHook]).toBe(true));
+      await waitFor(() => expect(hookResult.current[waitForHook]).toBe(true), { timeout });
    }

    return hookResult.current;
--- a/x-pack/solutions/security/plugins/security_solution/public/management/components/console/components/bad_argument.test.tsx
+++ b/x-pack/solutions/security/plugins/security_solution/public/management/components/console/components/bad_argument.test.tsx
@ -5,13 +5,13 @@
 * 2.0.
 */

+import { waitFor } from '@testing-library/react';
 import type { CommandDefinition, ConsoleProps } from '..';
 import type { AppContextTestRender } from '../../../../common/mock/endpoint';
 import type { ConsoleTestSetup } from '../mocks';
 import { getConsoleTestSetup } from '../mocks';

-// FLAKY: https://github.com/elastic/kibana/issues/193093
-describe.skip('BadArgument component', () => {
+describe('BadArgument component', () => {
  let render: (props?: Partial<ConsoleProps>) => ReturnType<AppContextTestRender['render']>;
  let renderResult: ReturnType<typeof render>;
  let command: CommandDefinition;
@ -39,20 +39,23 @@ describe.skip('BadArgument component', () => {
    render();
    await enterCommand('cmd1 --foo');

-    expect(renderResult.getByTestId('test-badArgument-message').textContent).toEqual(
-      'Argument --foo must have a value'
-    );
-    expect(renderResult.getByTestId('test-badArgument-commandUsage'));
-  });
+    await waitFor(() => {
+      expect(renderResult.getByTestId('test-badArgument-message').textContent).toEqual(
+        'Argument --foo must have a value'
+      );
+      expect(renderResult.getByTestId('test-badArgument-commandUsage')).toBeInTheDocument();
+    });
+  }, 10000);

  it('should only display message (no help) if command is hidden from help', async () => {
    command.helpHidden = true;
    render();
    await enterCommand('cmd1 --foo');
-
-    expect(renderResult.getByTestId('test-badArgument-message').textContent).toEqual(
-      'Argument --foo must have a value'
-    );
-    expect(renderResult.queryByTestId('test-badArgument-commandUsage')).toBeNull();
-  });
+    await waitFor(() => {
+      expect(renderResult.getByTestId('test-badArgument-message').textContent).toEqual(
+        'Argument --foo must have a value'
+      );
+      expect(renderResult.queryByTestId('test-badArgument-commandUsage')).toBeNull();
+    });
+  }, 10000);
 });
--- a/x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_users_filter.test.tsx
+++ b/x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_users_filter.test.tsx
@ -14,10 +14,9 @@ import {
 } from '../../../../common/mock/endpoint';
 import { ActionsLogUsersFilter } from './actions_log_users_filter';
 import { MANAGEMENT_PATH } from '../../../../../common/constants';
+import { waitFor } from '@testing-library/react';

-// FLAKY: https://github.com/elastic/kibana/issues/193554
-// FLAKY: https://github.com/elastic/kibana/issues/193092
-describe.skip('Users filter', () => {
+describe('Users filter', () => {
  let render: (
    props?: React.ComponentProps<typeof ActionsLogUsersFilter>
  ) => ReturnType<AppContextTestRender['render']>;
@ -27,6 +26,7 @@ describe.skip('Users filter', () => {

  const testPrefix = 'test';
  const filterPrefix = 'users-filter';
+  const delay = 100; // ms
  let onChangeUsersFilter: jest.Mock;

  beforeEach(() => {
@ -52,41 +52,45 @@ describe.skip('Users filter', () => {
    const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
    expect(searchInput).toBeTruthy();
    expect(searchInput.getAttribute('placeholder')).toEqual('Filter by username');
-  });
+  }, 10000);

  it('should search on given search string on enter', async () => {
    render();

    const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
-    await userEvent.type(searchInput, 'usernameX', { delay: 10 });
+    await userEvent.type(searchInput, 'usernameX', { delay });
    await userEvent.keyboard('{enter}');
-    expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX']);
-  });
+    await waitFor(() => expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX']));
+  }, 10000);

  it('should search comma separated strings as multiple users', async () => {
    render();

    const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
-    await userEvent.type(searchInput, 'usernameX,usernameY,usernameZ', { delay: 10 });
+    await userEvent.type(searchInput, 'usernameX,usernameY,usernameZ', { delay });
    await userEvent.keyboard('{enter}');
-    expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX', 'usernameY', 'usernameZ']);
-  });
+    await waitFor(() =>
+      expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX', 'usernameY', 'usernameZ'])
+    );
+  }, 15000);

  it('should ignore white spaces in a given username when updating the API params', async () => {
    render();

    const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
-    await userEvent.type(searchInput, '   usernameX   ', { delay: 10 });
+    await userEvent.type(searchInput, '   usernameX   ', { delay });
    await userEvent.keyboard('{enter}');
-    expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX']);
-  });
+    await waitFor(() => expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX']));
+  }, 10000);

  it('should ignore white spaces in comma separated usernames when updating the API params', async () => {
    render();

    const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
-    await userEvent.type(searchInput, '   , usernameX ,usernameY    ,       ', { delay: 10 });
+    await userEvent.type(searchInput, '   , usernameX ,usernameY    ,       ', { delay });
    await userEvent.keyboard('{enter}');
-    expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX', 'usernameY']);
-  });
+    await waitFor(() =>
+      expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX', 'usernameY'])
+    );
+  }, 15000);
 });
--- a/x-pack/solutions/security/plugins/security_solution/public/management/hooks/artifacts/use_list_artifact.test.tsx
+++ b/x-pack/solutions/security/plugins/security_solution/public/management/hooks/artifacts/use_list_artifact.test.tsx
@ -16,8 +16,7 @@ import {
  renderQuery,
 } from '../test_utils';

-// FLAKY: https://github.com/elastic/kibana/issues/196724
-describe.skip('List artifact hook', () => {
+describe('List artifact hook', () => {
  let result: ReturnType<typeof useListArtifact>;
  let searchableFields: string[];
  let options:
--- a/x-pack/solutions/security/plugins/security_solution/public/management/hooks/endpoint/use_get_endpoint_details.test.ts
+++ b/x-pack/solutions/security/plugins/security_solution/public/management/hooks/endpoint/use_get_endpoint_details.test.ts
@ -24,8 +24,7 @@ jest.mock('@tanstack/react-query', () => {
  };
 });

-// FLAKY: https://github.com/elastic/kibana/issues/192435
-describe.skip('useGetEndpointDetails hook', () => {
+describe('useGetEndpointDetails hook', () => {
  let renderReactQueryHook: ReactQueryHookRenderer<
    Parameters<typeof useGetEndpointDetails>[number],
    ReturnType<typeof useGetEndpointDetails>
@ -43,7 +42,7 @@ describe.skip('useGetEndpointDetails hook', () => {
  });

  it('should call the proper API', async () => {
-    await renderReactQueryHook(() => useGetEndpointDetails('123'));
+    await renderReactQueryHook(() => useGetEndpointDetails('123'), 'isSuccess', {}, 5000);

    expect(apiMocks.responseProvider.metadataDetails).toHaveBeenCalledWith({
      path: resolvePathVariables(HOST_METADATA_GET_ROUTE, { id: '123' }),
@ -52,7 +51,7 @@ describe.skip('useGetEndpointDetails hook', () => {
  });

  it('should call api with `undefined` for endpoint id if it was not defined on input', async () => {
-    await renderReactQueryHook(() => useGetEndpointDetails(''));
+    await renderReactQueryHook(() => useGetEndpointDetails(''), 'isSuccess', {}, 5000);

    expect(apiMocks.responseProvider.metadataDetails).toHaveBeenCalledWith({
      path: resolvePathVariables(HOST_METADATA_GET_ROUTE, {
--- a/x-pack/solutions/security/plugins/security_solution/public/management/hooks/test_utils.tsx
+++ b/x-pack/solutions/security/plugins/security_solution/public/management/hooks/test_utils.tsx
@ -42,7 +42,7 @@ export const renderQuery = async (
  const { result: resultHook } = renderHook(() => hook(), {
    wrapper,
  });
-  await waitFor(() => expect(resultHook.current[waitForHook]).toBeTruthy());
+  await waitFor(() => expect(resultHook.current[waitForHook]).toBeTruthy(), { timeout: 5000 });
  return resultHook.current;
 };