github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 11:05:39 -04:00
Code Issues Projects Releases Packages Wiki Activity

Move require calls outside of task functions (elastic/kibana-plugin-helpers#23)

Browse source 
* move require calls outside of task functions

* fix default command value

Original commit: elastic/kibana-plugin-helpers@846855e960
This commit is contained in:
Joe Fleming 2016-12-15 13:15:36 -07:00 • committed by Spencer
parent be64fe21a4
commit 545a304f0f
4 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
packages/kbn-plugin-helpers/tasks/build/build_action.js
View file

@ -1,11 +1,12 @@
var vfs = require('vinyl-fs');
var zip = require('gulp-zip');
var map = require('through2-map').obj;
var rename = require('gulp-rename');
var join = require('path').join;
var inquirer = require('inquirer');
module.exports = function (plugin) { module.exports = function (plugin) {
return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
var vfs = require('vinyl-fs');
var zip = require('gulp-zip');
var map = require('through2-map').obj;
var rename = require('gulp-rename');
var join = require('path').join;
var inquirer = require('inquirer');
function main() { function main() {
var kibanaVersion = (plugin.pkg.kibana && plugin.pkg.kibana.version) || plugin.pkg.version; var kibanaVersion = (plugin.pkg.kibana && plugin.pkg.kibana.version) || plugin.pkg.version;

4
packages/kbn-plugin-helpers/tasks/start/start_action.js
View file

@ -1,5 +1,7 @@
var execFileSync = require('child_process').execFileSync;
module.exports = function (plugin, run, command) { module.exports = function (plugin, run, command) {
var execFileSync = require('child_process').execFileSync; command = command || {};
var cmd = (process.platform === 'win32') ? 'bin\\kibana.bat' : 'bin/kibana'; var cmd = (process.platform === 'win32') ? 'bin\\kibana.bat' : 'bin/kibana';
var args = ['--dev', '--plugin-path', plugin.root]; var args = ['--dev', '--plugin-path', plugin.root];

3
packages/kbn-plugin-helpers/tasks/test/browser/test_browser_action.js
View file

@ -1,5 +1,6 @@
var execFileSync = require('child_process').execFileSync;
module.exports = function testBrowserAction(plugin, run, command) { module.exports = function testBrowserAction(plugin, run, command) {
var execFileSync = require('child_process').execFileSync;
command = command || {}; command = command || {};
var kbnServerArgs = [ var kbnServerArgs = [

8
packages/kbn-plugin-helpers/tasks/test/server/test_server_action.js
View file

@ -1,8 +1,8 @@
module.exports = function (plugin) { var resolve = require('path').resolve;
var resolve = require('path').resolve; var delimiter = require('path').delimiter;
var delimiter = require('path').delimiter; var execFileSync = require('child_process').execFileSync;
var execFileSync = require('child_process').execFileSync;
module.exports = function (plugin) {
var kibanaBins = resolve(plugin.kibanaRoot, 'node_modules/.bin'); var kibanaBins = resolve(plugin.kibanaRoot, 'node_modules/.bin');
var mochaSetupJs = resolve(plugin.kibanaRoot, 'test/mocha_setup.js'); var mochaSetupJs = resolve(plugin.kibanaRoot, 'test/mocha_setup.js');