github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

allow editing adhoc dataview (#136251)

Browse source
This commit is contained in:
Peter Pisljar 2022-07-13 09:16:36 +02:00 • committed by GitHub
parent 265c405f36
commit 560fc63082
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/plugins/data_view_editor/public/components/data_view_flyout_content_container.tsx
View file

@ -33,7 +33,9 @@ const IndexPatternFlyoutContentContainer = ({
editData.title = title;
editData.name = name;
editData.timeFieldName = timeFieldName;
saveResponse = await dataViews.updateSavedObject(editData);
saveResponse = editData.isPersisted()
? await dataViews.updateSavedObject(editData)
: editData;
} else {
saveResponse = persist
? await dataViews.createAndSave(dataViewSpec)

4
src/plugins/data_view_management/public/components/edit_index_pattern/index_header/index_header.tsx
View file

@ -67,7 +67,7 @@ export const IndexHeader: React.FC<IndexHeaderProps> = ({
{editTooltip}
</EuiButton>
),
defaultIndex !== indexPattern.id && setDefault && canSave && (
defaultIndex !== indexPattern.id && setDefault && canSave && indexPattern.isPersisted() && (
<EuiButton
onClick={setDefault}
iconType="starFilled"
@ -77,7 +77,7 @@ export const IndexHeader: React.FC<IndexHeaderProps> = ({
{setDefaultTooltip}
</EuiButton>
),
canSave && (
canSave && indexPattern.isPersisted() && (
<EuiButtonEmpty
color="danger"
onClick={deleteIndexPatternClick}

2
src/plugins/data_views/common/data_views/data_view.ts
View file

@ -156,7 +156,7 @@ export class DataView implements DataViewBase {
// set values
this.id = spec.id;
this.fieldFormatMap = spec.fieldFormats || {};
this.fieldFormatMap = { ...spec.fieldFormats };
this.version = spec.version;