github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[File upload] Enforce file-type check in file dialog (#55063) (#55450)

Browse source
This commit is contained in:
Thomas Neirynck 2020-01-21 16:37:08 -05:00 • committed by GitHub
parent 3d1140e251
commit 56e28e7c8b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
x-pack/legacy/plugins/file_upload/public/components/json_index_file_picker.js
View file

@ -13,6 +13,8 @@ import { MAX_FILE_SIZE } from '../../common/constants/file_import';
import _ from 'lodash';
const ACCEPTABLE_FILETYPES = ['json', 'geojson'];
const acceptedFileTypeString = ACCEPTABLE_FILETYPES.map(type => `.${type}`).join(',');
const acceptedFileTypeStringMessage = ACCEPTABLE_FILETYPES.map(type => `.${type}`).join(', ');
export class JsonIndexFilePicker extends Component {
state = {
@ -103,6 +105,7 @@ export class JsonIndexFilePicker extends Component {
const splitNameArr = name.split('.');
const fileType = splitNameArr.pop();
if (!ACCEPTABLE_FILETYPES.includes(fileType)) {
//should only occur if browser does not accept the <File> accept parameter
throw new Error(
i18n.translate('xpack.fileUpload.jsonIndexFilePicker.acceptableTypesError', {
defaultMessage: 'File is not one of acceptable types: {types}',
@ -252,7 +255,10 @@ export class JsonIndexFilePicker extends Component {
) : (
<span>
{i18n.translate('xpack.fileUpload.jsonIndexFilePicker.formatsAccepted', {
defaultMessage: 'Formats accepted: .json, .geojson',
defaultMessage: 'Formats accepted: {acceptedFileTypeStringMessage}',
values: {
acceptedFileTypeStringMessage,
},
})}{' '}
<br />
<FormattedMessage
@ -274,6 +280,7 @@ export class JsonIndexFilePicker extends Component {
/>
}
onChange={this._fileHandler}
accept={acceptedFileTypeString}
/>
</EuiFormRow>
</Fragment>

1
x-pack/plugins/translations/translations/ja-JP.json
View file

@ -5703,7 +5703,6 @@
"xpack.fileUpload.jsonIndexFilePicker.filePickerLabel": "アップロードするファイルを選択",
"xpack.fileUpload.jsonIndexFilePicker.fileProcessingError": "ファイル処理エラー: {errorMessage}",
"xpack.fileUpload.jsonIndexFilePicker.fileSizeError": "ファイルサイズエラー: {errorMessage}",
"xpack.fileUpload.jsonIndexFilePicker.formatsAccepted": "許可されている形式：.json、.geojson",
"xpack.fileUpload.jsonIndexFilePicker.maxSize": "最大サイズ：{maxFileSize}",
"xpack.fileUpload.jsonIndexFilePicker.noFileNameError": "ファイル名が指定されていません",
"xpack.fileUpload.jsonIndexFilePicker.parsingFile": "{featuresProcessed} 件の機能が解析されました…",

1
x-pack/plugins/translations/translations/zh-CN.json
View file

@ -5702,7 +5702,6 @@
"xpack.fileUpload.jsonIndexFilePicker.filePickerLabel": "选择文件进行上传",
"xpack.fileUpload.jsonIndexFilePicker.fileProcessingError": "文件处理错误：{errorMessage}",
"xpack.fileUpload.jsonIndexFilePicker.fileSizeError": "文件大小错误：{errorMessage}",
"xpack.fileUpload.jsonIndexFilePicker.formatsAccepted": "接受的格式：.json、.geojson",
"xpack.fileUpload.jsonIndexFilePicker.maxSize": "最大大小：{maxFileSize}",
"xpack.fileUpload.jsonIndexFilePicker.noFileNameError": "未提供任何文件名称",
"xpack.fileUpload.jsonIndexFilePicker.parsingFile": "{featuresProcessed} 特征已解析......",