mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
[Security Solution][Admin][Policy] Fixes bug in policy details form where sticky bottom bar hides the side nav bar (#161492)
## Summary - [x] Fixes sticky bottom bar to go behind the side nav in policy details - [x] Adds functional test to ensure bug does not get reopened ## BEFORE  AFTER   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
parent
4439121c32
commit
57fa6ae9f3
2 changed files with 11 additions and 3 deletions
|
@ -12,7 +12,6 @@ import {
|
|||
EuiButton,
|
||||
EuiButtonEmpty,
|
||||
EuiLoadingSpinner,
|
||||
EuiBottomBar,
|
||||
EuiSpacer,
|
||||
} from '@elastic/eui';
|
||||
import { FormattedMessage } from '@kbn/i18n-react';
|
||||
|
@ -21,6 +20,7 @@ import { useDispatch } from 'react-redux';
|
|||
import { useLocation } from 'react-router-dom';
|
||||
import type { ApplicationStart } from '@kbn/core/public';
|
||||
import { toMountPoint } from '@kbn/kibana-react-plugin/public';
|
||||
import { KibanaPageTemplate } from '@kbn/shared-ux-page-kibana-template';
|
||||
import { useShowEditableFormFields, usePolicyDetailsSelector } from '../../policy_hooks';
|
||||
import {
|
||||
policyDetails,
|
||||
|
@ -159,7 +159,7 @@ export const PolicyFormLayout = React.memo(() => {
|
|||
)}
|
||||
<PolicyDetailsForm />
|
||||
<EuiSpacer size="xxl" />
|
||||
<EuiBottomBar paddingSize="s">
|
||||
<KibanaPageTemplate.BottomBar paddingSize="s">
|
||||
<EuiFlexGroup justifyContent="flexEnd" gutterSize="s">
|
||||
<EuiFlexItem grow={false}>
|
||||
<EuiButtonEmpty
|
||||
|
@ -190,7 +190,7 @@ export const PolicyFormLayout = React.memo(() => {
|
|||
</EuiFlexItem>
|
||||
)}
|
||||
</EuiFlexGroup>
|
||||
</EuiBottomBar>
|
||||
</KibanaPageTemplate.BottomBar>
|
||||
</>
|
||||
);
|
||||
});
|
||||
|
|
|
@ -72,6 +72,14 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
|
|||
);
|
||||
});
|
||||
|
||||
it('should not hide the side navigation', async () => {
|
||||
await testSubjects.scrollIntoView('solutionSideNavItemLink-get_started');
|
||||
// ensure center of button is visible and not hidden by sticky bottom bar
|
||||
await testSubjects.click('solutionSideNavItemLink-administration', 1000, 15);
|
||||
// test cleanup: go back to policy details page
|
||||
await pageObjects.policy.navigateToPolicyDetails(policyInfo.packagePolicy.id);
|
||||
});
|
||||
|
||||
it('and the show advanced settings button is clicked', async () => {
|
||||
await testSubjects.missingOrFail('advancedPolicyPanel');
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue