github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.6] Improve security of links using target=_blank (#150049) (#150161)

Browse source 
# Backport

This will backport the following commits from `main` to `8.6`:
- [Improve security of links using target=_blank
(#150049)](https://github.com/elastic/kibana/pull/150049)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thomas
Watson","email":"watson@elastic.co"},"sourceCommit":{"committedDate":"2023-02-02T12:10:43Z","message":"Improve
security of links using target=_blank
(#150049)","sha":"4a1373c46fafe71be6334838413f71683ab263fa","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.7.0"],"number":150049,"url":"https://github.com/elastic/kibana/pull/150049","mergeCommit":{"message":"Improve
security of links using target=_blank
(#150049)","sha":"4a1373c46fafe71be6334838413f71683ab263fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150049","number":150049,"mergeCommit":{"message":"Improve
security of links using target=_blank
(#150049)","sha":"4a1373c46fafe71be6334838413f71683ab263fa"}}]}]
BACKPORT-->

Co-authored-by: Thomas Watson <watson@elastic.co>
This commit is contained in:
Kibana Machine 2023-02-02 08:42:09 -05:00 • committed by GitHub
parent 4f51ca24ba
commit 5838cd7677
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/core/apps/core-apps-browser-internal/src/errors/public_base_url.tsx
View file

@ -58,7 +58,11 @@ export const setupPublicBaseUrlConfigWarning = ({
configKey: <code>server.publicBaseUrl</code>,
}}
/>{' '}
<a href={`${docLinks.links.settings}#server-publicBaseUrl`} target="_blank">
<a
href={`${docLinks.links.settings}#server-publicBaseUrl`}
target="_blank"
rel="noopener noreferrer"
>
<FormattedMessage
id="core.ui.publicBaseUrlWarning.learnMoreLinkLabel"
defaultMessage="Learn more."

6
x-pack/plugins/index_management/public/application/components/mappings_editor/components/configuration_form/source_field_section/source_field_section.tsx
View file

@ -44,7 +44,11 @@ export const SourceFieldSection = () => {
</p>
<p>
<a href={documentationService.getDisablingMappingSourceFieldLink()} target="_blank">
<a
href={documentationService.getDisablingMappingSourceFieldLink()}
target="_blank"
rel="noopener noreferrer"
>
<FormattedMessage
id="xpack.idxMgmt.mappingsEditor.disabledSourceFieldCallOutDescription2"
defaultMessage="Learn more about alternatives to disabling the {source} field."