mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
[Lens] Unskip failing tests (#167599)
## Summary Closes https://github.com/elastic/kibana/issues/167561 Closes https://github.com/elastic/kibana/issues/167552 FT runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3254 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This commit is contained in:
parent
474c8eaf52
commit
5b0ec2e92d
3 changed files with 20 additions and 8 deletions
|
@ -26,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
const from = 'Sep 19, 2015 @ 06:31:44.000';
|
||||
const to = 'Sep 23, 2015 @ 18:31:44.000';
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/167552
|
||||
describe.skip('lens annotations tests', () => {
|
||||
describe('lens annotations tests', () => {
|
||||
before(async () => {
|
||||
await PageObjects.common.setTime({ from, to });
|
||||
});
|
||||
|
@ -148,6 +147,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
},
|
||||
{
|
||||
submit: true,
|
||||
clearWithKeyboard: true,
|
||||
}
|
||||
);
|
||||
|
||||
|
|
|
@ -29,8 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
const lensTag = 'extreme-lens-tag';
|
||||
const lensTitle = 'lens tag test';
|
||||
|
||||
// Failing: See https://github.com/elastic/kibana/issues/167561
|
||||
describe.skip('lens tagging', () => {
|
||||
describe('lens tagging', () => {
|
||||
before(async () => {
|
||||
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
|
||||
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
|
||||
|
@ -84,6 +83,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
},
|
||||
{
|
||||
submit: true,
|
||||
clearWithKeyboard: true,
|
||||
}
|
||||
);
|
||||
|
||||
|
|
|
@ -51,13 +51,23 @@ class TagModal extends FtrService {
|
|||
* If a field is undefined, will not set the value (use a empty string for that)
|
||||
* If `submit` is true, will call `clickConfirm` once the fields have been filled.
|
||||
*/
|
||||
async fillForm(fields: FillTagFormFields, { submit = false }: { submit?: boolean } = {}) {
|
||||
async fillForm(
|
||||
fields: FillTagFormFields,
|
||||
{
|
||||
submit = false,
|
||||
clearWithKeyboard = false,
|
||||
}: { submit?: boolean; clearWithKeyboard?: boolean } = {}
|
||||
) {
|
||||
if (fields.name !== undefined) {
|
||||
await this.testSubjects.click('createModalField-name');
|
||||
await this.testSubjects.setValue('createModalField-name', fields.name);
|
||||
await this.testSubjects.setValue('createModalField-name', fields.name, {
|
||||
clearWithKeyboard,
|
||||
});
|
||||
}
|
||||
if (fields.color !== undefined) {
|
||||
await this.testSubjects.setValue('~createModalField-color', fields.color);
|
||||
await this.testSubjects.setValue('~createModalField-color', fields.color, {
|
||||
clearWithKeyboard,
|
||||
});
|
||||
// Close the popover before moving to the next input, as it can get in the way of interacting with other elements
|
||||
await this.testSubjects.existOrFail('euiSaturation');
|
||||
await this.retry.try(async () => {
|
||||
|
@ -69,7 +79,9 @@ class TagModal extends FtrService {
|
|||
}
|
||||
if (fields.description !== undefined) {
|
||||
await this.testSubjects.click('createModalField-description');
|
||||
await this.testSubjects.setValue('createModalField-description', fields.description);
|
||||
await this.testSubjects.setValue('createModalField-description', fields.description, {
|
||||
clearWithKeyboard,
|
||||
});
|
||||
}
|
||||
|
||||
if (submit) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue