[APM] TypeScript performance fix (#120754)

* [APM] TypeScript performance fix

* Clarify use_apm_params split with comments

* Remove ts-expect-error for security plugin

* Fix type error in searchtypes

packages/kbn-typed-react-router-config/src/types/index.ts

@@ -13,97 +13,13 @@ import { RequiredKeys, ValuesType } from 'utility-types';
 // import { unconst } from '../unconst';
 import { NormalizePath } from './utils';
 
-type PathsOfRoute<TRoute extends Route> =
+// type PathsOfRoute<TRoute extends Route> =
-  | TRoute['path']
+//   | TRoute['path']
-  | (TRoute extends { children: Route[] }
+//   | (TRoute extends { children: Route[] }
-      ? AppendPath<TRoute['path'], '/*'> | PathsOf<TRoute['children']>
+//       ? AppendPath<TRoute['path'], '/*'> | PathsOf<TRoute['children']>
-      : never);
+//       : never);
 
-export type PathsOf<TRoutes extends Route[]> = TRoutes extends []
+export type PathsOf<TRoutes extends Route[]> = keyof MapRoutes<TRoutes> & string;
-  ? never
-  : TRoutes extends [Route]
-  ? PathsOfRoute<TRoutes[0]>
-  : TRoutes extends [Route, Route]
-  ? PathsOfRoute<TRoutes[0]> | PathsOfRoute<TRoutes[1]>
-  : TRoutes extends [Route, Route, Route]
-  ? PathsOfRoute<TRoutes[0]> | PathsOfRoute<TRoutes[1]> | PathsOfRoute<TRoutes[2]>
-  : TRoutes extends [Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-  : TRoutes extends [Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-  : TRoutes extends [Route, Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-      | PathsOfRoute<TRoutes[5]>
-  : TRoutes extends [Route, Route, Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-      | PathsOfRoute<TRoutes[5]>
-      | PathsOfRoute<TRoutes[6]>
-  : TRoutes extends [Route, Route, Route, Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-      | PathsOfRoute<TRoutes[5]>
-      | PathsOfRoute<TRoutes[6]>
-      | PathsOfRoute<TRoutes[7]>
-  : TRoutes extends [Route, Route, Route, Route, Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-      | PathsOfRoute<TRoutes[5]>
-      | PathsOfRoute<TRoutes[6]>
-      | PathsOfRoute<TRoutes[7]>
-      | PathsOfRoute<TRoutes[8]>
-  : TRoutes extends [Route, Route, Route, Route, Route, Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-      | PathsOfRoute<TRoutes[5]>
-      | PathsOfRoute<TRoutes[6]>
-      | PathsOfRoute<TRoutes[7]>
-      | PathsOfRoute<TRoutes[8]>
-      | PathsOfRoute<TRoutes[9]>
-  : TRoutes extends [Route, Route, Route, Route, Route, Route, Route, Route, Route, Route, Route]
-  ?
-      | PathsOfRoute<TRoutes[0]>
-      | PathsOfRoute<TRoutes[1]>
-      | PathsOfRoute<TRoutes[2]>
-      | PathsOfRoute<TRoutes[3]>
-      | PathsOfRoute<TRoutes[4]>
-      | PathsOfRoute<TRoutes[5]>
-      | PathsOfRoute<TRoutes[6]>
-      | PathsOfRoute<TRoutes[7]>
-      | PathsOfRoute<TRoutes[8]>
-      | PathsOfRoute<TRoutes[9]>
-      | PathsOfRoute<TRoutes[10]>
-  : string;
 
 export interface RouteMatch<TRoute extends Route = Route> {
   route: TRoute;
@@ -347,6 +263,14 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 
 // const routes = unconst([
 //   {
+//     path: '/link-to/transaction/{transactionId}',
+//     element,
+//   },
+//   {
+//     path: '/link-to/trace/{traceId}',
+//     element,
+//   },
+//   {
 //     path: '/',
 //     element,
 //     children: [
@@ -393,6 +317,10 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 //             element,
 //           },
 //           {
+//             path: '/settings/agent-keys',
+//             element,
+//           },
+//           {
 //             path: '/settings',
 //             element,
 //           },
@@ -430,11 +358,19 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 //             element,
 //           },
 //           {
+//             path: '/services/:serviceName/transactions/view',
+//             element,
+//           },
+//           {
+//             path: '/services/:serviceName/dependencies',
+//             element,
+//           },
+//           {
 //             path: '/services/:serviceName/errors',
 //             element,
 //             children: [
 //               {
-//                 path: '/:groupId',
+//                 path: '/services/:serviceName/errors/:groupId',
 //                 element,
 //                 params: t.type({
 //                   path: t.type({
@@ -443,7 +379,7 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 //                 }),
 //               },
 //               {
-//                 path: '/services/:serviceName',
+//                 path: '/services/:serviceName/errors',
 //                 element,
 //                 params: t.partial({
 //                   query: t.partial({
@@ -457,15 +393,33 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 //             ],
 //           },
 //           {
-//             path: '/services/:serviceName/foo',
+//             path: '/services/:serviceName/metrics',
 //             element,
 //           },
 //           {
-//             path: '/services/:serviceName/bar',
+//             path: '/services/:serviceName/nodes',
+//             element,
+//             children: [
+//               {
+//                 path: '/services/{serviceName}/nodes/{serviceNodeName}/metrics',
 //                 element,
 //               },
 //               {
-//             path: '/services/:serviceName/baz',
+//                 path: '/services/:serviceName/nodes',
+//                 element,
+//               },
+//             ],
+//           },
+//           {
+//             path: '/services/:serviceName/service-map',
+//             element,
+//           },
+//           {
+//             path: '/services/:serviceName/logs',
+//             element,
+//           },
+//           {
+//             path: '/services/:serviceName/profiling',
 //             element,
 //           },
 //           {
@@ -497,6 +451,24 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 //             element,
 //           },
 //           {
+//             path: '/backends',
+//             element,
+//             children: [
+//               {
+//                 path: '/backends/{backendName}/overview',
+//                 element,
+//               },
+//               {
+//                 path: '/backends/overview',
+//                 element,
+//               },
+//               {
+//                 path: '/backends',
+//                 element,
+//               },
+//             ],
+//           },
+//           {
 //             path: '/',
 //             element,
 //           },
@@ -509,10 +481,11 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 // type Routes = typeof routes;
 
 // type Mapped = keyof MapRoutes<Routes>;
+// type Paths = PathsOf<Routes>;
 
 // type Bar = ValuesType<Match<Routes, '/*'>>['route']['path'];
 // type Foo = OutputOf<Routes, '/*'>;
-// type Baz = OutputOf<Routes, '/services/:serviceName/baz'>;
+// // type Baz = OutputOf<Routes, '/services/:serviceName/errors'>;
 
 // const { path }: Foo = {} as any;
 
@@ -520,4 +493,4 @@ type MapRoutes<TRoutes, TParents extends Route[] = []> = TRoutes extends [Route]
 //   return {} as any;
 // }
 
-// const params = _useApmParams('/*');
+// // const params = _useApmParams('/services/:serviceName/nodes/*');

src/core/types/elasticsearch/search.ts

@@ -9,6 +9,11 @@
 import { ValuesType, UnionToIntersection } from 'utility-types';
 import * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
 
+interface AggregationsAggregationContainer extends Record<string, any> {
+  aggs?: any;
+  aggregations?: any;
+}
+
 type InvalidAggregationRequest = unknown;
 
 // ensures aggregations work with requests where aggregation options are a union type,
@@ -31,7 +36,7 @@ type KeysOfSources<T extends any[]> = T extends [any]
   ? KeyOfSource<T[0]> & KeyOfSource<T[1]> & KeyOfSource<T[2]> & KeyOfSource<T[3]>
   : Record<string, null | string | number>;
 
-type CompositeKeysOf<TAggregationContainer extends estypes.AggregationsAggregationContainer> =
+type CompositeKeysOf<TAggregationContainer extends AggregationsAggregationContainer> =
   TAggregationContainer extends {
     composite: { sources: [...infer TSource] };
   }
@@ -40,7 +45,7 @@ type CompositeKeysOf<TAggregationContainer extends estypes.AggregationsAggregati
 
 type Source = estypes.SearchSourceFilter | boolean | estypes.Fields;
 
-type TopMetricKeysOf<TAggregationContainer extends estypes.AggregationsAggregationContainer> =
+type TopMetricKeysOf<TAggregationContainer extends AggregationsAggregationContainer> =
   TAggregationContainer extends { top_metrics: { metrics: { field: infer TField } } }
     ? TField
     : TAggregationContainer extends { top_metrics: { metrics: Array<{ field: infer TField }> } }
@@ -92,17 +97,9 @@ type HitsOf<
   >
 >;
 
-type AggregationTypeName = Exclude<
+type AggregationMap = Partial<Record<string, AggregationsAggregationContainer>>;
-  keyof estypes.AggregationsAggregationContainer,
-  'aggs' | 'aggregations'
->;
 
-type AggregationMap = Partial<Record<string, estypes.AggregationsAggregationContainer>>;
+type TopLevelAggregationRequest = Pick<AggregationsAggregationContainer, 'aggs' | 'aggregations'>;
-
-type TopLevelAggregationRequest = Pick<
-  estypes.AggregationsAggregationContainer,
-  'aggs' | 'aggregations'
->;
 
 type MaybeKeyed<
   TAggregationContainer,
@@ -113,9 +110,11 @@ type MaybeKeyed<
   : { buckets: TBucket[] };
 
 export type AggregateOf<
-  TAggregationContainer extends estypes.AggregationsAggregationContainer,
+  TAggregationContainer extends AggregationsAggregationContainer,
   TDocument
-> = (Record<AggregationTypeName, unknown> & {
+> = ValuesType<
+  Pick<
+    Record<string, unknown> & {
       adjacency_matrix: {
         buckets: Array<
           {
@@ -273,14 +272,21 @@ export type AggregateOf<
               [key in keyof TAggregationContainer['filters']['filters']]: {
                 doc_count: number;
               } & SubAggregateOf<TAggregationContainer, TDocument>;
-        } & (TAggregationContainer extends { filters: { other_bucket_key: infer TOtherBucketKey } }
+            } & (TAggregationContainer extends {
+              filters: { other_bucket_key: infer TOtherBucketKey };
+            }
               ? Record<
                   TOtherBucketKey & string,
                   { doc_count: number } & SubAggregateOf<TAggregationContainer, TDocument>
                 >
               : unknown) &
               (TAggregationContainer extends { filters: { other_bucket: true } }
-            ? { _other: { doc_count: number } & SubAggregateOf<TAggregationContainer, TDocument> }
+                ? {
+                    _other: { doc_count: number } & SubAggregateOf<
+                      TAggregationContainer,
+                      TDocument
+                    >;
+                  }
                 : unknown)
           : unknown;
       };
@@ -551,10 +557,13 @@ export type AggregateOf<
         value: number;
       };
       // t_test: {} not defined
-})[ValidAggregationKeysOf<TAggregationContainer> & AggregationTypeName];
+    },
+    Exclude<ValidAggregationKeysOf<TAggregationContainer>, 'aggs' | 'aggregations'> & string
+  >
+>;
 
 type AggregateOfMap<TAggregationMap extends AggregationMap | undefined, TDocument> = {
-  [TAggregationName in keyof TAggregationMap]: Required<TAggregationMap>[TAggregationName] extends estypes.AggregationsAggregationContainer
+  [TAggregationName in keyof TAggregationMap]: Required<TAggregationMap>[TAggregationName] extends AggregationsAggregationContainer
     ? AggregateOf<TAggregationMap[TAggregationName], TDocument>
     : never; // using never means we effectively ignore optional keys, using {} creates a union type of { ... } | {}
 };

x-pack/plugins/apm/public/components/app/service_inventory/index.tsx

@@ -19,7 +19,7 @@ import { useAnomalyDetectionJobsContext } from '../../../context/anomaly_detecti
 import { useApmPluginContext } from '../../../context/apm_plugin/use_apm_plugin_context';
 import { useLegacyUrlParams } from '../../../context/url_params_context/use_url_params';
 import { useLocalStorage } from '../../../hooks/useLocalStorage';
-import { useApmParams } from '../../../hooks/use_apm_params';
+import { useAnyOfApmParams } from '../../../hooks/use_apm_params';
 import { FETCH_STATUS, useFetcher } from '../../../hooks/use_fetcher';
 import { useTimeRange } from '../../../hooks/use_time_range';
 import { useUpgradeAssistantHref } from '../../shared/Links/kibana';
@@ -46,9 +46,7 @@ function useServicesFetcher() {
 
   const {
     query: { rangeFrom, rangeTo, environment, kuery },
-  } =
+  } = useAnyOfApmParams('/services/{serviceName}', '/services');
-    // @ts-ignore 4.3.5 upgrade - Type instantiation is excessively deep and possibly infinite.
-    useApmParams('/services/{serviceName}', '/services');
 
   const { start, end } = useTimeRange({ rangeFrom, rangeTo });
 

x-pack/plugins/apm/public/components/app/service_map/Controls.tsx

@@ -16,7 +16,7 @@ import { useLegacyUrlParams } from '../../../context/url_params_context/use_url_
 import { APMQueryParams } from '../../shared/Links/url_helpers';
 import { CytoscapeContext } from './Cytoscape';
 import { getAnimationOptions, getNodeHeight } from './cytoscape_options';
-import { useApmParams } from '../../../hooks/use_apm_params';
+import { useAnyOfApmParams } from '../../../hooks/use_apm_params';
 
 const ControlsContainer = euiStyled('div')`
   left: ${({ theme }) => theme.eui.gutterTypes.gutterMedium};
@@ -107,7 +107,7 @@ export function Controls() {
 
   const {
     query: { kuery },
-  } = useApmParams('/service-map', '/services/{serviceName}/service-map');
+  } = useAnyOfApmParams('/service-map', '/services/{serviceName}/service-map');
 
   const [zoom, setZoom] = useState((cy && cy.zoom()) || 1);
   const duration = parseInt(theme.eui.euiAnimSpeedFast, 10);

x-pack/plugins/apm/public/components/app/service_map/Popover/backend_contents.tsx

@@ -13,7 +13,7 @@ import React from 'react';
 import { useUiTracker } from '../../../../../../observability/public';
 import { ContentsProps } from '.';
 import { NodeStats } from '../../../../../common/service_map';
-import { useApmParams } from '../../../../hooks/use_apm_params';
+import { useAnyOfApmParams } from '../../../../hooks/use_apm_params';
 import { useApmRouter } from '../../../../hooks/use_apm_router';
 import { FETCH_STATUS, useFetcher } from '../../../../hooks/use_fetcher';
 import { ApmRoutes } from '../../../routing/apm_route_config';
@@ -25,8 +25,7 @@ export function BackendContents({
   start,
   end,
 }: ContentsProps) {
-  // @ts-ignore 4.3.5 upgrade - Type instantiation is excessively deep and possibly infinite.
+  const { query } = useAnyOfApmParams(
-  const { query } = useApmParams(
     '/service-map',
     '/services/{serviceName}/service-map'
   );

x-pack/plugins/apm/public/components/shared/time_comparison/index.tsx

@@ -15,7 +15,7 @@ import { useUiTracker } from '../../../../../observability/public';
 import { TimeRangeComparisonEnum } from '../../../../common/runtime_types/comparison_type_rt';
 import { useLegacyUrlParams } from '../../../context/url_params_context/use_url_params';
 import { useApmPluginContext } from '../../../context/apm_plugin/use_apm_plugin_context';
-import { useApmParams } from '../../../hooks/use_apm_params';
+import { useAnyOfApmParams } from '../../../hooks/use_apm_params';
 import { useBreakpoints } from '../../../hooks/use_breakpoints';
 import { useTimeRange } from '../../../hooks/use_time_range';
 import * as urlHelpers from '../../shared/Links/url_helpers';
@@ -121,8 +121,7 @@ export function TimeComparison() {
   const { isSmall } = useBreakpoints();
   const {
     query: { rangeFrom, rangeTo },
-    // @ts-expect-error Type instantiation is excessively deep and possibly infinite.
+  } = useAnyOfApmParams('/services', '/backends/*', '/services/{serviceName}');
-  } = useApmParams('/services', '/backends/*', '/services/{serviceName}');
 
   const { exactStart, exactEnd } = useTimeRange({
     rangeFrom,

x-pack/plugins/apm/public/hooks/use_apm_params.ts

@@ -4,42 +4,29 @@
  * 2.0; you may not use this file except in compliance with the Elastic License
  * 2.0.
  */
-
+import { ValuesType } from 'utility-types';
 import { TypeOf, PathsOf, useParams } from '@kbn/typed-react-router-config';
 import { ApmRoutes } from '../components/routing/apm_route_config';
 
-export function useApmParams<TPath extends PathsOf<ApmRoutes>>(
+// these three different functions exist purely to speed up completions from
+// TypeScript. One overloaded function is expensive because of the size of the
+// union type that is created.
+
+export function useMaybeApmParams<TPath extends PathsOf<ApmRoutes>>(
   path: TPath,
   optional: true
-): TypeOf<ApmRoutes, TPath> | undefined;
+): TypeOf<ApmRoutes, TPath> | undefined {
+  return useParams(path, optional);
+}
 
 export function useApmParams<TPath extends PathsOf<ApmRoutes>>(
   path: TPath
-): TypeOf<ApmRoutes, TPath>;
+): TypeOf<ApmRoutes, TPath> {
-
+  return useParams(path)!;
-export function useApmParams<
+}
-  TPath1 extends PathsOf<ApmRoutes>,
+
-  TPath2 extends PathsOf<ApmRoutes>
+export function useAnyOfApmParams<TPaths extends Array<PathsOf<ApmRoutes>>>(
->(
+  ...paths: TPaths
-  path1: TPath1,
+): TypeOf<ApmRoutes, ValuesType<TPaths>> {
-  path2: TPath2
+  return useParams(...paths)!;
-): TypeOf<ApmRoutes, TPath1> | TypeOf<ApmRoutes, TPath2>;
-
-export function useApmParams<
-  TPath1 extends PathsOf<ApmRoutes>,
-  TPath2 extends PathsOf<ApmRoutes>,
-  TPath3 extends PathsOf<ApmRoutes>
->(
-  path1: TPath1,
-  path2: TPath2,
-  path3: TPath3
-):
-  | TypeOf<ApmRoutes, TPath1>
-  | TypeOf<ApmRoutes, TPath2>
-  | TypeOf<ApmRoutes, TPath3>;
-
-export function useApmParams(
-  ...args: any[]
-): TypeOf<ApmRoutes, PathsOf<ApmRoutes>> | undefined {
-  return useParams(...args);
 }

x-pack/plugins/apm/public/hooks/use_apm_router.ts

@@ -14,6 +14,8 @@ export function useApmRouter() {
   const { core } = useApmPluginContext();
 
   const link = (...args: [any]) => {
+    // @ts-expect-error router.link() expects never type, because
+    // no routes are specified. that's okay.
     return core.http.basePath.prepend('/app/apm' + router.link(...args));
   };
 

x-pack/plugins/apm/server/routes/errors/get_error_groups/get_error_group_main_statistics.ts

@@ -110,7 +110,6 @@ export async function getErrorGroupMainStatistics({
   );
 
   return (
-    // @ts-ignore 4.3.5 upgrade - Expression produces a union type that is too complex to represent. ts(2590)
     response.aggregations?.error_groups.buckets.map((bucket) => ({
       groupId: bucket.key as string,
       name: getErrorName(bucket.sample.hits.hits[0]._source),

x-pack/plugins/apm/server/routes/service_map/get_service_anomalies.ts

@@ -120,7 +120,6 @@ export async function getServiceAnomalies({
     const relevantBuckets = uniqBy(
       sortBy(
         // make sure we only return data for jobs that are available in this space
-        // @ts-ignore 4.3.5 upgrade
         typedAnomalyResponse.aggregations?.services.buckets.filter((bucket) =>
           jobIds.includes(bucket.key.jobId as string)
         ) ?? [],

x-pack/plugins/apm/server/routes/services/get_service_instances/get_service_instances_transaction_statistics.ts

@@ -168,7 +168,6 @@ export async function getServiceInstancesTransactionStatistics<
           const { timeseries } = serviceNodeBucket;
           return {
             serviceNodeName,
-            // @ts-ignore 4.3.5 upgrade - Expression produces a union type that is too complex to represent.
             errorRate: timeseries.buckets.map((dateBucket) => ({
               x: dateBucket.key,
               y: dateBucket.failures.doc_count / dateBucket.doc_count,

x-pack/plugins/security_solution/server/lib/detection_engine/routes/signals/query_signals_route.test.ts

@@ -27,7 +27,6 @@ describe('query for signal', () => {
     server = serverMock.create();
     ({ context } = requestContextMock.createTools());
 
-    // @ts-expect-error 4.3.5 upgrade
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     ruleDataClient.getReader().search.mockResolvedValue(getEmptySignalsResponse() as any);