mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 17:28:26 -04:00
# Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move `CodeEditor` related packages #205587 (#205738)](https://github.com/elastic/kibana/pull/205738) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-01-08T14:25:47Z","message":"Sustainable Kibana Architecture: Move `CodeEditor` related packages #205587 (#205738)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve merge conflicts? Please follow\r\nthe steps describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n#### 3 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/code-editor` |\r\n`src/platform/packages/shared/shared-ux/code_editor/impl` |\r\n| `@kbn/code-editor-mock` |\r\n`src/platform/packages/shared/shared-ux/code_editor/mocks` |\r\n| `@kbn/monaco` | `src/platform/packages/shared/kbn-monaco` |\r\n\r\n\r\n<details >\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-monaco/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-monaco/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-monaco/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/jest.config.js:12\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:16\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:18\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:25\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:28\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:31\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:34\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:37\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:40\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:16\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:18\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:25\r\n```\r\n\r\n</details>","sha":"3b2ab7b4134c05c00a74a70d7905f6b06e1364c1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","plugin groups"],"number":205738,"url":"https://github.com/elastic/kibana/pull/205738","mergeCommit":{"message":"Sustainable Kibana Architecture: Move `CodeEditor` related packages #205587 (#205738)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve merge conflicts? Please follow\r\nthe steps describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n#### 3 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/code-editor` |\r\n`src/platform/packages/shared/shared-ux/code_editor/impl` |\r\n| `@kbn/code-editor-mock` |\r\n`src/platform/packages/shared/shared-ux/code_editor/mocks` |\r\n| `@kbn/monaco` | `src/platform/packages/shared/kbn-monaco` |\r\n\r\n\r\n<details >\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-monaco/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-monaco/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-monaco/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/jest.config.js:12\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:16\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:18\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:25\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:28\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:31\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:34\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:37\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:40\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:16\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:18\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:25\r\n```\r\n\r\n</details>","sha":"3b2ab7b4134c05c00a74a70d7905f6b06e1364c1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205738","number":205738,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move `CodeEditor` related packages #205587 (#205738)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve merge conflicts? Please follow\r\nthe steps describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n#### 3 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/code-editor` |\r\n`src/platform/packages/shared/shared-ux/code_editor/impl` |\r\n| `@kbn/code-editor-mock` |\r\n`src/platform/packages/shared/shared-ux/code_editor/mocks` |\r\n| `@kbn/monaco` | `src/platform/packages/shared/kbn-monaco` |\r\n\r\n\r\n<details >\r\n<summary>Updated relative paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-monaco/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-monaco/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-monaco/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/jest.config.js:12\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:16\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:18\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:25\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:28\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:31\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:34\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:37\r\nsrc/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:40\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:16\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:18\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:2\r\nsrc/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:25\r\n```\r\n\r\n</details>","sha":"3b2ab7b4134c05c00a74a70d7905f6b06e1364c1"}}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
parent
d8aefa7172
commit
5cd26eef91
209 changed files with 37 additions and 37 deletions
|
@ -38,7 +38,7 @@ snapshots.js
|
|||
/packages/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/
|
||||
/packages/kbn-ui-framework/dist
|
||||
/packages/kbn-flot-charts/lib
|
||||
/packages/kbn-monaco/src/**/antlr
|
||||
/src/platform/packages/shared/kbn-monaco/src/**/antlr
|
||||
/src/platform/packages/shared/kbn-esql-ast/src/**/antlr
|
||||
|
||||
# Bazel
|
||||
|
|
6
.github/CODEOWNERS
vendored
6
.github/CODEOWNERS
vendored
|
@ -95,8 +95,8 @@ x-pack/solutions/security/packages/kbn-cloud-security-posture/public @elastic/ki
|
|||
x-pack/platform/packages/shared/kbn-cloud-security-posture/common @elastic/kibana-cloud-security-posture
|
||||
x-pack/solutions/security/packages/kbn-cloud-security-posture/graph @elastic/kibana-cloud-security-posture
|
||||
x-pack/solutions/security/plugins/cloud_security_posture @elastic/kibana-cloud-security-posture
|
||||
packages/shared-ux/code_editor/impl @elastic/appex-sharedux
|
||||
packages/shared-ux/code_editor/mocks @elastic/appex-sharedux
|
||||
src/platform/packages/shared/shared-ux/code_editor/impl @elastic/appex-sharedux
|
||||
src/platform/packages/shared/shared-ux/code_editor/mocks @elastic/appex-sharedux
|
||||
packages/kbn-code-owners @elastic/appex-qa
|
||||
packages/kbn-coloring @elastic/kibana-visualizations
|
||||
src/platform/packages/shared/kbn-config @elastic/kibana-core
|
||||
|
@ -650,7 +650,7 @@ x-pack/platform/packages/private/ml/url_state @elastic/ml-ui
|
|||
x-pack/platform/packages/private/ml/validators @elastic/ml-ui
|
||||
packages/kbn-mock-idp-plugin @elastic/kibana-security
|
||||
packages/kbn-mock-idp-utils @elastic/kibana-security
|
||||
packages/kbn-monaco @elastic/appex-sharedux
|
||||
src/platform/packages/shared/kbn-monaco @elastic/appex-sharedux
|
||||
x-pack/platform/plugins/private/monitoring_collection @elastic/stack-monitoring
|
||||
x-pack/platform/plugins/private/monitoring @elastic/stack-monitoring
|
||||
src/platform/plugins/shared/navigation @elastic/appex-sharedux
|
||||
|
|
|
@ -95,7 +95,7 @@
|
|||
"src/platform/packages/shared/kbn-management",
|
||||
"packages/kbn-management"
|
||||
],
|
||||
"monaco": "packages/kbn-monaco/src",
|
||||
"monaco": "src/platform/packages/shared/kbn-monaco/src",
|
||||
"navigation": ["src/platform/plugins/shared/navigation", "packages/solution-nav"],
|
||||
"links": "src/platform/plugins/private/links",
|
||||
"newsfeed": "src/platform/plugins/shared/newsfeed",
|
||||
|
|
|
@ -22,7 +22,7 @@ const BAZEL_RUNNER_SRC = '../../../packages/kbn-bazel-runner/index.js';
|
|||
const BAZEL_TARGETS = [
|
||||
'//src/platform/packages/private/kbn-ui-shared-deps-npm:shared_built_assets',
|
||||
'//src/platform/packages/private/kbn-ui-shared-deps-src:shared_built_assets',
|
||||
'//packages/kbn-monaco:target_workers',
|
||||
'//src/platform/packages/shared/kbn-monaco:target_workers',
|
||||
];
|
||||
|
||||
async function getBazelRunner() {
|
||||
|
|
|
@ -221,8 +221,8 @@
|
|||
"@kbn/cloud-security-posture-common": "link:x-pack/platform/packages/shared/kbn-cloud-security-posture/common",
|
||||
"@kbn/cloud-security-posture-graph": "link:x-pack/solutions/security/packages/kbn-cloud-security-posture/graph",
|
||||
"@kbn/cloud-security-posture-plugin": "link:x-pack/solutions/security/plugins/cloud_security_posture",
|
||||
"@kbn/code-editor": "link:packages/shared-ux/code_editor/impl",
|
||||
"@kbn/code-editor-mock": "link:packages/shared-ux/code_editor/mocks",
|
||||
"@kbn/code-editor": "link:src/platform/packages/shared/shared-ux/code_editor/impl",
|
||||
"@kbn/code-editor-mock": "link:src/platform/packages/shared/shared-ux/code_editor/mocks",
|
||||
"@kbn/coloring": "link:packages/kbn-coloring",
|
||||
"@kbn/config": "link:src/platform/packages/shared/kbn-config",
|
||||
"@kbn/config-mocks": "link:src/platform/packages/private/kbn-config-mocks",
|
||||
|
@ -679,7 +679,7 @@
|
|||
"@kbn/ml-ui-actions": "link:x-pack/platform/packages/private/ml/ui_actions",
|
||||
"@kbn/ml-url-state": "link:x-pack/platform/packages/private/ml/url_state",
|
||||
"@kbn/ml-validators": "link:x-pack/platform/packages/private/ml/validators",
|
||||
"@kbn/monaco": "link:packages/kbn-monaco",
|
||||
"@kbn/monaco": "link:src/platform/packages/shared/kbn-monaco",
|
||||
"@kbn/monitoring-collection-plugin": "link:x-pack/platform/plugins/private/monitoring_collection",
|
||||
"@kbn/monitoring-plugin": "link:x-pack/platform/plugins/private/monitoring",
|
||||
"@kbn/navigation-plugin": "link:src/platform/plugins/shared/navigation",
|
||||
|
|
|
@ -19,7 +19,7 @@ export async function buildBazelPackages({ log, dist }: TaskContext) {
|
|||
'build',
|
||||
'//src/platform/packages/private/kbn-ui-shared-deps-npm:shared_built_assets',
|
||||
'//src/platform/packages/private/kbn-ui-shared-deps-src:shared_built_assets',
|
||||
'//packages/kbn-monaco:target_workers',
|
||||
'//src/platform/packages/shared/kbn-monaco:target_workers',
|
||||
'--show_result=1',
|
||||
].concat(dist ? [`--define=dist=true`] : []),
|
||||
{
|
||||
|
|
|
@ -111,7 +111,7 @@ export const BuildPackages: Task = {
|
|||
'build',
|
||||
'//src/platform/packages/private/kbn-ui-shared-deps-npm:shared_built_assets',
|
||||
'//src/platform/packages/private/kbn-ui-shared-deps-src:shared_built_assets',
|
||||
'//packages/kbn-monaco:target_workers',
|
||||
'//src/platform/packages/shared/kbn-monaco:target_workers',
|
||||
'--show_result=1',
|
||||
'--define=dist=true',
|
||||
],
|
||||
|
|
|
@ -6,7 +6,7 @@ Contains the editor for text based languages. Specifically for:
|
|||
---
|
||||
|
||||
Contains the ESQL editor with the autocomplete and the autosuggest functionality (based on atlr).
|
||||
The antlr code can be found in packages/kbn-monaco/src/esql
|
||||
The antlr code can be found in src/platform/packages/shared/kbn-monaco/src/esql
|
||||
|
||||
A **monaco** based editor that is part of the unified search experience. It is rendered for all the applications that support text-based languages.
|
||||
In order to enable text based languages on your unified search bar add `textBasedLanguages: ['ESQL', '...']` to the dataViewPicker properties.
|
||||
|
|
|
@ -26,7 +26,7 @@ webpack_cli(
|
|||
"//src/platform/packages/shared/kbn-i18n-react",
|
||||
"//src/platform/packages/shared/kbn-ebt-tools",
|
||||
"//src/platform/packages/shared/kbn-esql-ast",
|
||||
"//packages/kbn-monaco",
|
||||
"//src/platform/packages/shared/kbn-monaco",
|
||||
"//src/platform/packages/shared/kbn-datemath",
|
||||
"//src/platform/packages/shared/kbn-analytics",
|
||||
"//src/platform/packages/shared/kbn-crypto-browser",
|
||||
|
@ -38,7 +38,7 @@ webpack_cli(
|
|||
"//packages/kbn-peggy-loader",
|
||||
"//src/platform/packages/shared/shared-ux/error_boundary",
|
||||
"//src/platform/packages/shared/kbn-rison",
|
||||
"//packages/shared-ux/code_editor/impl:code_editor",
|
||||
"//src/platform/packages/shared/shared-ux/code_editor/impl:code_editor",
|
||||
"//packages/react/kibana_context/common",
|
||||
"//packages/react/kibana_context/root",
|
||||
"//packages/react/kibana_context/render",
|
||||
|
|
|
@ -9,6 +9,6 @@
|
|||
|
||||
module.exports = {
|
||||
preset: '@kbn/test',
|
||||
rootDir: '../..',
|
||||
roots: ['<rootDir>/packages/kbn-monaco'],
|
||||
rootDir: '../../../../..',
|
||||
roots: ['<rootDir>/src/platform/packages/shared/kbn-monaco'],
|
||||
};
|
|
@ -43,7 +43,7 @@ describe('ESQL Theme', () => {
|
|||
const theme = buildESQLTheme({ darkMode: false });
|
||||
|
||||
// These names aren't from the lexer... they are added on our side
|
||||
// see packages/kbn-monaco/src/esql/lib/esql_token_helpers.ts
|
||||
// see src/platform/packages/shared/kbn-monaco/src/esql/lib/esql_token_helpers.ts
|
||||
const syntheticNames = ['functions', 'nulls_order', 'timespan_literal'];
|
||||
|
||||
const rulesWithNoName: string[] = [];
|
Some files were not shown because too many files have changed in this diff Show more
Loading…
Add table
Add a link
Reference in a new issue