github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[server/csrf] don't tack helper methods onto kbnServer

Browse source
This commit is contained in:
spalger 2015-11-09 23:06:06 -06:00
parent 6892b4acc9
commit 5cdeae5fb4
1 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/server/http/__tests__/xsrf.js
View file

@ -9,6 +9,14 @@ const destructiveMethods = ['POST', 'PUT', 'DELETE'];
const src = resolve.bind(null, __dirname, '../../../../src');
describe('xsrf request filter', function () {
function inject(kbnServer, opts) {
return fn(cb => {
kbnServer.server.inject(opts, (resp) => {
cb(null, resp);
});
});
}
async function makeServer(token) {
const kbnServer = new KbnServer({
server: { autoListen: false, xsrf: { token } },
@ -27,14 +35,6 @@ describe('xsrf request filter', function () {
}
});
kbnServer.inject = function (opts) {
return fn(cb => {
kbnServer.server.inject(opts, (resp) => {
cb(null, resp);
});
});
};
return kbnServer;
}
@ -45,7 +45,7 @@ describe('xsrf request filter', function () {
afterEach(async () => await kbnServer.close());
it('sends a token when rendering an app', async function () {
var resp = await kbnServer.inject({
var resp = await inject(kbnServer, {
method: 'GET',
url: '/app/kibana',
});
@ -60,7 +60,7 @@ describe('xsrf request filter', function () {
afterEach(async () => await kbnServer.close());
it('responds with a random token', async function () {
var resp = await kbnServer.inject({
var resp = await inject(kbnServer, {
method: 'GET',
url: '/app/kibana',
});
@ -78,7 +78,7 @@ describe('xsrf request filter', function () {
for (const method of nonDestructiveMethods) {
context(`nonDestructiveMethod: ${method}`, function () { // eslint-disable-line no-loop-func
it('accepts requests without a token', async function () {
const resp = await kbnServer.inject({
const resp = await inject(kbnServer, {
url: '/xsrf/test/route',
method: method
});
@ -88,7 +88,7 @@ describe('xsrf request filter', function () {
});
it('ignores invalid tokens', async function () {
const resp = await kbnServer.inject({
const resp = await inject(kbnServer, {
url: '/xsrf/test/route',
method: method,
headers: {
@ -105,7 +105,7 @@ describe('xsrf request filter', function () {
for (const method of destructiveMethods) {
context(`destructiveMethod: ${method}`, function () { // eslint-disable-line no-loop-func
it('accepts requests with the correct token', async function () {
const resp = await kbnServer.inject({
const resp = await inject(kbnServer, {
url: '/xsrf/test/route',
method: method,
headers: {
@ -118,7 +118,7 @@ describe('xsrf request filter', function () {
});
it('rejects requests without a token', async function () {
const resp = await kbnServer.inject({
const resp = await inject(kbnServer, {
url: '/xsrf/test/route',
method: method
});
@ -128,7 +128,7 @@ describe('xsrf request filter', function () {
});
it('rejects requests with an invalid token', async function () {
const resp = await kbnServer.inject({
const resp = await inject(kbnServer, {
url: '/xsrf/test/route',
method: method,
headers: {