github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix spaces test flakyness (#100605)

Browse source
This commit is contained in:
Larry Gregory 2021-05-26 06:47:28 -04:00 • committed by GitHub
parent 93acfb4d43
commit 5d5cc55b3a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
x-pack/plugins/spaces/public/nav_control/nav_control_popover.tsx
View file

@ -71,9 +71,6 @@ export class NavControlPopover extends Component<Props, State> {
public render() {
const button = this.getActiveSpaceButton();
if (!button) {
return null;
}
let element: React.ReactNode;
if (!this.state.loading && this.state.spaces.length < 2) {
@ -102,7 +99,7 @@ export class NavControlPopover extends Component<Props, State> {
return (
<EuiPopover
id={'spcMenuPopover'}
data-test-subj={`spacesNavSelector`}
data-test-subj={`${this.state.loading ? 'spacesNavSelectorLoading' : 'spacesNavSelector'}`}
button={button}
isOpen={this.state.showSpaceSelector}
closePopover={this.closeSpaceSelector}

3
x-pack/test/functional/apps/spaces/enter_space.ts
View file

@ -14,8 +14,7 @@ export default function enterSpaceFunctonalTests({
const esArchiver = getService('esArchiver');
const PageObjects = getPageObjects(['security', 'spaceSelector']);
// FLAKY: https://github.com/elastic/kibana/issues/100012
describe.skip('Enter Space', function () {
describe('Enter Space', function () {
this.tags('includeFirefox');
before(async () => {
await esArchiver.load('spaces/enter_space');

3
x-pack/test/functional/apps/spaces/spaces_selection.ts
View file

@ -22,8 +22,7 @@ export default function spaceSelectorFunctionalTests({
'spaceSelector',
]);
// FLAKY: https://github.com/elastic/kibana/issues/99581
describe.skip('Spaces', function () {
describe('Spaces', function () {
this.tags('includeFirefox');
describe('Space Selector', () => {
before(async () => {