mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
[8.x] [Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726) (#208796)
# Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726)](https://github.com/elastic/kibana/pull/208726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-01-29T16:35:52Z","message":"[Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208304 !!\r\n\r\nFix ping heatmap regression when Inspect flag is turned off !!\r\n\r\nThis flag is turned on auto in dev which caused an issue !!\r\n\r\nTo reproduce the step, you can turn off the inspect flag in dev mode by\r\nremoving `this.isDev `from this condition\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/synthetics/server/lib.ts#L93\r\n\r\n### After\r\n\r\n<img width=\"1726\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ad786351-37e4-4c18-b68e-695880d836e9\"\r\n/>","sha":"557cac273c70bced82f961148c4f4f86ccda0580","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","Team:obs-ux-management","backport:version"],"title":"[Synthetics] Fix ping heatmap regression when Inspect flag is turned off !!","number":208726,"url":"https://github.com/elastic/kibana/pull/208726","mergeCommit":{"message":"[Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208304 !!\r\n\r\nFix ping heatmap regression when Inspect flag is turned off !!\r\n\r\nThis flag is turned on auto in dev which caused an issue !!\r\n\r\nTo reproduce the step, you can turn off the inspect flag in dev mode by\r\nremoving `this.isDev `from this condition\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/synthetics/server/lib.ts#L93\r\n\r\n### After\r\n\r\n<img width=\"1726\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ad786351-37e4-4c18-b68e-695880d836e9\"\r\n/>","sha":"557cac273c70bced82f961148c4f4f86ccda0580"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208726","number":208726,"mergeCommit":{"message":"[Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208304 !!\r\n\r\nFix ping heatmap regression when Inspect flag is turned off !!\r\n\r\nThis flag is turned on auto in dev which caused an issue !!\r\n\r\nTo reproduce the step, you can turn off the inspect flag in dev mode by\r\nremoving `this.isDev `from this condition\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/synthetics/server/lib.ts#L93\r\n\r\n### After\r\n\r\n<img width=\"1726\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ad786351-37e4-4c18-b68e-695880d836e9\"\r\n/>","sha":"557cac273c70bced82f961148c4f4f86ccda0580"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This commit is contained in:
parent
01b15a5f58
commit
5d715adc61
1 changed files with 2 additions and 2 deletions
|
@ -26,7 +26,7 @@ export const syntheticsGetPingHeatmapRoute: SyntheticsRestApiRouteFactory = () =
|
|||
handler: async ({
|
||||
syntheticsEsClient,
|
||||
request,
|
||||
}): Promise<MonitorStatusHeatmapBucket[] | undefined> => {
|
||||
}): Promise<{ result: MonitorStatusHeatmapBucket[] } | undefined> => {
|
||||
const { from, to, interval: intervalInMinutes, monitorId, location } = request.query;
|
||||
|
||||
const result = await queryMonitorHeatmap({
|
||||
|
@ -38,6 +38,6 @@ export const syntheticsGetPingHeatmapRoute: SyntheticsRestApiRouteFactory = () =
|
|||
intervalInMinutes,
|
||||
});
|
||||
|
||||
return result.body.aggregations?.heatmap?.buckets as MonitorStatusHeatmapBucket[];
|
||||
return { result: result.body.aggregations?.heatmap?.buckets as MonitorStatusHeatmapBucket[] };
|
||||
},
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue