github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

clear selection in autocomplete field component when user types

Browse source
This commit is contained in:
Gergő Ábrahám 2024-09-05 10:56:39 +02:00
parent 8198dc84b5
commit 5da28aa254
2 changed files with 49 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

35
packages/kbn-securitysolution-autocomplete/src/field_value_match/index.test.tsx
View file

@ -230,6 +230,38 @@ describe('AutocompleteFieldMatchComponent', () => {
expect(mockOnChange).toHaveBeenCalledWith('value 1');
});
test('it invokes "onChange" with empty value (i.e. clears selection) when new value searched', async () => {
const mockOnChange = jest.fn();
wrapper = mount(
<AutocompleteFieldMatchComponent
autocompleteService={autocompleteStartMock}
indexPattern={{
fields,
id: '1234',
title: 'logstash-*',
}}
isClearable={false}
isDisabled={false}
isLoading={false}
onChange={mockOnChange}
onError={jest.fn()}
placeholder="Placeholder text"
selectedField={getField('machine.os.raw')}
selectedValue="value 1"
/>
);
act(() => {
(
wrapper.find(EuiComboBox).props() as unknown as {
onSearchChange: (a: string) => void;
}
).onSearchChange('value 12');
});
expect(mockOnChange).toHaveBeenCalledWith('');
});
test('should show the warning helper text if the new value contains spaces when change', async () => {
(useFieldValueAutocomplete as jest.Mock).mockReturnValue([
false,
@ -312,6 +344,7 @@ describe('AutocompleteFieldMatchComponent', () => {
selectedField: getField('machine.os.raw'),
});
});
test('should show the warning helper text if the new value contains spaces when searching a new query', () => {
wrapper = mount(
<AutocompleteFieldMatchComponent
@ -344,6 +377,7 @@ describe('AutocompleteFieldMatchComponent', () => {
expect(euiFormHelptext.length).toBeTruthy();
expect(euiFormHelptext.text()).toEqual('Warning: there is a space');
});
test('should show the warning helper text if selectedValue contains spaces when editing', () => {
wrapper = mount(
<AutocompleteFieldMatchComponent
@ -367,6 +401,7 @@ describe('AutocompleteFieldMatchComponent', () => {
expect(euiFormHelptext.length).toBeTruthy();
expect(euiFormHelptext.text()).toEqual('Warning: there is a space');
});
test('should not show the warning helper text if selectedValue is falsy', () => {
wrapper = mount(
<AutocompleteFieldMatchComponent

15
packages/kbn-securitysolution-autocomplete/src/field_value_match/index.tsx
View file

@ -169,8 +169,21 @@ export const AutocompleteFieldMatchComponent: React.FC<AutocompleteFieldMatchPro
if (!err) handleSpacesWarning(searchVal);
setSearchQuery(searchVal);
}
if (searchVal) {
onChange('');
}
},
[handleError, handleSpacesWarning, isRequired, selectedField, touched, handleWarning, warning]
[
selectedField,
onChange,
isRequired,
touched,
handleError,
handleWarning,
warning,
handleSpacesWarning,
]
);
const handleCreateOption = useCallback(