github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[APM] Unskip APM alerting tests (#188006)

Browse source 
fixes [#176948](https://github.com/elastic/kibana/issues/176948)
fixes [#177061](https://github.com/elastic/kibana/issues/177061)
fixes [#177104](https://github.com/elastic/kibana/issues/177104)

## Summary

I managed to reproduce the problem when `error_grouping_key` was null.
It was probably fixed here https://github.com/elastic/kibana/pull/184642


https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6512

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Carlos Crespo 2024-07-11 13:30:35 +02:00 • committed by GitHub
parent 976fed697d
commit 5df7bb87c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
x-pack/test/apm_api_integration/tests/alerts/error_count_threshold.spec.ts
View file

@ -103,8 +103,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
after(() => apmSynthtraceEsClient.clean());
// FLAKY: https://github.com/elastic/kibana/issues/176948
describe.skip('create rule without kql filter', () => {
describe('create rule without kql filter', () => {
let ruleId: string;
let alerts: ApmAlertFields[];
let actionId: string;
@ -175,10 +174,10 @@ export default function ApiTest({ getService }: FtrProviderContext) {
environment: 'production',
interval: '1 hr',
reason:
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: c85df8159a74b47b461d6ddaa6ba7da38cfc3e74019aef66257d10df74adeb99, error name: a php error. Alert when > 1.',
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: 000000000000000000000a php error, error name: a php error. Alert when > 1.',
serviceName: 'opbeans-php',
transactionName: 'tx-php',
errorGroupingKey: 'c85df8159a74b47b461d6ddaa6ba7da38cfc3e74019aef66257d10df74adeb99',
errorGroupingKey: '000000000000000000000a php error',
errorGroupingName: 'a php error',
threshold: '1',
triggerValue: '30',
@ -192,8 +191,8 @@ export default function ApiTest({ getService }: FtrProviderContext) {
const alertReasons = [alerts[0]['kibana.alert.reason'], alerts[1]['kibana.alert.reason']];
expect(alertReasons).to.eql([
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: c85df8159a74b47b461d6ddaa6ba7da38cfc3e74019aef66257d10df74adeb99, error name: a php error. Alert when > 1.',
'Error count is 15 in the last 1 hr for service: opbeans-java, env: production, name: tx-java, error key: b6a4ac83620b34ae44dd98a13e144782f88698f827af7edb10690c5e6e7d8597, error name: a java error. Alert when > 1.',
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: 000000000000000000000a php error, error name: a php error. Alert when > 1.',
'Error count is 15 in the last 1 hr for service: opbeans-java, env: production, name: tx-java, error key: 00000000000000000000a java error, error name: a java error. Alert when > 1.',
]);
});
@ -252,8 +251,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});
// FLAKY: https://github.com/elastic/kibana/issues/176964
describe.skip('create rule with kql filter for opbeans-php', () => {
describe('create rule with kql filter for opbeans-php', () => {
let ruleId: string;
before(async () => {

6
x-pack/test/apm_api_integration/tests/alerts/transaction_duration.spec.ts
View file

@ -75,8 +75,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
await apmSynthtraceEsClient.clean();
});
// FLAKY: https://github.com/elastic/kibana/issues/176996
describe.skip('create rule for opbeans-java without kql filter', () => {
describe('create rule for opbeans-java without kql filter', () => {
let ruleId: string;
let actionId: string;
let alerts: ApmAlertFields[];
@ -188,8 +187,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});
// FLAKY: https://github.com/elastic/kibana/issues/177061
describe.skip('create rule for opbeans-node using kql filter', () => {
describe('create rule for opbeans-node using kql filter', () => {
let ruleId: string;
let alerts: ApmAlertFields[];

2
x-pack/test/apm_api_integration/tests/alerts/transaction_error_rate.spec.ts
View file

@ -73,7 +73,6 @@ export default function ApiTest({ getService }: FtrProviderContext) {
await apmSynthtraceEsClient.clean();
});
// FLAKY: https://github.com/elastic/kibana/issues/177104
describe('create rule without kql query', () => {
let ruleId: string;
let actionId: string;
@ -197,7 +196,6 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});
// FLAKY: https://github.com/elastic/kibana/issues/177108
describe('create rule with kql query', () => {
let ruleId: string;
let alerts: ApmAlertFields[];