github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[APM]Latency threshold rule's threshold context variable should use milliseconds instead of microseconds (#150234)

Browse source 
closes https://github.com/elastic/kibana/issues/125323

I couldn't test it yet, since alerts are firing with any context
variable. I'll hold on to merge this until I can fully test it.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Cauê Marcondes 2023-02-08 11:26:10 -05:00 • committed by GitHub
parent f935d066f6
commit 5f43b49df3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/apm/server/routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.test.ts
View file

@ -65,7 +65,7 @@ describe('registerTransactionDurationRuleType', () => {
'Avg. latency is 5,500 ms in the last 5 mins for opbeans-java. Alert when > 3,000 ms.',
transactionType: 'request',
serviceName: 'opbeans-java',
threshold: 3000000,
threshold: 3000,
triggerValue: '5,500 ms',
viewInAppUrl:
'http://localhost:5601/eyr/app/apm/services/opbeans-java?transactionType=request&environment=ENVIRONMENT_ALL',

4
x-pack/plugins/apm/server/routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts
View file

@ -281,7 +281,7 @@ export function registerTransactionDurationRuleType({
[TRANSACTION_TYPE]: transactionType,
[PROCESSOR_EVENT]: ProcessorEvent.transaction,
[ALERT_EVALUATION_VALUE]: transactionDuration,
[ALERT_EVALUATION_THRESHOLD]: thresholdMicroseconds,
[ALERT_EVALUATION_THRESHOLD]: ruleParams.threshold,
[ALERT_REASON]: reason,
...sourceFields,
},
@ -292,7 +292,7 @@ export function registerTransactionDurationRuleType({
interval: `${ruleParams.windowSize}${ruleParams.windowUnit}`,
reason,
serviceName,
threshold: thresholdMicroseconds,
threshold: ruleParams.threshold,
transactionType,
triggerValue: transactionDurationFormatted,
viewInAppUrl,