github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.x] [ES|QL] capitalize `FROM` in recommended queries (#205122) (#205352)

Browse source 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] capitalize `FROM` in recommended queries
(#205122)](https://github.com/elastic/kibana/pull/205122)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-01-02T08:30:42Z","message":"[ES|QL]
capitalize `FROM` in recommended queries (#205122)\n\n##
Summary\r\n\r\n`FROM` wasn't capitalized when selected from the
menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow
it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"title":"[ES|QL]
capitalize `FROM` in recommended
queries","number":205122,"url":"https://github.com/elastic/kibana/pull/205122","mergeCommit":{"message":"[ES|QL]
capitalize `FROM` in recommended queries (#205122)\n\n##
Summary\r\n\r\n`FROM` wasn't capitalized when selected from the
menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow
it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205122","number":205122,"mergeCommit":{"message":"[ES|QL]
capitalize `FROM` in recommended queries (#205122)\n\n##
Summary\r\n\r\n`FROM` wasn't capitalized when selected from the
menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow
it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<efstratia.kalafateli@elastic.co>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Drew Tate <drew.tate@elastic.co>
This commit is contained in:
Kibana Machine 2025-01-02 21:27:03 +11:00 • committed by GitHub
parent 60d378b893
commit 5fd44674f7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
NOTICE.txt
View file

@ -1,5 +1,5 @@
Kibana source code with Kibana X-Pack source code
Copyright 2012-2024 Elasticsearch B.V.
Copyright 2012-2025 Elasticsearch B.V.
---
Adapted from remote-web-worker, which was available under a "MIT" license.

2
src/plugins/unified_search/public/query_string_input/esql_menu_popover.tsx
View file

@ -56,7 +56,7 @@ export const ESQLMenuPopover: React.FC<ESQLMenuPopoverProps> = ({
const esqlContextMenuPanels = useMemo(() => {
const recommendedQueries = [];
if (adHocDataview && typeof adHocDataview !== 'string') {
const queryString = `from ${adHocDataview.name}`;
const queryString = `FROM ${adHocDataview.name}`;
const timeFieldName =
adHocDataview.timeFieldName ?? adHocDataview.fields?.getByType('date')?.[0]?.name;