github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.6] [Security Solution]: List details page fix Linked Rules max height (#147039) (#147054)

Browse source 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution]: List details page fix Linked Rules max height
(#147039)](https://github.com/elastic/kibana/pull/147039)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Wafaa
Nasr","email":"wafaa.nasr@elastic.co"},"sourceCommit":{"committedDate":"2022-12-05T21:02:05Z","message":"[Security
Solution]: List details page fix Linked Rules max height (#147039)\n\n##
Summary\r\n\r\n- Applying a max-height to the `Linked Rules` combobox in
the List\r\nShared details as well as in the Add Exception
Items","sha":"81635fca7300ca81b9fc87c2c3a754e7851a5c30","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:cloud-deploy","v8.7.0"],"number":147039,"url":"https://github.com/elastic/kibana/pull/147039","mergeCommit":{"message":"[Security
Solution]: List details page fix Linked Rules max height (#147039)\n\n##
Summary\r\n\r\n- Applying a max-height to the `Linked Rules` combobox in
the List\r\nShared details as well as in the Add Exception
Items","sha":"81635fca7300ca81b9fc87c2c3a754e7851a5c30"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147039","number":147039,"mergeCommit":{"message":"[Security
Solution]: List details page fix Linked Rules max height (#147039)\n\n##
Summary\r\n\r\n- Applying a max-height to the `Linked Rules` combobox in
the List\r\nShared details as well as in the Add Exception
Items","sha":"81635fca7300ca81b9fc87c2c3a754e7851a5c30"}}]}] BACKPORT-->

Co-authored-by: Wafaa Nasr <wafaa.nasr@elastic.co>
This commit is contained in:
Kibana Machine 2022-12-05 17:37:45 -05:00 • committed by GitHub
parent 1c3951956d
commit 5fdada7819
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/kbn-securitysolution-exception-list-components/src/header_menu/__snapshots__/header_menu.test.tsx.snap generated
View file

@ -176,7 +176,7 @@ Object {
</p>
<div>
<div
class="euiContextMenuPanel"
class="euiContextMenuPanel eui-scrollBar css-zos0rl"
data-test-subj="MenuPanel"
tabindex="-1"
>

9
packages/kbn-securitysolution-exception-list-components/src/header_menu/index.tsx
View file

@ -20,6 +20,7 @@ import {
} from '@elastic/eui';
import { ButtonContentIconSide } from '@elastic/eui/src/components/button/_button_content_deprecated';
import { css } from '@emotion/react';
export interface Action {
key: string;
@ -42,6 +43,12 @@ interface HeaderMenuComponentProps {
panelPaddingSize?: PanelPaddingSize;
}
const popoverHeightStyle = css`
max-height: 300px;
height: 100%;
overflow-x: hidden;
overflow-y: auto;
`;
const HeaderMenuComponent: FC<HeaderMenuComponentProps> = ({
text,
dataTestSubj,
@ -114,6 +121,8 @@ const HeaderMenuComponent: FC<HeaderMenuComponentProps> = ({
>
{!itemActions ? null : (
<EuiContextMenuPanel
css={popoverHeightStyle}
className="eui-scrollBar"
data-test-subj={`${dataTestSubj || ''}MenuPanel`}
size="s"
items={itemActions as ReactElement[]}

2
packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap generated
View file

@ -1833,7 +1833,7 @@ Object {
</p>
<div>
<div
class="euiContextMenuPanel"
class="euiContextMenuPanel eui-scrollBar css-zos0rl"
data-test-subj="RightSideMenuItemsMenuActionsMenuPanel"
tabindex="-1"
>

4
packages/kbn-securitysolution-exception-list-components/src/list_header/menu_items/__snapshots__/menu_items.test.tsx.snap generated
View file

@ -499,7 +499,7 @@ Object {
</p>
<div>
<div
class="euiContextMenuPanel"
class="euiContextMenuPanel eui-scrollBar css-zos0rl"
data-test-subj="MenuActionsMenuPanel"
tabindex="-1"
>
@ -779,7 +779,7 @@ Object {
</p>
<div>
<div
class="euiContextMenuPanel"
class="euiContextMenuPanel eui-scrollBar css-zos0rl"
data-test-subj="MenuActionsMenuPanel"
tabindex="-1"
>