Fix bug in propFilter logic when it's not passed any filters. (#20569)

* Fix bug in propFilter logic when it's not passed any filters. Reduce lodash dependency.
* Default filters to empty array and add tests.

src/ui/public/filters/__tests__/prop_filter.js

@@ -44,6 +44,16 @@ describe('prop filter', function () {
     return objects;
   }
 
+  it('returns list when no filters are provided', function () {
+    const objects = getObjects('table', 'table', 'pie');
+    expect(nameFilter(objects)).to.eql(objects);
+  });
+
+  it('returns list when empty list of filters is provided', function () {
+    const objects = getObjects('table', 'table', 'pie');
+    expect(nameFilter(objects, [])).to.eql(objects);
+  });
+
   it('should keep only the tables', function () {
     const objects = getObjects('table', 'table', 'pie');
     expect(nameFilter(objects, 'table')).to.eql(getObjects('table', 'table'));
@@ -74,4 +84,10 @@ describe('prop filter', function () {
     const line = (value) => value === 'line';
     expect(nameFilter(objects, line)).to.eql(getObjects('line'));
   });
+
+  it('gracefully handles a filter function with zero arity', function () {
+    const objects = getObjects('table', 'line', 'pie');
+    const rejectEverything = () => false;
+    expect(nameFilter(objects, rejectEverything)).to.eql([]);
+  });
 });

src/ui/public/filters/_prop_filter.js

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash';
+import { isFunction } from 'lodash';
 
 /**
  * Filters out a list by a given filter. This is currently used to implement:
@@ -37,15 +37,22 @@ export function propFilter(prop) {
    *   - Can be also an array, a single value as a string, or a comma-separated list of items
    * @return {array} - the filtered list
    */
-  return function (list, filters) {
-    if (!filters) return filters;
-
-    if (_.isFunction(filters)) {
+  return function (list, filters = []) {
+    if (isFunction(filters)) {
       return list.filter((item) => filters(item[prop]));
     }
 
-    if (!Array.isArray(filters)) filters = filters.split(',');
-    if (_.contains(filters, '*')) return list;
+    if (!Array.isArray(filters)) {
+      filters = filters.split(',');
+    }
+
+    if (filters.length === 0) {
+      return list;
+    }
+
+    if (filters.includes('*')) {
+      return list;
+    }
 
     const options = filters.reduce(function (options, filter) {
       let type = 'include';
@@ -64,11 +71,15 @@ export function propFilter(prop) {
     return list.filter(function (item) {
       const value = item[prop];
 
-      const excluded = options.exclude && _.contains(options.exclude, value);
-      if (excluded) return false;
+      const excluded = options.exclude && options.exclude.includes(value);
+      if (excluded) {
+        return false;
+      }
 
-      const included = !options.include || _.contains(options.include, value);
-      if (included) return true;
+      const included = !options.include || options.include.includes(value);
+      if (included) {
+        return true;
+      }
 
       return false;
     });