attempted to squash all unescaped uri bugs. Fixes #137

src/kibana/apps/dashboard/partials/panel.html

@@ -2,7 +2,7 @@
   <div class="panel-heading">
     <span class="panel-title">{{vis.title}}</span>
     <div class="btn-group">
-	  <a ng-show="!appEmbedded" ng-href="#visualize/edit/{{vis.title}}"><i class="fa fa-pencil"></i></a>
+	  <a ng-show="!appEmbedded" ng-href="#visualize/edit/{{vis.title | uriescape}}"><i class="fa fa-pencil"></i></a>
       <a ng-show="!appEmbedded" ng-click="remove()"><i class="fa fa-times"></i></a>
     </div>
     <div class="clearfix"></div>

src/kibana/apps/dashboard/services/saved_dashboards.js

@@ -23,7 +23,7 @@ define(function (require) {
     };
 
     this.urlFor = function (id) {
-      return '#/dashboard/' + id;
+      return '#/dashboard/' + encodeURIComponent(id);
     };
 
     this.delete = function (ids) {

src/kibana/apps/discover/controllers/discover.js

@@ -217,7 +217,7 @@ define(function (require) {
         .then(function () {
           notify.info('Saved Data Source "' + savedSearch.title + '"');
           if (savedSearch.id !== $route.current.params.id) {
-            $location.url(globalState.writeToUrl('/discover/' + savedSearch.id));
+            $location.url(globalState.writeToUrl('/discover/' + encodeURIComponent(savedSearch.id)));
           }
         });
       })

src/kibana/apps/discover/partials/settings.html

@@ -3,7 +3,7 @@
     <div class="col-md-3">
       <label class="control-label">
         Index Pattern&nbsp;
-        <a class="small" ng-href="#/settings/indices/{{opts.index}}"><i class="fa fa-pencil"></i></a>
+        <a class="small" ng-href="#/settings/indices/{{opts.index | uriescape}}"><i class="fa fa-pencil"></i></a>
       </label>
       <select
         class="form-control"

src/kibana/apps/discover/saved_searches/saved_searches.js

@@ -27,7 +27,7 @@ define(function (require) {
     };
 
     this.urlFor = function (id) {
-      return '#/discover/' + id;
+      return '#/discover/' + encodeURIComponent(id);
     };
 
     this.delete = function (ids) {

src/kibana/apps/settings/sections/indices/index.js

@@ -31,7 +31,7 @@ define(function (require) {
             .map(function (id) {
               return {
                 id: id,
-                url: '#/settings/indices/' + id,
+                url: '#/settings/indices/' + encodeURIComponent(id),
                 class: 'sidebar-item-title ' + ($scope.edittingId === id ? 'active' : ''),
                 default: $scope.defaultIndex === id
               };

src/kibana/apps/settings/sections/objects/_objects.html

@@ -29,12 +29,19 @@
             <div class="pull-right">
               <a href="{{ item.url }}" class="btn-success btn btn-xs">View</a>
               &nbsp;
-              <a href="#/settings/objects/{{service.service}}/{{item.id}}" class="btn-primary btn btn-xs">Edit</a>
+              <a
+                href="#/settings/objects/{{service.service | uriescape}}/{{item.id | uriescape}}"
+                class="btn-primary btn btn-xs" >
+                Edit
+              </a>
             </div>
             <div class="pull-left">
-              <input type="checkbox" ng-click="item.checked = !item.checked; toggleDeleteBtn(service)" ng-checked="item.checked">
+              <input
+                ng-click="item.checked = !item.checked; toggleDeleteBtn(service)"
+                ng-checked="item.checked"
+                type="checkbox" >
             </div>
-            <a href="#/settings/objects/{{service.service}}/{{item.id}}"><i ng-class="item.icon" class="fa"></i>&nbsp;{{ item.title }}</a>
+            <a href="#/settings/objects/{{service.service | uriescape}}/{{item.id | uriescape}}"><i ng-class="item.icon" class="fa"></i>&nbsp;{{ item.title }}</a>
           </li>
           <li ng-if="!service.data.length" class="empty">No "{{service.title}}" found.</li>
         </ul>

src/kibana/apps/visualize/controllers/editor.js

@@ -174,7 +174,7 @@ define(function (require) {
       vis.save()
       .then(function () {
         if (vis.id !== $route.current.params.id) {
-          $location.url(globalState.writeToUrl('/visualize/edit/' + vis.id));
+          $location.url(globalState.writeToUrl('/visualize/edit/' + encodeURIComponent(vis.id)));
         }
         configTemplate.close('save');
       }, notify.fatal);

src/kibana/apps/visualize/editor.html

@@ -10,7 +10,11 @@
           class="bitty-modal visualize-linked">
           <i class="fa fa-link"></i>
           &nbsp;
-          This visualization is linked to a saved search: <b>{{ vis.savedSearchId | json}}</b> <a href="#/discover/{{ vis.savedSearchId | uriescape }}"><i class="fa fa-pencil" tooltip="Click here to edit the linked saved search"></i></a>
+          This visualization is linked to a saved search:
+          <b>{{ vis.savedSearchId | json}}</b>
+          <a href="#/discover/{{ vis.savedSearchId | uriescape }}">
+            <i class="fa fa-pencil" tooltip="Click here to edit the linked saved search"></i>
+          </a>
         </div>
 
         <div ng-if="linked && unlinking" ng-click="doneUnlinking()" class="bitty-modal">

src/kibana/apps/visualize/saved_visualizations/saved_visualizations.js

@@ -19,7 +19,7 @@ define(function (require) {
     };
 
     this.urlFor = function (id) {
-      return '#/visualize/edit/' + id;
+      return '#/visualize/edit/' + encodeURIComponent(id);
     };
 
     this.delete = function (ids) {