github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Removed unnecessary use of kbn-top-nav in dev tools app (wrapping tabs) (#39785)

Browse source
This commit is contained in:
Liza Katz 2019-06-29 12:19:08 +03:00 • committed by GitHub
parent 2bf06185da
commit 6165e19ef2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/legacy/core_plugins/console/public/index.html
View file

@ -1,5 +1,5 @@
<kbn-top-nav name="console" config="topNavMenu"></kbn-top-nav>
<kbn-dev-tools-app data-test-subj="console" top-nav-config="topNavController">
<kbn-dev-tools-app data-test-subj="console">
<sense-history ng-show="showHistory" is-shown="showHistory" history-dirty="lastRequestTimestamp"></sense-history>
<div class="conApp">
<div class="conApp__editor">

43
src/legacy/core_plugins/kibana/public/dev_tools/partials/dev_tools_app.html
View file

@ -1,27 +1,22 @@
<div class="devApp app-container">
<kbn-top-nav name="devtools" config="kbnDevToolsApp.topNavConfig">
<!-- Transcluded elements. -->
<div data-transclude-slots>
<!-- Tabs. -->
<div data-transclude-slot="bottomRow" class="euiTabs" role="tablist">
<a
role="tab"
aria-selected="{{kbnDevToolsApp.currentPath === item.url}}"
ng-repeat="item in kbnDevToolsApp.devTools"
class="euiTab"
ng-class="{'euiTab-isSelected': kbnDevToolsApp.currentPath === item.url, 'euiTab-isDisabled': item.disabled}"
ng-disabled="item.disabled"
kbn-href="{{::item.url}}"
ng-click="kbnDevToolsApp.onClick(item, $event)"
tooltip="{{ item.tooltipContent }}"
tooltip-placement="bottom"
tooltip-popup-delay="0"
tooltip-append-to-body="1"
>
{{::item.display}}
</a>
</div>
</div>
</kbn-top-nav>
<!-- Tabs. -->
<div class="euiTabs" role="tablist">
<a
role="tab"
aria-selected="{{kbnDevToolsApp.currentPath === item.url}}"
ng-repeat="item in kbnDevToolsApp.devTools"
class="euiTab"
ng-class="{'euiTab-isSelected': kbnDevToolsApp.currentPath === item.url, 'euiTab-isDisabled': item.disabled}"
ng-disabled="item.disabled"
kbn-href="{{::item.url}}"
ng-click="kbnDevToolsApp.onClick(item, $event)"
tooltip="{{ item.tooltipContent }}"
tooltip-placement="bottom"
tooltip-popup-delay="0"
tooltip-append-to-body="1"
>
{{::item.display}}
</a>
</div>
<main class="devApp__container" role="tabpanel" ng-transclude></main>
</div>