github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix formatting logic for terms (#125408)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Joe Reuter 2022-02-14 14:33:32 +01:00 • committed by GitHub
parent d2a5c3d5f4
commit 617a602c5d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/index.tsx
View file

@ -18,6 +18,7 @@ import {
htmlIdGenerator,
EuiButtonGroup,
} from '@elastic/eui';
import { uniq } from 'lodash';
import { AggFunctionsMapping } from '../../../../../../../../src/plugins/data/public';
import { buildExpressionFunction } from '../../../../../../../../src/plugins/expressions/public';
import { updateColumnParam, updateDefaultLabels } from '../../layer_helpers';
@ -367,12 +368,21 @@ export const termsOperation: OperationDefinition<TermsIndexPatternColumn, 'field
(fields: string[]) => {
const column = layer.columns[columnId] as TermsIndexPatternColumn;
const secondaryFields = fields.length > 1 ? fields.slice(1) : undefined;
const dataTypes = uniq(fields.map((field) => indexPattern.getFieldByName(field)?.type));
const newDataType = (dataTypes.length === 1 ? dataTypes[0] : 'string') || column.dataType;
const newParams = {
...column.params,
};
if ('format' in newParams && newDataType !== 'number') {
delete newParams.format;
}
updateLayer({
...layer,
columns: {
...layer.columns,
[columnId]: {
...column,
dataType: newDataType,
sourceField: fields[0],
label: ofName(
indexPattern.getFieldByName(fields[0])?.displayName,
@ -380,10 +390,10 @@ export const termsOperation: OperationDefinition<TermsIndexPatternColumn, 'field
column.params.orderBy.type === 'rare'
),
params: {
...column.params,
...newParams,
secondaryFields,
parentFormat: getParentFormatter({
...column.params,
...newParams,
secondaryFields,
}),
},