github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Refresh fields when data view is edited (#149861)

Browse source 
Closes https://github.com/elastic/kibana/issues/149838
This commit is contained in:
Julia Rechkunova 2023-02-03 09:24:21 +01:00 • committed by GitHub
parent 136171a63d
commit 62d348433f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/data_view_editor/public/components/data_view_flyout_content_container.tsx
View file

@ -64,6 +64,8 @@ const DataViewFlyoutContentContainer = ({
}
if (saveResponse && !(saveResponse instanceof Error)) {
await dataViews.refreshFields(saveResponse);
if (persist) {
const message = i18n.translate('indexPatternEditor.saved', {
defaultMessage: "Saved '{indexPatternName}'",

7
test/functional/apps/discover/group2/_data_view_edit.ts
View file

@ -68,7 +68,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
await PageObjects.discover.createAdHocDataView(initialPattern, true);
expect(await PageObjects.discover.getCurrentlySelectedDataView()).to.be(`${initialPattern}*`);
await retry.waitFor('current data view to get updated', async () => {
return (await PageObjects.discover.getCurrentlySelectedDataView()) === `${initialPattern}*`;
});
await PageObjects.discover.waitUntilSidebarHasLoaded();
expect(await PageObjects.discover.getHitCountInt()).to.be(2);
@ -83,6 +86,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await retry.try(async () => {
expect(await PageObjects.discover.getHitCountInt()).to.be(1);
});
await PageObjects.discover.waitUntilSidebarHasLoaded();
expect((await PageObjects.discover.getAllFieldNames()).length).to.be(2);
});
});

3
test/functional/page_objects/discover_page.ts
View file

@ -441,6 +441,9 @@ export class DiscoverPageObject extends FtrService {
async createAdHocDataView(name: string, hasTimeField = false) {
await this.testSubjects.click('discover-dataView-switch-link');
await this.unifiedSearch.createNewDataView(name, true, hasTimeField);
await this.retry.waitFor('flyout to get closed', async () => {
return !(await this.testSubjects.exists('indexPatternEditor__form'));
});
}
async clickAddField() {