github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix nodedetail flaky test (#115612)

Browse source 
* add test-subj to page loading component

* wait for page to load before navigating to node

* enable node_detail functional tests

* a different approach

* bump timeouts

* Revert "add test-subj to page loading component"

This reverts commit 1840cdf7b8.

* remove unused method

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Kevin Lacabane 2021-10-21 10:46:20 +02:00 • committed by GitHub
parent 1eb0f4aecd
commit 647ca9a82b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
x-pack/test/functional/apps/monitoring/elasticsearch/node_detail.js
View file

@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }) {
const nodesList = getService('monitoringElasticsearchNodes');
const nodeDetail = getService('monitoringElasticsearchNodeDetail');
// FLAKY https://github.com/elastic/kibana/issues/115130
describe.skip('Elasticsearch node detail', () => {
describe('Elasticsearch node detail', () => {
describe('Active Nodes', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

3
x-pack/test/functional/apps/monitoring/elasticsearch/node_detail_mb.js
View file

@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }) {
const nodesList = getService('monitoringElasticsearchNodes');
const nodeDetail = getService('monitoringElasticsearchNodeDetail');
// Failing: See https://github.com/elastic/kibana/issues/115255
describe.skip('Elasticsearch node detail mb', () => {
describe('Elasticsearch node detail mb', () => {
describe('Active Nodes', () => {
const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);

7
x-pack/test/functional/services/monitoring/elasticsearch_nodes.js
View file

@ -51,8 +51,11 @@ export function MonitoringElasticsearchNodesProvider({ getService, getPageObject
return pageId !== null;
}
clickRowByResolver(nodeResolver) {
return testSubjects.click(SUBJ_NODE_LINK_PREFIX + nodeResolver);
async clickRowByResolver(nodeResolver) {
await retry.waitForWithTimeout('redirection to node detail', 30000, async () => {
await testSubjects.click(SUBJ_NODE_LINK_PREFIX + nodeResolver, 5000);
return testSubjects.exists('elasticsearchNodeDetailStatus', { timeout: 5000 });
});
}
async waitForTableToFinishLoading() {