github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Sample Data/Functional test] Fix flaky sample data test (#224955)

Browse source 
## Summary

The `isSampleDataSetInstalled` function had an inefficient code pattern.
It uses `testSubjects.find()`, which has a 10 second default timeout.
When the sample data card doesn't exist, this call waits for 10 seconds
before failing, which slows down the `retry.waitFor` loop (20 second
timeout) in `addSampleDataSet` and tended to cause the entire test to
time out.

Closes https://github.com/elastic/kibana/issues/220053
This commit is contained in:
Tim Sullivan 2025-06-24 13:49:29 -07:00 • committed by GitHub
parent f9671eb13e
commit 64b0ea15e3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/platform/test/functional/page_objects/home_page.ts
View file

@ -48,13 +48,20 @@ export class HomePageObject extends FtrService {
}
async isSampleDataSetInstalled(id: string) {
const sampleDataCard = await this.testSubjects.find(`sampleDataSetCard${id}`);
const installStatus = await (
await sampleDataCard.findByCssSelector('[data-status]')
).getAttribute('data-status');
const deleteButton = await sampleDataCard.findAllByTestSubject(`removeSampleDataSet${id}`);
this.log.debug(`Sample data installed: ${deleteButton.length > 0}`);
return installStatus === 'installed' && deleteButton.length > 0;
try {
// The find timeout is short because we don't want to hang here. Calling this method happens within
// a parent `waitFor` which handles retries.
const sampleDataCard = await this.testSubjects.find(`sampleDataSetCard${id}`, 500);
const installStatus = await (
await sampleDataCard.findByCssSelector('[data-status]')
).getAttribute('data-status');
const deleteButton = await sampleDataCard.findAllByTestSubject(`removeSampleDataSet${id}`);
this.log.debug(`Sample data installed: ${deleteButton.length > 0}`);
return installStatus === 'installed' && deleteButton.length > 0;
} catch (e) {
this.log.debug(`Sample data card for [${id}] not found.`);
return false;
}
}
async isWelcomeInterstitialDisplayed() {
@ -91,8 +98,7 @@ export class HomePageObject extends FtrService {
async addSampleDataSet(id: string) {
await this.openSampleDataAccordion();
await this.retry.waitFor('sample data to be installed', async () => {
// count for the edge case where some how installation completes just before the retry occurs
await this.retry.waitFor(`${id} sample data to be installed`, async () => {
if (await this.isSampleDataSetInstalled(id)) {
return true;
}
@ -113,7 +119,6 @@ export class HomePageObject extends FtrService {
async removeSampleDataSet(id: string) {
await this.openSampleDataAccordion();
await this.retry.waitFor('sample data to be removed', async () => {
// account for the edge case where some how data is uninstalled just before the retry occurs
if (!(await this.isSampleDataSetInstalled(id))) {
return true;
}