github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

🌊 Streams: Fix dashboards error toast on first visit of classic streams (#217163)

Browse source 
When navigating to the details page of a classic stream for the first
time, it would show an error toast from the `/dashboards` endpoint. This
happened because there was a bug in `ensureStream` - it would throw if
the data stream has been found but there wouldn't be a streams
definition.

This PR fixes the bug and adds an integration test for it.
This commit is contained in:
Joe Reuter 2025-04-04 14:51:53 +02:00 • committed by GitHub
parent 12d78d9477
commit 64d74b0fe0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/platform/plugins/shared/streams/server/lib/streams/client.ts
View file

@ -619,6 +619,7 @@ export class StreamsClient {
if (!isElasticsearch404(dataStream) && isElasticsearch404(streamDefinition)) {
// stream definition does not exist, but data stream does - create an empty stream definition
await this.updateStoredStream(this.getDataStreamAsIngestStream(dataStream));
return;
}
// if both do not exist, the stream does not exist, so this should be a 404
throw streamDefinition;

21
x-pack/test/api_integration/deployment_agnostic/apis/observability/streams/assets/dashboard.ts
View file

@ -244,6 +244,27 @@ export default function ({ getService }: DeploymentAgnosticFtrProviderContext) {
});
});
describe('on class stream that has not been touched yet', () => {
before(async () => {
await esClient.indices.createDataStream({
name: 'logs-testlogs-default',
});
});
after(async () => {
await esClient.indices.deleteDataStream({
name: 'logs-testlogs-default',
});
});
it('does not list any dashboards but returns 200', async () => {
const response = await apiClient.fetch('GET /api/streams/{name}/dashboards 2023-10-31', {
params: { path: { name: 'logs-testlogs-default' } },
});
expect(response.status).to.eql(200);
expect(response.body.dashboards.length).to.eql(0);
});
});
describe('suggestions', () => {
before(async () => {
await loadDashboards();