github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

do not handle click when no aggregation has been specified (#18825) (#18869)

Browse source
This commit is contained in:
Thomas Neirynck 2018-05-07 14:10:20 -04:00 • committed by GitHub
parent ab50bfc3fc
commit 660d01c33a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/core_plugins/region_map/public/region_map_visualization.js
View file

@ -126,6 +126,14 @@ export function RegionMapsVisualizationProvider(Private, Notifier, config) {
}
this._choroplethLayer.on('select', (event) => {
if (!this._isAggReady()) {
//even though we have maps data available and have added the choropleth layer to the map
//the aggregation may not be available yet
return;
}
const agg = this._vis.aggs.bySchemaName.segment[0];
const filter = agg.createFilter(event);
this._vis.API.queryFilter.addFilters(filter);
@ -145,10 +153,14 @@ export function RegionMapsVisualizationProvider(Private, Notifier, config) {
}
_isAggReady() {
return this._vis.getAggConfig().bySchemaName.segment && this._vis.getAggConfig().bySchemaName.segment[0];
}
_setTooltipFormatter() {
const metricsAgg = _.first(this._vis.getAggConfig().bySchemaName.metric);
if (this._vis.getAggConfig().bySchemaName.segment && this._vis.getAggConfig().bySchemaName.segment[0]) {
if (this._isAggReady()) {
const fieldName = this._vis.getAggConfig().bySchemaName.segment[0].makeLabel();
this._choroplethLayer.setTooltipFormatter(tooltipFormatter, metricsAgg, fieldName);
} else {