mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
Welcome interstitial not displayed (#190045)
## Summary Closes https://github.com/elastic/kibana/issues/186168 The tests fails because for some reason the welcome interstitial animation doesn't complete before the timeout set for the target element to be visible, it's interesting that despite waiting for the set duration of the animation for the property, with a timeout that quadruples the animation duration this tests fails still. It's worth pointing out that in all referenced instances of failure in the issue, on the second attempt the test actually passes, hence this PR only introduces a retry to the assertion that the target element is displayed. Furthermore this PR was ran through the flaky test runner [see here](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6699) with success. <!-- ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
parent
a5900591f8
commit
66458ac491
2 changed files with 9 additions and 5 deletions
|
@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
|
|||
const PageObjects = getPageObjects(['common', 'home']);
|
||||
const deployment = getService('deployment');
|
||||
|
||||
// FLAKY: https://github.com/elastic/kibana/issues/186168
|
||||
describe.skip('Welcome interstitial', () => {
|
||||
describe('Welcome interstitial', () => {
|
||||
beforeEach(async () => {
|
||||
// Need to navigate to page first to clear storage before test can be run
|
||||
await PageObjects.common.navigateToUrl('home', undefined);
|
||||
|
|
|
@ -57,9 +57,14 @@ export class HomePageObject extends FtrService {
|
|||
}
|
||||
|
||||
async isWelcomeInterstitialDisplayed() {
|
||||
// give the interstitial enough time to fade in
|
||||
await new Promise((resolve) => setTimeout(resolve, 500));
|
||||
return await this.testSubjects.isDisplayed('homeWelcomeInterstitial', 2000);
|
||||
// This element inherits style defined {@link https://github.com/elastic/kibana/blob/v8.14.3/src/core/public/styles/core_app/_mixins.scss#L72|here}
|
||||
// with an animation duration set to $euiAnimSpeedExtraSlow {@see https://eui.elastic.co/#/theming/more-tokens#animation},
|
||||
// hence we setup a delay so the interstitial has enough time to fade in
|
||||
const animSpeedExtraSlow = 500;
|
||||
await new Promise((resolve) => setTimeout(resolve, animSpeedExtraSlow));
|
||||
return this.retry.try(async () => {
|
||||
return await this.testSubjects.isDisplayed('homeWelcomeInterstitial', animSpeedExtraSlow * 4);
|
||||
});
|
||||
}
|
||||
|
||||
async isGuidedOnboardingLandingDisplayed() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue