[ML] Add missing aria-label attribute to various components (#20117) (#20119)

This commit is contained in:
Pete Harverson 2018-06-21 14:09:24 +01:00 committed by GitHub
parent 9ba0689dcd
commit 66a73ddcff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 6 deletions

View file

@ -20,7 +20,10 @@
</div> </div>
<div class="details-select"> <div class="details-select">
<select class="kuiSelect" ng-model="detailsMode" ng-change="detailsModeChanged(detailsMode)"> <select class="kuiSelect"
ng-model="detailsMode"
ng-change="detailsModeChanged(detailsMode)"
aria-label="Select metric details display">
<option value="distribution">distribution of values</option> <option value="distribution">distribution of values</option>
<option value="top">top values</option> <option value="top">top values</option>
</select> </select>

View file

@ -71,7 +71,7 @@
<ng-pluralize count="metricCards.length" when="{'1':'field exists', 'other':'fields exist'}">fields exist</ng-pluralize> in documents ( <ng-pluralize count="metricCards.length" when="{'1':'field exists', 'other':'fields exist'}">fields exist</ng-pluralize> in documents (
<span class="field-emphasis">{{ totalMetricFieldCount }}</span> in total) <span class="field-emphasis">{{ totalMetricFieldCount }}</span> in total)
</div> </div>
<div ng-if="showAllMetrics === true" class="field-count-label euiFlexItem euiFlexItem--flexGrowZero"> <div ng-if="showAllMetrics === true" class="field-count-label euiFlexItem euiFlexItem--flexGrowZero">
<span class="field-emphasis">{{ metricCards.length }}</span> <span class="field-emphasis">{{ metricCards.length }}</span>
<ng-pluralize count="metricCards.length" when="{'1':'field', 'other':'fields'}">fields</ng-pluralize> <ng-pluralize count="metricCards.length" when="{'1':'field', 'other':'fields'}">fields</ng-pluralize>
@ -79,7 +79,7 @@
<span class="field-emphasis">{{ populatedMetricFieldCount }}</span> <span class="field-emphasis">{{ populatedMetricFieldCount }}</span>
<ng-pluralize count="populatedMetricFieldCount" when="{'1':'exists', 'other':'exist'}">exist</ng-pluralize> in documents) <ng-pluralize count="populatedMetricFieldCount" when="{'1':'exists', 'other':'exist'}">exist</ng-pluralize> in documents)
</div> </div>
<div ng-hide="populatedMetricFieldCount === totalMetricFieldCount" class="field-group-input euiFlexItem euiFlexItem--flexGrowZero"> <div ng-hide="populatedMetricFieldCount === totalMetricFieldCount" class="field-group-input euiFlexItem euiFlexItem--flexGrowZero">
<input id="toggleAllMetricsCheckbox" type="checkbox" class="kuiCheckBox" ng-click="toggleAllMetrics()" ng-checked="showAllMetrics === true"> <input id="toggleAllMetricsCheckbox" type="checkbox" class="kuiCheckBox" ng-click="toggleAllMetrics()" ng-checked="showAllMetrics === true">
<label for="toggleAllMetricsCheckbox">show empty fields</label> <label for="toggleAllMetricsCheckbox">show empty fields</label>
@ -137,7 +137,10 @@
<div class="field-filter-controls euiFlexItem euiFlexItem--flexGrowZero"> <div class="field-filter-controls euiFlexItem euiFlexItem--flexGrowZero">
<div class="euiFlexGroup euiFlexGroup--gutterSmall euiFlexGroup--responsive"> <div class="euiFlexGroup euiFlexGroup--gutterSmall euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero"> <div class="euiFlexItem euiFlexItem--flexGrowZero">
<select class="kuiSelect type-input" ng-model="filterFieldType" ng-change="filterFieldTypeChanged(filterFieldType)"> <select class="kuiSelect type-input"
ng-model="filterFieldType"
ng-change="filterFieldTypeChanged(filterFieldType)"
aria-label="Select field types">
<option value="*">All field types</option> <option value="*">All field types</option>
<option ng-repeat="type in indexedFieldTypes" value="{{type}}">{{type}} types</option> <option ng-repeat="type in indexedFieldTypes" value="{{type}}">{{type}} types</option>
</select> </select>

View file

@ -90,6 +90,7 @@
</ml-bucket-span-estimator> </ml-bucket-span-estimator>
<button class="euiButton euiButton--primary euiButton--small euiButton--fill navbar-btn-link btn-load-vis" <button class="euiButton euiButton--primary euiButton--small euiButton--fill navbar-btn-link btn-load-vis"
aria-label="Run search"
ng-click="loadVis()" ng-click="loadVis()"
ng-disabled="ui.formValid === false || jobState === JOB_STATE.RUNNING || jobState === JOB_STATE.STOPPING || jobState === JOB_STATE.FINISHED" > ng-disabled="ui.formValid === false || jobState === JOB_STATE.RUNNING || jobState === JOB_STATE.STOPPING || jobState === JOB_STATE.FINISHED" >
<i class="fa fa-play" ></i> <i class="fa fa-play" ></i>

View file

@ -22,8 +22,7 @@
> >
<button class="kuiButton kuiButton--primary" <button class="kuiButton kuiButton--primary"
ng-click="newCalendarClick()" ng-click="newCalendarClick()"
aria-label="Create new dashboard" aria-label="Create new calendar"
data-test-subj="newDashboardLink"
tooltip="Create new calendar" tooltip="Create new calendar"
ng-disabled='buttonChecks.newButtonDisabled()' ng-disabled='buttonChecks.newButtonDisabled()'
tooltip-append-to-body="true"> tooltip-append-to-body="true">