[eslint] add rule for auto-fixing unused imports (#131772)

* [eslint] add rule for auto-fixing unused imports

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Update index_table.test.js

* Update follower_indices_list.test.js

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

packages/elastic-eslint-config-kibana/.eslintrc.js

@@ -196,5 +196,6 @@ module.exports = {
     '@kbn/eslint/no_this_in_property_initializers': 'error',
     '@kbn/imports/no_unresolvable_imports': 'error',
     '@kbn/imports/uniform_imports': 'error',
+    '@kbn/imports/no_unused_imports': 'error',
   },
 };

packages/kbn-eslint-plugin-imports/README.md

@@ -53,4 +53,8 @@ Config example:
 
 This config will find any import of `@kbn/kitchen-sink` which specifically references the `Spatula` or `isSpatula` exports, remove the old exports from the import (potentially removing the entire import), and add a new import after the previous following it's style pointing to the new package.
 
-The auto-fixer here covers the vast majority of import styles in the repository but might not cover everything, including `import * as Namespace from '@kbn/kitchen-sink'`. Imports like this will need to be found and updated manually, though TypeScript should be able to find the vast majority of those.
+The auto-fixer here covers the vast majority of import styles in the repository but might not cover everything, including `import * as Namespace from '@kbn/kitchen-sink'`. Imports like this will need to be found and updated manually, though TypeScript should be able to find the vast majority of those.
+
+## `@kbn/imports/no_unused_imports`
+
+This rule finds imports that are unused and provides an auto-fix to remove them. When ESLint appears to be running in an editor, as defined by [`helpers/running_in_editor.ts`](src/helpers/running_in_editor.ts), this rule provided suggestions instead of fixes so that the removals are not applied automatically in case you are debugging, returning early, or something else which makes ESLint think that the import is unused when it isn't. On CI and in the pre-commit hook though, this fix will be applied automatically.

packages/kbn-eslint-plugin-imports/src/helpers/running_in_editor.ts

@@ -7,7 +7,8 @@
  */
 
 export const RUNNING_IN_EDITOR =
+  !process.env.IS_KIBANA_PRECOMIT_HOOK &&
   // vscode sets this in the env for all workers
-  !!process.env.VSCODE_CWD ||
-  // MacOS sets this for intellij processes, not sure if it works in webstorm but we could expand this check later
-  !!process.env.__CFBundleIdentifier?.startsWith('com.jetbrains.intellij');
+  (!!process.env.VSCODE_CWD ||
+    // MacOS sets this for intellij processes, not sure if it works in webstorm but we could expand this check later
+    !!process.env.__CFBundleIdentifier?.startsWith('com.jetbrains.intellij'));

packages/kbn-eslint-plugin-imports/src/index.ts

@@ -10,6 +10,7 @@ export * from './get_import_resolver';
 import { NoUnresolvableImportsRule } from './rules/no_unresolvable_imports';
 import { UniformImportsRule } from './rules/uniform_imports';
 import { ExportsMovedPackagesRule } from './rules/exports_moved_packages';
+import { NoUnusedImportsRule } from './rules/no_unused_imports';
 
 /**
  * Custom ESLint rules, add `'@kbn/eslint-plugin-imports'` to your eslint config to use them
@@ -19,4 +20,5 @@ export const rules = {
   no_unresolvable_imports: NoUnresolvableImportsRule,
   uniform_imports: UniformImportsRule,
   exports_moved_packages: ExportsMovedPackagesRule,
+  no_unused_imports: NoUnusedImportsRule,
 };

packages/kbn-eslint-plugin-imports/src/rules/no_unused_imports.test.ts

@@ -0,0 +1,151 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { RuleTester } from 'eslint';
+import { NoUnusedImportsRule } from './no_unused_imports';
+import dedent from 'dedent';
+
+const fmt = (str: TemplateStringsArray) => dedent(str) + '\n';
+
+const tsTester = [
+  '@typescript-eslint/parser',
+  new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
+    parserOptions: {
+      sourceType: 'module',
+      ecmaVersion: 2018,
+      ecmaFeatures: {
+        jsx: true,
+      },
+    },
+  }),
+] as const;
+
+const babelTester = [
+  '@babel/eslint-parser',
+  new RuleTester({
+    parser: require.resolve('@babel/eslint-parser'),
+    parserOptions: {
+      sourceType: 'module',
+      ecmaVersion: 2018,
+      requireConfigFile: false,
+      babelOptions: {
+        presets: ['@kbn/babel-preset/node_preset'],
+      },
+    },
+  }),
+] as const;
+
+for (const [name, tester] of [tsTester, babelTester]) {
+  describe(name, () => {
+    tester.run('@kbn/imports/no_unused_imports', NoUnusedImportsRule, {
+      valid: [
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            import { foo, bar as Bar } from 'new'
+            use(foo, Bar)
+          `,
+        },
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            import Old from 'old'
+            use(Old)
+          `,
+        },
+      ],
+
+      invalid: [
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            import { foo, bar as Bar } from 'old'
+          `,
+          errors: [
+            {
+              line: 1,
+              message: 'All imports from "old" are unused and should be removed',
+            },
+          ],
+          output: '',
+        },
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            import type { foo, bar as Bar } from 'old'
+          `,
+          errors: [
+            {
+              line: 1,
+              message: 'All imports from "old" are unused and should be removed',
+            },
+          ],
+          output: '',
+        },
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            import type { foo, bar as Bar } from 'old'
+            use(foo)
+          `,
+          errors: [
+            {
+              line: 1,
+              message: 'Bar is unused and should be removed',
+            },
+          ],
+          output: fmt`
+            import type { foo,  } from 'old'
+            use(foo)
+          `,
+        },
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            import type { foo, bar as Bar } from 'old'
+            use(Bar)
+          `,
+          errors: [
+            {
+              line: 1,
+              message: 'foo is unused and should be removed',
+            },
+          ],
+          output: fmt`
+            import type {  bar as Bar } from 'old'
+            use(Bar)
+          `,
+        },
+        {
+          filename: 'foo.ts',
+          code: fmt`
+            // @ts-expect-error
+            // @ts-ignore
+            // foo message
+            // eslint-disable-next-line some-other-rule
+            import type { foo, bar as Bar } from 'old'
+          `,
+          errors: [
+            {
+              line: 4,
+              message: `Definition for rule 'some-other-rule' was not found.`,
+            },
+            {
+              line: 5,
+              message: 'All imports from "old" are unused and should be removed',
+            },
+          ],
+          output: fmt`
+            // foo message
+          `,
+        },
+      ],
+    });
+  });
+}

packages/kbn-eslint-plugin-imports/src/rules/no_unused_imports.ts

@@ -0,0 +1,184 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { Rule, Scope, AST } from 'eslint';
+import type { Comment } from 'estree';
+import * as T from '@babel/types';
+import { TSESTree } from '@typescript-eslint/typescript-estree';
+
+import { RUNNING_IN_EDITOR } from '../helpers/running_in_editor';
+
+type WithParent<T> = T & { parent?: WithParent<T> };
+type SomeNode = WithParent<T.Node> | TSESTree.Node;
+type SomeImportNode = NonNullable<ReturnType<typeof findImportParent>>;
+
+function findImportParent(def: Scope.Definition) {
+  let cursor: SomeNode | undefined = def.node;
+  while (cursor) {
+    if (
+      T.isImportDeclaration(cursor) ||
+      cursor.type === TSESTree.AST_NODE_TYPES.ImportDeclaration
+    ) {
+      return cursor;
+    }
+    cursor = cursor.parent;
+  }
+  return;
+}
+
+function isEslintUsed(variable: any) {
+  return !!variable.eslintUsed;
+}
+
+function findUnusedImportDefs(globalScope: Scope.Scope) {
+  if (globalScope.type !== 'global') {
+    throw new Error('pass the global scope');
+  }
+
+  const unused = [];
+
+  for (const scope of globalScope.childScopes) {
+    if (scope.type !== 'module') {
+      continue;
+    }
+
+    for (const variable of scope.variables) {
+      if (variable.references.length > 0 || isEslintUsed(variable)) {
+        continue;
+      }
+
+      for (const def of variable.defs) {
+        const importParent = findImportParent(def);
+        if (importParent) {
+          unused.push({
+            def,
+            importParent,
+          });
+        }
+      }
+    }
+  }
+
+  return unused;
+}
+
+function isTsOrEslintIgnore(comment: Comment) {
+  const value = comment.value.trim();
+  return (
+    value.startsWith('@ts-ignore') ||
+    value.startsWith('@ts-expect-error') ||
+    value.startsWith('eslint-disable')
+  );
+}
+
+export const NoUnusedImportsRule: Rule.RuleModule = {
+  meta: {
+    fixable: 'code',
+    docs: {
+      url: 'https://github.com/elastic/kibana/blob/main/packages/kbn-eslint-plugin-imports/README.md#kbnimportsno_unused_imports',
+    },
+  },
+  create(context) {
+    const source = context.getSourceCode();
+
+    function getRange(
+      nodeA: { loc?: AST.SourceLocation | null },
+      nodeB: { loc?: AST.SourceLocation | null } | number = nodeA
+    ): AST.Range {
+      if (!nodeA.loc) {
+        throw new Error('unable to use babel AST nodes without locations');
+      }
+      const nodeBLoc = typeof nodeB === 'number' ? nodeB : nodeB.loc;
+      if (nodeBLoc == null) {
+        throw new Error('unable to use babel AST nodes without locations');
+      }
+      return [
+        source.getIndexFromLoc(nodeA.loc.start),
+        typeof nodeBLoc === 'number'
+          ? source.getIndexFromLoc(nodeA.loc.end) + nodeBLoc
+          : source.getIndexFromLoc(nodeBLoc.end),
+      ];
+    }
+
+    function report(
+      node: SomeNode,
+      msg: string,
+      fix: (fixer: Rule.RuleFixer) => IterableIterator<Rule.Fix>
+    ) {
+      context.report({
+        node: node as any,
+        message: msg,
+        ...(RUNNING_IN_EDITOR
+          ? {
+              suggest: [
+                {
+                  desc: 'Remove',
+                  fix,
+                },
+              ],
+            }
+          : {
+              fix,
+            }),
+      });
+    }
+
+    return {
+      'Program:exit': () => {
+        const unusedByImport = new Map<SomeImportNode, Scope.Definition[]>();
+        for (const { importParent, def } of findUnusedImportDefs(context.getScope())) {
+          const group = unusedByImport.get(importParent);
+          if (group) {
+            group.push(def);
+          } else {
+            unusedByImport.set(importParent, [def]);
+          }
+        }
+
+        for (const [importParent, defs] of unusedByImport) {
+          if (importParent.specifiers.length === defs.length) {
+            report(
+              importParent,
+              `All imports from "${importParent.source.value}" are unused and should be removed`,
+              function* (fixer) {
+                // remove entire import including trailing newline if it's detected
+                const textPlus1 = source.getText(importParent as any, 0, 1);
+                const range = getRange(importParent, textPlus1.endsWith('\n') ? 1 : importParent);
+
+                // if the import is preceeded by one or more eslint/tslint disable comments then remove them
+                for (const comment of source.getCommentsBefore(importParent as any)) {
+                  if (isTsOrEslintIgnore(comment)) {
+                    const cRange = getRange(comment);
+                    yield fixer.removeRange(
+                      source.text[cRange[1]] !== '\n' ? cRange : getRange(comment, 1)
+                    );
+                  }
+                }
+
+                yield fixer.removeRange(range);
+              }
+            );
+          } else {
+            for (const def of defs) {
+              report(
+                def.node,
+                `${def.name.name} is unused and should be removed`,
+                function* (fixer) {
+                  const nextToken = source.getTokenAfter(def.node);
+                  yield fixer.removeRange(
+                    getRange(def.node, nextToken?.value === ',' ? nextToken : undefined)
+                  );
+                }
+              );
+            }
+          }
+        }
+      },
+    };
+  },
+};

packages/kbn-i18n-react/src/index.tsx

@@ -6,8 +6,6 @@
  * Side Public License, v 1.
  */
 
-// eslint-disable-next-line @kbn/eslint/module_migration
-import { InjectedIntl as _InjectedIntl, InjectedIntlProps as _InjectedIntlProps } from 'react-intl';
 // eslint-disable-next-line @kbn/eslint/module_migration
 export type { InjectedIntl, InjectedIntlProps } from 'react-intl';
 

packages/kbn-test/types/ftr_globals/mocha.d.ts

@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { Suite } from 'mocha';
+import 'mocha';
 
 declare module 'mocha' {
   interface Suite {

src/dev/build/lib/scan.ts

@@ -12,9 +12,6 @@ import { join } from 'path';
 import * as Rx from 'rxjs';
 import { map, mergeAll, mergeMap } from 'rxjs/operators';
 
-// @ts-ignore
-import { assertAbsolute } from './fs';
-
 const getStat$ = Rx.bindNodeCallback<[string], [Fs.Stats]>(Fs.stat);
 const getReadDir$ = Rx.bindNodeCallback<[string], [string[]]>(Fs.readdir);
 

src/dev/i18n/utils/verify_icu_message.ts

@@ -9,7 +9,7 @@
 // @ts-ignore
 import parser from 'intl-messageformat-parser';
 // @ts-ignore
-import { createParserErrorMessage, traverseNodes } from './utils';
+import { createParserErrorMessage } from './utils';
 import { SelectFormatNode } from './intl_types';
 
 export function checkEnglishOnly(message: string) {

src/dev/run_precommit_hook.js

@@ -16,6 +16,8 @@ import { getFilesForCommit, checkFileCasing } from './precommit_hook';
 
 run(
   async ({ log, flags }) => {
+    process.env.IS_KIBANA_PRECOMIT_HOOK = 'true';
+
     const files = await getFilesForCommit(flags.ref);
     const errors = [];
 

src/plugins/dashboard/public/application/actions/add_to_library_action.tsx

@@ -6,8 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
-
 import { Action, IncompatibleActionError } from '../../services/ui_actions';
 import {
   ViewMode,

src/plugins/dashboard/public/application/actions/unlink_from_library_action.tsx

@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
 import { NotificationsStart } from '@kbn/core/public';
 import { Action, IncompatibleActionError } from '../../services/ui_actions';
 import {

src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx

@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
 import React from 'react';
 import ReactDOM from 'react-dom';
 import { I18nProvider } from '@kbn/i18n-react';

src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.ts

@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
 import { History } from 'history';
 import { debounceTime, switchMap } from 'rxjs/operators';
 import { useCallback, useEffect, useMemo, useState } from 'react';

src/plugins/dashboard/public/application/lib/build_dashboard_container.ts

@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
 import type { KibanaExecutionContext } from '@kbn/core/public';
 import { DashboardSavedObject } from '../../saved_dashboards';
 import { DashboardContainer, DASHBOARD_CONTAINER_TYPE } from '../embeddable';

src/plugins/dashboard/public/application/lib/load_saved_dashboard_state.ts

@@ -6,8 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
-
 import { getDashboard60Warning, dashboardLoadingErrorStrings } from '../../dashboard_strings';
 import { savedObjectToDashboardState } from './convert_dashboard_state';
 import { DashboardState, DashboardBuildContext } from '../../types';

src/plugins/data/common/search/aggs/utils/time_splits.ts

@@ -7,7 +7,7 @@
  */
 
 import moment from 'moment';
-import _, { isArray } from 'lodash';
+import { isArray } from 'lodash';
 import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
 
 import { RangeFilter } from '@kbn/es-query';

src/plugins/saved_objects_management/public/management_section/objects_table/components/import_summary.test.tsx

@@ -13,9 +13,6 @@ import { httpServiceMock } from '@kbn/core/public/mocks';
 import { ImportSummary, ImportSummaryProps } from './import_summary';
 import { FailedImport } from '../../../lib';
 
-// @ts-expect-error
-import { findTestSubject } from '@elastic/eui/lib/test';
-
 describe('ImportSummary', () => {
   let basePath: ReturnType<typeof httpServiceMock.createBasePath>;
 

src/plugins/unified_search/public/index_pattern_select/create_index_pattern_select.tsx

@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import _ from 'lodash';
 import React from 'react';
 
 import { IndexPatternsContract } from '@kbn/data-plugin/public';

src/plugins/vis_types/vislib/public/vislib/percentage_mode_transform.ts

@@ -6,8 +6,6 @@
  * Side Public License, v 1.
  */
 
-// @ts-ignore
-import numeral from '@elastic/numeral';
 import { getFormatService } from '../services';
 
 export function getValueForPercentageMode(value: string | number, percentageFormatPattern: string) {

test/functional/page_objects/common_page.ts

@@ -8,8 +8,6 @@
 
 import { setTimeout as setTimeoutAsync } from 'timers/promises';
 import expect from '@kbn/expect';
-// @ts-ignore
-import fetch from 'node-fetch';
 import { getUrl } from '@kbn/test';
 import moment from 'moment';
 import { FtrService } from '../ftr_provider_context';

test/functional/services/combo_box.ts

@@ -8,8 +8,6 @@
 
 import { FtrService } from '../ftr_provider_context';
 import { WebElementWrapper } from './lib/web_element_wrapper';
-// @ts-ignore not supported yet
-import { scrollIntoViewIfNecessary } from './lib/web_element_wrapper/scroll_into_view_if_necessary';
 
 /**
  * wrapper around EuiComboBox interactions

x-pack/plugins/canvas/canvas_plugin_src/functions/browser/esdocs.ts

@@ -11,9 +11,6 @@ import {
 } from '@kbn/expressions-plugin/common';
 import { lastValueFrom } from 'rxjs';
 
-// @ts-expect-error untyped local
-import { buildESRequest } from '../../../common/lib/request/build_es_request';
-
 import { searchService } from '../../../public/services';
 import { ESSQL_SEARCH_STRATEGY } from '../../../common/lib/constants';
 import { EssqlSearchStrategyRequest, EssqlSearchStrategyResponse } from '../../../types';

x-pack/plugins/canvas/public/components/asset_manager/asset_manager.ts

@@ -13,13 +13,9 @@ import { encode } from '@kbn/presentation-util-plugin/public';
 import { findExistingAsset } from '../../lib/find_existing_asset';
 import { VALID_IMAGE_TYPES } from '../../../common/lib/constants';
 import { getId } from '../../lib/get_id';
-// @ts-expect-error untyped local
-import { elementsRegistry } from '../../lib/elements_registry';
-// @ts-expect-error untyped local
-import { addElement } from '../../state/actions/elements';
 import { getAssets } from '../../state/selectors/assets';
 // @ts-expect-error untyped local
-import { removeAsset, createAsset } from '../../state/actions/assets';
+import { createAsset } from '../../state/actions/assets';
 import { State, AssetType } from '../../../types';
 
 import { AssetManager as Component } from './asset_manager.component';

x-pack/plugins/canvas/public/components/home/hooks/use_import_workpad.ts

@@ -9,8 +9,6 @@ import { useCallback } from 'react';
 import { useHistory } from 'react-router-dom';
 import { i18n } from '@kbn/i18n';
 
-// @ts-expect-error
-import { getDefaultWorkpad } from '../../../state/defaults';
 import { useNotifyService, useWorkpadService } from '../../../services';
 
 import type { CanvasWorkpad } from '../../../../types';

x-pack/plugins/canvas/public/components/home/my_workpads/upload_dropzone.tsx

@@ -6,8 +6,6 @@
  */
 
 import React, { FC, useState } from 'react';
-// @ts-expect-error untyped library
-import Dropzone from 'react-dropzone';
 
 import { useNotifyService } from '../../../services';
 import { ErrorStrings } from '../../../../i18n';

x-pack/plugins/canvas/public/components/sidebar/global_config/filter_config.tsx

@@ -7,8 +7,6 @@
 
 import React, { FC } from 'react';
 import { WorkpadFilters } from '../../workpad_filters';
-// @ts-expect-error unconverted component
-import { SidebarSection } from '../sidebar_section';
 
 export const FilterConfig: FC = () => {
   return <WorkpadFilters />;

x-pack/plugins/canvas/public/components/workpad_header/edit_menu/edit_menu.tsx

@@ -20,8 +20,6 @@ import { crawlTree } from '../../workpad_page/integration_utils';
 // @ts-expect-error untyped local
 import { insertNodes, elementLayer, removeElements } from '../../../state/actions/elements';
 // @ts-expect-error untyped local
-import { undoHistory, redoHistory } from '../../../state/actions/history';
-// @ts-expect-error untyped local
 import { selectToplevelNodes } from '../../../state/actions/transient';
 import {
   getSelectedPage,

x-pack/plugins/canvas/public/services/stubs/workpad.ts

@@ -9,7 +9,7 @@ import moment from 'moment';
 import { PluginServiceFactory } from '@kbn/presentation-util-plugin/public';
 
 // @ts-expect-error
-import { getDefaultWorkpad, getExportedWorkpad } from '../../state/defaults';
+import { getDefaultWorkpad } from '../../state/defaults';
 import { CanvasWorkpadService } from '../workpad';
 import { CanvasTemplate, CanvasWorkpad } from '../../../types';
 

x-pack/plugins/canvas/storybook/addon/src/state.ts

@@ -13,14 +13,9 @@ import { isFunction } from 'lodash';
 
 import { EVENTS } from './constants';
 
-// @ts-expect-error untyped local
-import { resolvedArgs } from '../../../public/state/middleware/resolved_args';
-
 // @ts-expect-error untyped local
 import { getRootReducer } from '../../../public/state/reducers';
 
-// @ts-expect-error Untyped local
-import { getDefaultWorkpad } from '../../../public/state/defaults';
 // @ts-expect-error Untyped local
 import { getInitialState as getState } from '../../../public/state/initial_state';
 import { State } from '../../../types';

x-pack/plugins/canvas/storybook/decorators/redux_decorator.tsx

@@ -11,8 +11,6 @@ import { Provider as ReduxProvider } from 'react-redux';
 import { cloneDeep } from 'lodash';
 import { set } from '@elastic/safer-lodash-set';
 
-// @ts-expect-error Untyped local
-import { getDefaultWorkpad } from '../../public/state/defaults';
 import { CanvasWorkpad, CanvasElement, CanvasAsset, CanvasPage } from '../../types';
 
 // @ts-expect-error untyped local

x-pack/plugins/cross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js

@@ -5,13 +5,6 @@
  * 2.0.
  */
 
-/**
- * The below import is required to avoid a console error warn from brace package
- * console.warn ../node_modules/brace/index.js:3999
-      Could not load worker ReferenceError: Worker is not defined
-          at createWorker (/<path-to-repo>/node_modules/brace/index.js:17992:5)
- */
-import { stubWebWorker } from '@kbn/test-jest-helpers'; // eslint-disable-line no-unused-vars
 import { act } from 'react-dom/test-utils';
 
 import { getFollowerIndexMock } from './fixtures/follower_index';

x-pack/plugins/cross_cluster_replication/public/app/components/remote_clusters_provider.js

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import React, { PureComponent } from 'react'; // eslint-disable-line no-unused-vars
+import { PureComponent } from 'react'; // eslint-disable-line no-unused-vars
 import { loadRemoteClusters } from '../services/api';
 
 export class RemoteClustersProvider extends PureComponent {

x-pack/plugins/index_management/__jest__/components/index_table.test.js

@@ -9,14 +9,7 @@ import React from 'react';
 import { Provider } from 'react-redux';
 import { MemoryRouter } from 'react-router-dom';
 import { findTestSubject } from '@elastic/eui/lib/test';
-
-/**
- * The below import is required to avoid a console error warn from brace package
- * console.warn ../node_modules/brace/index.js:3999
-      Could not load worker ReferenceError: Worker is not defined
-          at createWorker (/<path-to-repo>/node_modules/brace/index.js:17992:5)
- */
-import { mountWithIntl, stubWebWorker } from '@kbn/test-jest-helpers'; // eslint-disable-line no-unused-vars
+import { mountWithIntl } from '@kbn/test-jest-helpers'; // eslint-disable-line no-unused-vars
 import { init as initHttpRequests } from '../client_integration/helpers/http_requests';
 
 import { BASE_PATH } from '../../common/constants';

x-pack/plugins/infra/types/eui.d.ts

@@ -10,7 +10,7 @@
  *       package includes them.
  */
 
-import { IconType, ToolTipPositions } from '@elastic/eui';
+import { IconType } from '@elastic/eui';
 import { CommonProps } from '@elastic/eui/src/components/common';
 
 declare module '@elastic/eui' {

x-pack/plugins/logstash/public/application/index.tsx

@@ -25,8 +25,6 @@ import {
 import { PipelineList } from './components/pipeline_list';
 import { PipelineEditView } from './pipeline_edit_view';
 // @ts-ignore
-import { Pipeline } from '../models/pipeline';
-// @ts-ignore
 import * as Breadcrumbs from './breadcrumbs';
 
 export const renderApp = async (

x-pack/plugins/maps/public/classes/styles/vector/components/data_mapping/percentiles_form.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import React, { ChangeEvent, Component } from 'react';
 import { EuiFieldNumber, EuiFormRow } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';

x-pack/plugins/maps/public/classes/styles/vector/components/row_action_buttons.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import React from 'react';
 import { i18n } from '@kbn/i18n';
 import { EuiButtonIcon } from '@elastic/eui';

x-pack/plugins/maps/public/classes/styles/vector/properties/dynamic_icon_property.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import React from 'react';
 import { EuiTextColor } from '@elastic/eui';
 import type { Map as MbMap } from '@kbn/mapbox-gl';

x-pack/plugins/maps/public/classes/styles/vector/vector_style.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import React, { CSSProperties, ReactElement } from 'react';
 import { FeatureIdentifier, Map as MbMap } from '@kbn/mapbox-gl';
 import { FeatureCollection } from 'geojson';
@@ -27,7 +26,7 @@ import {
 } from '../../../../common/constants';
 import { StyleMeta } from './style_meta';
 // @ts-expect-error
-import { getMakiSymbol, PREFERRED_ICONS } from './symbol_utils';
+import { getMakiSymbol } from './symbol_utils';
 import { VectorIcon } from './components/legend/vector_icon';
 import { VectorStyleLegend } from './components/legend/vector_style_legend';
 import { getHasLabel } from './style_util';

x-pack/plugins/maps/public/connected_components/map_container/map_container.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import React, { Component } from 'react';
 import classNames from 'classnames';
 import { EuiFlexGroup, EuiFlexItem, EuiCallOut } from '@elastic/eui';

x-pack/plugins/maps/public/connected_components/map_settings_panel/custom_icons_panel.tsx

@@ -20,8 +20,6 @@ import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 import { DEFAULT_CUSTOM_ICON_CUTOFF, DEFAULT_CUSTOM_ICON_RADIUS } from '../../../common/constants';
 import { getIsDarkMode } from '../../kibana_services';
-// @ts-expect-error
-import { getCustomIconId } from '../../classes/styles/vector/symbol_utils';
 import { SymbolIcon } from '../../classes/styles/vector/components/legend/symbol_icon';
 import { CustomIconModal } from '../../classes/styles/vector/components/symbol/custom_icon_modal';
 import { CustomIcon } from '../../../common/descriptor_types';

x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/analysis_fields_table.tsx

@@ -9,7 +9,7 @@ import React, { FC, Fragment, useEffect, useState } from 'react';
 import { EuiCallOut, EuiFormRow, EuiPanel, EuiSpacer, EuiText } from '@elastic/eui';
 import { isEqual } from 'lodash';
 // @ts-ignore no declaration
-import { LEFT_ALIGNMENT, CENTER_ALIGNMENT, SortableProperties } from '@elastic/eui/lib/services';
+import { LEFT_ALIGNMENT, SortableProperties } from '@elastic/eui/lib/services';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 import { FieldSelectionItem } from '../../../../common/analytics';

x-pack/plugins/ml/public/application/services/job_service.d.ts

@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
-
 import { TimeRange } from '@kbn/data-plugin/common/query/timefilter/types';
 import { CombinedJob, Datafeed, Job } from '../../../common/types/anomaly_detection_jobs';
 import { Calendar } from '../../../common/types/calendars';

x-pack/plugins/ml/public/application/util/time_buckets.d.ts

@@ -6,7 +6,6 @@
  */
 
 import { Moment } from 'moment';
-import { UI_SETTINGS } from '@kbn/data-plugin/public';
 
 export interface TimeRangeBounds {
   min?: Moment;

x-pack/plugins/ml/server/models/bucket_span_estimator/bucket_span_estimator.d.ts

@@ -6,9 +6,6 @@
  */
 
 import { IScopedClusterClient } from '@kbn/core/server';
-import { ES_AGGREGATION } from '../../../common/constants/aggregation_types';
-import { RuntimeMappings } from '../../../common/types/fields';
-import { IndicesOptions } from '../../../common/types/anomaly_detection_jobs';
 import { BucketSpanEstimatorData } from '../../../common/types/job_service';
 
 export function estimateBucketSpanFactory({

x-pack/plugins/monitoring/public/alerts/badge.tsx

@@ -10,8 +10,6 @@ import { i18n } from '@kbn/i18n';
 import { EuiContextMenu, EuiPopover, EuiBadge, EuiSwitch } from '@elastic/eui';
 import { AlertState, CommonAlertStatus } from '../../common/types/alerts';
 import { AlertSeverity } from '../../common/enums';
-// @ts-ignore
-import { formatDateTimeLocal } from '../../common/formatting';
 import { isInSetupMode } from '../lib/setup_mode';
 import { SetupModeContext } from '../components/setup_mode/setup_mode_context';
 import { getAlertPanelsByCategory } from './lib/get_alert_panels_by_category';

x-pack/plugins/monitoring/public/application/pages/logstash/advanced.tsx

@@ -20,8 +20,6 @@ import { useRouteMatch } from 'react-router-dom';
 import { useKibana } from '@kbn/kibana-react-plugin/public';
 import { GlobalStateContext } from '../../contexts/global_state_context';
 import { ComponentProps } from '../../route_init';
-// @ts-ignore
-import { Listing } from '../../../components/logstash/listing';
 import { LogstashTemplate } from './logstash_template';
 // @ts-ignore
 import { DetailStatus } from '../../../components/logstash/detail_status';

x-pack/plugins/monitoring/public/application/pages/logstash/node.tsx

@@ -21,8 +21,6 @@ import { useKibana } from '@kbn/kibana-react-plugin/public';
 import { GlobalStateContext } from '../../contexts/global_state_context';
 import { ComponentProps } from '../../route_init';
 // @ts-ignore
-import { List } from '../../../components/logstash/pipeline_viewer/models/list';
-// @ts-ignore
 import { LogstashTemplate } from './logstash_template';
 // @ts-ignore
 import { DetailStatus } from '../../../components/logstash/detail_status';

x-pack/plugins/monitoring/public/application/pages/logstash/node_pipelines.tsx

@@ -13,13 +13,9 @@ import { useKibana } from '@kbn/kibana-react-plugin/public';
 import { isPipelineMonitoringSupportedInVersion } from '../../../lib/logstash/pipelines';
 import { GlobalStateContext } from '../../contexts/global_state_context';
 import { ComponentProps } from '../../route_init';
-// @ts-expect-error
-import { Listing } from '../../../components/logstash/listing';
 import { LogstashTemplate } from './logstash_template';
 // @ts-expect-error
 import { DetailStatus } from '../../../components/logstash/detail_status';
-// @ts-expect-error
-import { MonitoringTimeseriesContainer } from '../../../components/chart';
 import { useTable } from '../../hooks/use_table';
 // @ts-expect-error
 import { PipelineListing } from '../../../components/logstash/pipeline_listing/pipeline_listing';

x-pack/plugins/monitoring/server/lib/cluster/flag_supported_clusters.ts

@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-// @ts-ignore
-import { checkParam } from '../error_missing_required';
 import { STANDALONE_CLUSTER_CLUSTER_UUID } from '../../../common/constants';
 import { ElasticsearchResponse } from '../../../common/types/es';
 import { LegacyRequest, Cluster } from '../../types';

x-pack/plugins/monitoring/server/lib/cluster/get_cluster_license.ts

@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-// @ts-ignore
-import { checkParam } from '../error_missing_required';
 // @ts-ignore
 import { createQuery } from '../create_query';
 // @ts-ignore

x-pack/plugins/monitoring/server/lib/cluster/get_clusters_state.ts

@@ -6,8 +6,6 @@
  */
 
 import { find } from 'lodash';
-// @ts-ignore
-import { checkParam } from '../error_missing_required';
 import { ElasticsearchResponse, ElasticsearchModifiedSource } from '../../../common/types/es';
 import { LegacyRequest } from '../../types';
 import { getNewIndexPatterns } from './get_index_patterns';

x-pack/plugins/monitoring/server/lib/cluster/get_clusters_stats.ts

@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-// @ts-ignore
-import { checkParam } from '../error_missing_required';
 // @ts-ignore
 import { createQuery } from '../create_query';
 // @ts-ignore

x-pack/plugins/monitoring/server/lib/elasticsearch/ccr.ts

@@ -7,8 +7,6 @@
 
 import moment from 'moment';
 // @ts-ignore
-import { checkParam } from '../error_missing_required';
-// @ts-ignore
 import { ElasticsearchMetric } from '../metrics';
 // @ts-ignore
 import { createQuery } from '../create_query';

x-pack/plugins/monitoring/server/lib/elasticsearch/get_last_recovery.ts

@@ -8,8 +8,6 @@
 import moment from 'moment';
 import _ from 'lodash';
 // @ts-ignore
-import { checkParam } from '../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../create_query';
 // @ts-ignore
 import { ElasticsearchMetric } from '../metrics';

x-pack/plugins/monitoring/server/lib/elasticsearch/get_ml_jobs.ts

@@ -7,8 +7,6 @@
 
 import { includes } from 'lodash';
 // @ts-ignore
-import { checkParam } from '../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../create_query';
 // @ts-ignore
 import { ElasticsearchMetric } from '../metrics';

x-pack/plugins/monitoring/server/lib/elasticsearch/indices/get_index_summary.ts

@@ -8,8 +8,6 @@
 import { get } from 'lodash';
 import { i18n } from '@kbn/i18n';
 // @ts-ignore
-import { checkParam } from '../../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../../create_query';
 // @ts-ignore
 import { ElasticsearchMetric } from '../../metrics';

x-pack/plugins/monitoring/server/lib/elasticsearch/indices/get_indices.ts

@@ -8,8 +8,6 @@
 import { get } from 'lodash';
 import { i18n } from '@kbn/i18n';
 // @ts-ignore
-import { checkParam } from '../../error_missing_required';
-// @ts-ignore
 import { ElasticsearchMetric } from '../../metrics';
 // @ts-ignore
 import { createQuery } from '../../create_query';

x-pack/plugins/monitoring/server/lib/elasticsearch/nodes/get_node_summary.ts

@@ -7,8 +7,6 @@
 
 import { i18n } from '@kbn/i18n';
 // @ts-ignore
-import { checkParam } from '../../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../../create_query';
 // @ts-ignore
 import { ElasticsearchMetric } from '../../metrics';

x-pack/plugins/monitoring/server/lib/elasticsearch/shards/get_indices_unassigned_shard_stats.ts

@@ -7,8 +7,6 @@
 
 import { get } from 'lodash';
 // @ts-ignore
-import { checkParam } from '../../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../../create_query';
 // @ts-ignore
 import { ElasticsearchMetric } from '../../metrics';

x-pack/plugins/monitoring/server/lib/elasticsearch/shards/get_nodes_shard_count.ts

@@ -7,8 +7,6 @@
 
 import { get } from 'lodash';
 // @ts-ignore
-import { checkParam } from '../../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../../create_query';
 // @ts-ignore
 import { ElasticsearchMetric } from '../../metrics';

x-pack/plugins/monitoring/server/lib/elasticsearch/shards/get_shard_allocation.ts

@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-// @ts-ignore
-import { StringOptions } from '@kbn/config-schema/target_types/types';
 // @ts-ignore
 import { createQuery } from '../../create_query';
 // @ts-ignore

x-pack/plugins/monitoring/server/lib/kibana/get_kibana_info.ts

@@ -7,7 +7,7 @@
 
 import { merge } from 'lodash';
 // @ts-ignore
-import { checkParam, MissingRequiredError } from '../error_missing_required';
+import { MissingRequiredError } from '../error_missing_required';
 // @ts-ignore
 import { calculateAvailability } from '../calculate_availability';
 import { LegacyRequest } from '../../types';

x-pack/plugins/monitoring/server/lib/kibana/get_kibanas.ts

@@ -7,8 +7,6 @@
 
 import moment from 'moment';
 // @ts-ignore
-import { checkParam } from '../error_missing_required';
-// @ts-ignore
 import { createQuery } from '../create_query';
 // @ts-ignore
 import { calculateAvailability } from '../calculate_availability';

x-pack/plugins/rule_registry/server/routes/bulk_update_alerts.ts

@@ -7,7 +7,6 @@
 
 import { IRouter } from '@kbn/core/server';
 import * as t from 'io-ts';
-import { id as _id } from '@kbn/securitysolution-io-ts-list-types';
 import { transformError } from '@kbn/securitysolution-es-utils';
 
 import { buildRouteValidation } from './utils/route_validation';

x-pack/plugins/rule_registry/server/routes/find.ts

@@ -7,7 +7,6 @@
 
 import { IRouter } from '@kbn/core/server';
 import * as t from 'io-ts';
-import { id as _id } from '@kbn/securitysolution-io-ts-list-types';
 import { transformError } from '@kbn/securitysolution-es-utils';
 import { PositiveInteger } from '@kbn/securitysolution-io-ts-types';
 

x-pack/plugins/rule_registry/server/routes/get_alert_index.ts

@@ -7,7 +7,6 @@
 
 import { IRouter } from '@kbn/core/server';
 import * as t from 'io-ts';
-import { id as _id } from '@kbn/securitysolution-io-ts-list-types';
 import { transformError } from '@kbn/securitysolution-es-utils';
 import { validFeatureIds } from '@kbn/rule-data-utils';
 import { buildRouteValidation } from './utils/route_validation';

x-pack/plugins/rule_registry/server/routes/update_alert_by_id.ts

@@ -7,7 +7,6 @@
 
 import { IRouter } from '@kbn/core/server';
 import * as t from 'io-ts';
-import { id as _id } from '@kbn/securitysolution-io-ts-list-types';
 import { transformError } from '@kbn/securitysolution-es-utils';
 
 import { buildRouteValidation } from './utils/route_validation';

x-pack/plugins/security_solution/cypress/integration/timeline_templates/export.spec.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { exportTimeline } from '../../tasks/timelines';
 import { login, visitWithoutDateRange } from '../../tasks/login';
 import {

x-pack/plugins/security_solution/cypress/integration/timelines/export.spec.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { exportTimeline } from '../../tasks/timelines';
 import { login, visitWithoutDateRange } from '../../tasks/login';
 

x-pack/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_list.test.tsx

@@ -14,7 +14,6 @@ import { TrustedAppsList } from './trusted_apps_list';
 import { exceptionsListAllHttpMocks } from '../../mocks/exceptions_list_http_mocks';
 import { SEARCHABLE_FIELDS } from '../constants';
 import { parseQueryFilterToKQL } from '../../../common/utils';
-import { useUserPrivileges as _useUserPrivileges } from '../../../../common/components/user_privileges';
 
 jest.mock('../../../../common/components/user_privileges');
 

x-pack/plugins/session_view/public/components/process_tree/hooks.ts

@@ -4,7 +4,6 @@
  * 2.0; you may not use this file except in compliance with the Elastic License
  * 2.0.
  */
-import _ from 'lodash';
 import memoizeOne from 'memoize-one';
 import { useState, useEffect } from 'react';
 import {

x-pack/plugins/task_manager/server/ephemeral_task_lifecycle.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { Subject } from 'rxjs';
 
 import { TaskLifecycleEvent } from './polling_lifecycle';

x-pack/plugins/task_manager/server/polling/delay_on_claim_conflicts.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { Subject, of, firstValueFrom } from 'rxjs';
 import { fakeSchedulers } from 'rxjs-marbles/jest';
 import { sleep } from '../test_utils';

x-pack/plugins/task_manager/server/polling/task_poller.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { Subject, of, BehaviorSubject } from 'rxjs';
 import { Option, none, some } from 'fp-ts/lib/Option';
 import { createTaskPoller, PollingError, PollingErrorType } from './task_poller';

x-pack/plugins/task_manager/server/polling_lifecycle.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import sinon from 'sinon';
 import { Observable, of, Subject } from 'rxjs';
 

x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import sinon from 'sinon';
 import { shouldBeOneOf, mustBeAllOf } from './query_clauses';
 

x-pack/plugins/task_manager/server/queries/query_clauses.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { MustCondition, shouldBeOneOf, mustBeAllOf, matchesClauses } from './query_clauses';
 
 describe('matchesClauses', () => {

x-pack/plugins/task_manager/server/task_scheduling.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { Subject } from 'rxjs';
 import { none, some } from 'fp-ts/lib/Option';
 

x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule.tsx

@@ -18,8 +18,6 @@ import {
   EuiTabbedContent,
   EuiText,
 } from '@elastic/eui';
-// @ts-ignore
-import { RIGHT_ALIGNMENT, CENTER_ALIGNMENT } from '@elastic/eui/lib/services';
 import { FormattedMessage } from '@kbn/i18n-react';
 import moment from 'moment';
 import {

x-pack/plugins/upgrade_assistant/server/lib/kibana_status.test.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { deprecationsServiceMock } from '@kbn/core/server/mocks';
 import { DomainDeprecationDetails } from '@kbn/core/server/types';
 

x-pack/test/functional/page_objects/geo_file_upload.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import { FtrService } from '../ftr_provider_context';
 
 export class GeoFileUploadPageObject extends FtrService {

x-pack/test/plugin_api_integration/test_suites/task_manager/task_management_removed_types.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import expect from '@kbn/expect';
 import url from 'url';
 import supertest from 'supertest';

x-pack/test/security_solution_endpoint_api_int/apis/resolver/common.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import _ from 'lodash';
 import expect from '@kbn/expect';
 import { firstNonNullValue } from '@kbn/security-solution-plugin/common/endpoint/models/ecs_safety_helpers';
 import { NodeID } from '@kbn/security-solution-plugin/server/endpoint/routes/resolver/tree/utils';